Update GitLab code-sign step #4374

andrewlock · 2023-07-07T12:25:11Z

Summary of changes

Update to the newer code-signing approach
Remove the (unused) NuGet signing

Reason for change

A new approach to code-signing is rolling out, so we need to update to that one.

Implementation details

Took the same steps as in this PR. The installer files are taken from that PR (and tweaked for java/python scripts, as they didn't work initially), which similarly uses the standard installer files the agent image uses.

Summary of changes:

Install Java
Install Python
Install "winsign" tool
Update SignFile Nuke method to use the winsign tool

Built locally and pushed the image using

cd tracer/build/_build/docker/gitlab
docker build -f gitlab.windows.dockerfile --tag datadog/dd-trace-dotnet-docker-build:latest .
docker push datadog/dd-trace-dotnet-docker-build:latest

Test coverage

Ran a test build, and it look like the signature is good to me 🎉

11:28:19 [DBG] SignerCertificate                         Status             Path              
11:28:19 [DBG] -----------------                         ------             ----              
11:28:19 [DBG] B03F29CC07566505A718583E9270A6EE17678742  Valid              datadog-dotnet-...

Also, downloaded the artifacts, and confirmed the MSIs, the dlls in the nuget, and the dlls in the zip files are signed as expected except ddwaf.dll, which it looks like we have never been signing 😬 So fixed that in this PR too 👍

Other details

Renamed SignMsiAndNupkg to SignMsi since that's all we actually do. I only hadn't done it before because I didn't want to rebuild the docker image 😅

datadog-ddstaging · 2023-07-07T12:49:14Z

Datadog Report

Branch report: andrew/update-gitlab-codesigning
Commit report: ccde701

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 291161 Passed, 1091 Skipped, 29m 29.11s Wall Time

pierotibou

Haven't looked much at the files copied from the other PR though

tracer/build/_build/Build.Gitlab.cs

derekwbrown · 2023-07-10T18:47:21Z

tracer/build/_build/docker/gitlab/requirements.txt

@@ -0,0 +1,19 @@
+# python development requirements for the Datadog Agent


rather than copy/pasting the whole requirements file, this file can just be a redirect to the datadog-agent-buildimages requirements file so it's always up-to-date.

That's good in theory, but we don't currently automatically rebuild this image anyway, so it won't automatically be up to date, and it means our pipeline would break if the file moved (for example), so it might be best to just add a link to the file here and copy-past the datadog-agent-buildimages one in for now 🤔

andrewlock · 2023-07-11T13:55:21Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4374) - mean (3,009ms)  : 2893, 3124
     .   : milestone, 3009,
    master - mean (3,038ms)  : 2916, 3161
     .   : milestone, 3038,

    section CallTarget+Inlining+NGEN
    This PR (4374) - mean (3,838ms)  : 3770, 3905
     .   : milestone, 3838,
    master - mean (3,842ms)  : 3754, 3929
     .   : milestone, 3842,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4374) - mean (3,150ms)  : 3043, 3257
     .   : milestone, 3150,
    master - mean (3,123ms)  : 3019, 3227
     .   : milestone, 3123,

    section CallTarget+Inlining+NGEN
    This PR (4374) - mean (3,667ms)  : 3556, 3778
     .   : milestone, 3667,
    master - mean (3,636ms)  : 3545, 3727
     .   : milestone, 3636,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4374) - mean (3,112ms)  : 3002, 3222
     .   : milestone, 3112,
    master - mean (3,156ms)  : 3030, 3282
     .   : milestone, 3156,

    section CallTarget+Inlining+NGEN
    This PR (4374) - mean (3,621ms)  : 3537, 3706
     .   : milestone, 3621,
    master - mean (3,610ms)  : 3525, 3694
     .   : milestone, 3610,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4374) - mean (190ms)  : 184, 195
     .   : milestone, 190,
    master - mean (190ms)  : 185, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (4374) - mean (1,102ms)  : 1074, 1130
     .   : milestone, 1102,
    master - mean (1,112ms)  : 1078, 1146
     .   : milestone, 1112,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4374) - mean (369ms)  : 364, 374
     .   : milestone, 369,
    master - mean (371ms)  : 368, 374
     .   : milestone, 371,

    section CallTarget+Inlining+NGEN
    This PR (4374) - mean (1,161ms)  : 1128, 1194
     .   : milestone, 1161,
    master - mean (1,169ms)  : 1143, 1194
     .   : milestone, 1169,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4374) - mean (358ms)  : 351, 365
     .   : milestone, 358,
    master - mean (359ms)  : 354, 364
     .   : milestone, 359,

    section CallTarget+Inlining+NGEN
    This PR (4374) - mean (1,118ms)  : 1077, 1159
     .   : milestone, 1118,
    master - mean (1,127ms)  : 1093, 1161
     .   : milestone, 1127,

andrewlock · 2023-07-11T14:25:35Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4374) (10.994M)   : 0, 10993789
    master (10.989M)   : 0, 10989018
    benchmarks/2.33.0 (10.950M)   : 0, 10950076
    benchmarks/2.9.0 (10.924M)   : 0, 10924440

    section Automatic
    This PR (4374) (7.659M)   : 0, 7658546
    master (7.590M)   : 0, 7590488
    benchmarks/2.33.0 (7.644M)   : 0, 7643676
    benchmarks/2.9.0 (7.859M)   : 0, 7859484

    section Trace stats
    master (7.616M)   : 0, 7616116
    benchmarks/2.33.0 (7.672M)   : 0, 7672295

    section Manual
    This PR (4374) (9.714M)   : 0, 9713849
    master (9.748M)   : 0, 9748144
    benchmarks/2.33.0 (9.850M)   : 0, 9849660

    section Manual + Automatic
    This PR (4374) (7.300M)   : 0, 7300180
    master (7.374M)   : 0, 7373756
    benchmarks/2.33.0 (7.322M)   : 0, 7322232

    section Version Conflict
    master (6.575M)   : 0, 6574795
    benchmarks/2.33.0 (6.640M)   : 0, 6640338

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4374) (9.688M)   : 0, 9687839
    master (9.734M)   : 0, 9733675
    benchmarks/2.33.0 (9.710M)   : 0, 9710226
    benchmarks/2.9.0 (9.537M)   : 0, 9537090

    section Automatic
    This PR (4374) (6.760M)   : 0, 6760111
    master (6.780M)   : 0, 6779888
    benchmarks/2.33.0 (6.622M)   : 0, 6621713

    section Trace stats
    master (6.715M)   : 0, 6715309
    benchmarks/2.33.0 (6.688M)   : 0, 6688294

    section Manual
    This PR (4374) (8.494M)   : 0, 8494333
    master (8.593M)   : 0, 8593398
    benchmarks/2.33.0 (8.494M)   : 0, 8493703

    section Manual + Automatic
    This PR (4374) (6.459M)   : 0, 6459362
    master (6.523M)   : 0, 6523431
    benchmarks/2.33.0 (6.469M)   : 0, 6469076

    section Version Conflict
    master (5.841M)   : 0, 5840729
    benchmarks/2.33.0 (5.707M)   : 0, 5706556

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4374) (10.306M)   : 0, 10305679
    master (10.107M)   : 0, 10107371
    benchmarks/2.33.0 (10.328M)   : 0, 10327902
    benchmarks/2.9.0 (10.718M)   : 0, 10718317

    section Automatic
    This PR (4374) (7.473M)   : 0, 7473090
    master (7.305M)   : 0, 7304782
    benchmarks/2.33.0 (7.597M)   : 0, 7597442
    benchmarks/2.9.0 (7.506M)   : 0, 7506283

    section Trace stats
    master (7.387M)   : 0, 7387256
    benchmarks/2.33.0 (7.363M)   : 0, 7363191

    section Manual
    This PR (4374) (9.326M)   : 0, 9325696
    master (8.912M)   : 0, 8912349
    benchmarks/2.33.0 (9.091M)   : 0, 9091133

    section Manual + Automatic
    This PR (4374) (7.370M)   : 0, 7370088
    master (7.169M)   : 0, 7169189
    benchmarks/2.33.0 (7.098M)   : 0, 7097641

    section Version Conflict
    master (6.583M)   : 0, 6582848
    benchmarks/2.33.0 (6.518M)   : 0, 6518470

gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4374) (7.749M)   : 0, 7749400
    master (7.683M)   : 0, 7683054
    benchmarks/2.33.0 (7.693M)   : 0, 7692552
    benchmarks/2.9.0 (8.043M)   : 0, 8043419

    section No attack
    This PR (4374) (2.246M)   : 0, 2245819
    master (2.212M)   : 0, 2211903
    benchmarks/2.33.0 (2.230M)   : 0, 2229957
    benchmarks/2.9.0 (3.342M)   : 0, 3342435

    section Attack
    This PR (4374) (1.922M)   : 0, 1922381
    master (1.891M)   : 0, 1890584
    benchmarks/2.33.0 (1.882M)   : 0, 1882387
    benchmarks/2.9.0 (2.652M)   : 0, 2651797

    section Blocking
    This PR (4374) (3.861M)   : 0, 3860970
    master (3.770M)   : 0, 3769590
    benchmarks/2.33.0 (3.837M)   : 0, 3836643

andrewlock · 2023-07-11T15:41:07Z

Benchmarks Report 🐌

Benchmarks for #4374 compared to master:

2 benchmarks are slower, with geometric mean 1.127
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	471μs	222ns	801ns	0	2.62 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	650μs	167ns	604ns	0	2.63 KB
master	`WriteAndFlushEnrichedTraces`	net472	799μs	456ns	1.71μs	0.398	3.22 KB
#4374	`WriteAndFlushEnrichedTraces`	net6.0	472μs	103ns	386ns	0	2.62 KB
#4374	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	643μs	881ns	3.41μs	0	2.62 KB
#4374	`WriteAndFlushEnrichedTraces`	net472	797μs	542ns	2.1μs	0.398	3.22 KB

Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	net6.0	39.1μs	73.8ns	286ns	0.0193	0	1.65 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	41.6μs	69.7ns	270ns	0.0202	0	1.63 KB
master	`AllCycleSimpleBody`	net472	42.1μs	15.5ns	57.9ns	0.252	0	1.69 KB
master	`AllCycleMoreComplexBody`	net6.0	220μs	414ns	1.6μs	0.11	0	9.22 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	230μs	224ns	867ns	0.113	0	9.12 KB
master	`AllCycleMoreComplexBody`	net472	237μs	104ns	402ns	1.42	0	9.28 KB
master	`ObjectExtractorSimpleBody`	net6.0	120ns	0.0473ns	0.177ns	0.00394	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	173ns	0.0592ns	0.222ns	0.00376	0	272 B
master	`ObjectExtractorSimpleBody`	net472	146ns	0.154ns	0.595ns	0.0446	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	2.99μs	1.23ns	4.75ns	0.0537	0	3.88 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	4.03μs	2.33ns	8.72ns	0.0524	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	net472	4.17μs	3.29ns	12.7ns	0.617	0.00623	3.89 KB
#4374	`AllCycleSimpleBody`	net6.0	39.5μs	16.5ns	64ns	0.02	0	1.65 KB
#4374	`AllCycleSimpleBody`	netcoreapp3.1	41μs	169ns	655ns	0.0206	0	1.63 KB
#4374	`AllCycleSimpleBody`	net472	41.5μs	40.1ns	150ns	0.259	0	1.69 KB
#4374	`AllCycleMoreComplexBody`	net6.0	222μs	94ns	364ns	0.111	0	9.22 KB
#4374	`AllCycleMoreComplexBody`	netcoreapp3.1	228μs	99.8ns	373ns	0.114	0	9.12 KB
#4374	`AllCycleMoreComplexBody`	net472	239μs	174ns	672ns	1.43	0	9.28 KB
#4374	`ObjectExtractorSimpleBody`	net6.0	121ns	0.0752ns	0.281ns	0.00392	0	280 B
#4374	`ObjectExtractorSimpleBody`	netcoreapp3.1	175ns	0.151ns	0.565ns	0.0037	0	272 B
#4374	`ObjectExtractorSimpleBody`	net472	145ns	0.0965ns	0.374ns	0.0446	0	281 B
#4374	`ObjectExtractorMoreComplexBody`	net6.0	3.02μs	0.795ns	2.87ns	0.0545	0	3.88 KB
#4374	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	4.11μs	1.68ns	6.27ns	0.0512	0	3.78 KB
#4374	`ObjectExtractorMoreComplexBody`	net472	4.12μs	3.94ns	15.3ns	0.618	0.00614	3.89 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	169μs	91.8ns	356ns	0.253	18.03 KB
master	`SendRequest`	netcoreapp3.1	187μs	262ns	1.02μs	0.187	20.09 KB
master	`SendRequest`	net472	0.00131ns	0.000363ns	0.00141ns	0	0 b
#4374	`SendRequest`	net6.0	166μs	105ns	393ns	0.166	18.03 KB
#4374	`SendRequest`	netcoreapp3.1	188μs	139ns	519ns	0.198	20.09 KB
#4374	`SendRequest`	net472	0.000795ns	0.000299ns	0.00116ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #4374

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.97 KB	41.51 KB	-455 B	-1.08%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	513μs	742ns	2.87μs	0.519	0	0	41.97 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	621μs	237ns	822ns	0.321	0	0	41.78 KB
master	`WriteAndFlushEnrichedTraces`	net472	789μs	3.79μs	16.5μs	8.44	2.68	0.383	53.24 KB
#4374	`WriteAndFlushEnrichedTraces`	net6.0	495μs	694ns	2.69μs	0.512	0	0	41.51 KB
#4374	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	645μs	1.07μs	4.13μs	0.311	0	0	41.6 KB
#4374	`WriteAndFlushEnrichedTraces`	net472	789μs	3.69μs	14.3μs	8.38	2.67	0.381	53.25 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	802ns	0.247ns	0.925ns	0.00988	0	720 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.13μs	1.04ns	4.03ns	0.00977	0	720 B
master	`ExecuteNonQuery`	net472	1.4μs	0.396ns	1.48ns	0.108	0.000701	682 B
#4374	`ExecuteNonQuery`	net6.0	827ns	0.2ns	0.72ns	0.00994	0	720 B
#4374	`ExecuteNonQuery`	netcoreapp3.1	1.13μs	0.461ns	1.79ns	0.00956	0	720 B
#4374	`ExecuteNonQuery`	net472	1.4μs	0.356ns	1.38ns	0.108	0	682 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`CallElasticsearch`	net6.0	994ns	0.279ns	1.08ns	0.0135	0	944 B
master	`CallElasticsearch`	netcoreapp3.1	1.29μs	0.428ns	1.6ns	0.0128	0	944 B
master	`CallElasticsearch`	net472	1.93μs	0.554ns	2.14ns	0.152	0.000972	955 B
master	`CallElasticsearchAsync`	net6.0	1.08μs	0.248ns	0.929ns	0.0129	0	920 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.29μs	0.502ns	1.88ns	0.0136	0	992 B
master	`CallElasticsearchAsync`	net472	2.08μs	0.609ns	2.36ns	0.16	0.00104	1.01 KB
#4374	`CallElasticsearch`	net6.0	916ns	0.251ns	0.94ns	0.0135	0	944 B
#4374	`CallElasticsearch`	netcoreapp3.1	1.17μs	2.59ns	10ns	0.0129	0	944 B
#4374	`CallElasticsearch`	net472	2.09μs	0.365ns	1.37ns	0.151	0.00104	955 B
#4374	`CallElasticsearchAsync`	net6.0	1.06μs	0.356ns	1.28ns	0.0127	0	920 B
#4374	`CallElasticsearchAsync`	netcoreapp3.1	1.35μs	0.651ns	2.35ns	0.013	0	992 B
#4374	`CallElasticsearchAsync`	net472	2.18μs	0.601ns	2.17ns	0.16	0.00109	1.01 KB

Benchmarks.Trace.GraphQLBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4374

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.121	1,068.16	1,197.12

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteAsync`	net6.0	1.07μs	0.496ns	1.92ns	0.013	0	912 B
master	`ExecuteAsync`	netcoreapp3.1	1.44μs	0.533ns	2ns	0.0121	0	912 B
master	`ExecuteAsync`	net472	1.52μs	2.1ns	7.86ns	0.138	0.000752	875 B
#4374	`ExecuteAsync`	net6.0	1.2μs	0.568ns	2.2ns	0.0126	0	912 B
#4374	`ExecuteAsync`	netcoreapp3.1	1.4μs	0.673ns	2.33ns	0.012	0	912 B
#4374	`ExecuteAsync`	net472	1.57μs	0.438ns	1.64ns	0.139	0	875 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	3.54μs	1.18ns	4.41ns	0.0264	1.9 KB
master	`SendAsync`	netcoreapp3.1	4.3μs	1.8ns	6.75ns	0.032	2.43 KB
master	`SendAsync`	net472	6.89μs	1.4ns	5.24ns	0.475	3 KB
#4374	`SendAsync`	net6.0	3.52μs	1.26ns	4.72ns	0.0262	1.9 KB
#4374	`SendAsync`	netcoreapp3.1	4.3μs	1.39ns	5.4ns	0.0323	2.43 KB
#4374	`SendAsync`	net472	6.87μs	1.83ns	7.08ns	0.476	3 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.3μs	0.477ns	1.78ns	0.0231	1.62 KB
master	`EnrichedLog`	netcoreapp3.1	1.89μs	2.24ns	8.39ns	0.0216	1.62 KB
master	`EnrichedLog`	net472	2.28μs	0.994ns	3.44ns	0.244	1.54 KB
#4374	`EnrichedLog`	net6.0	1.35μs	0.726ns	2.71ns	0.023	1.62 KB
#4374	`EnrichedLog`	netcoreapp3.1	1.92μs	0.801ns	3.1ns	0.0222	1.62 KB
#4374	`EnrichedLog`	net472	2.23μs	1.78ns	6.65ns	0.245	1.54 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	110μs	200ns	773ns	0	0	4.21 KB
master	`EnrichedLog`	netcoreapp3.1	116μs	194ns	724ns	0	0	4.21 KB
master	`EnrichedLog`	net472	150μs	94.4ns	340ns	0.672	0.224	4.38 KB
#4374	`EnrichedLog`	net6.0	114μs	117ns	423ns	0	0	4.21 KB
#4374	`EnrichedLog`	netcoreapp3.1	119μs	190ns	737ns	0	0	4.21 KB
#4374	`EnrichedLog`	net472	148μs	176ns	683ns	0.665	0.222	4.38 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.87μs	0.635ns	2.46ns	0.0305	2.18 KB
master	`EnrichedLog`	netcoreapp3.1	3.72μs	1.11ns	3.99ns	0.0298	2.18 KB
master	`EnrichedLog`	net472	4.7μs	1.1ns	4.26ns	0.314	1.99 KB
#4374	`EnrichedLog`	net6.0	2.93μs	0.833ns	3.12ns	0.0307	2.18 KB
#4374	`EnrichedLog`	netcoreapp3.1	3.99μs	1.37ns	5.29ns	0.0299	2.18 KB
#4374	`EnrichedLog`	net472	4.64μs	2.01ns	7.79ns	0.314	1.99 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.13μs	0.509ns	1.97ns	0.0157	1.11 KB
master	`SendReceive`	netcoreapp3.1	1.44μs	0.303ns	1.13ns	0.0149	1.11 KB
master	`SendReceive`	net472	1.73μs	0.877ns	3.04ns	0.177	1.12 KB
#4374	`SendReceive`	net6.0	1.08μs	0.415ns	1.5ns	0.0157	1.11 KB
#4374	`SendReceive`	netcoreapp3.1	1.41μs	0.843ns	3.04ns	0.0154	1.11 KB
#4374	`SendReceive`	net472	1.82μs	1.11ns	3.85ns	0.177	1.12 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.58μs	0.526ns	1.97ns	0.0206	1.53 KB
master	`EnrichedLog`	netcoreapp3.1	3.77μs	1.21ns	4.69ns	0.0205	1.58 KB
master	`EnrichedLog`	net472	4.11μs	2.42ns	9.38ns	0.31	1.96 KB
#4374	`EnrichedLog`	net6.0	2.6μs	0.642ns	2.31ns	0.0208	1.53 KB
#4374	`EnrichedLog`	netcoreapp3.1	3.44μs	2.68ns	10ns	0.0207	1.58 KB
#4374	`EnrichedLog`	net472	4.09μs	4.88ns	18.9ns	0.311	1.96 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4374

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.133	412.11	467.04

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	412ns	0.214ns	0.803ns	0.00743	536 B
master	`StartFinishSpan`	netcoreapp3.1	568ns	0.264ns	0.986ns	0.00711	536 B
master	`StartFinishSpan`	net472	662ns	0.201ns	0.777ns	0.0853	538 B
master	`StartFinishScope`	net6.0	521ns	0.166ns	0.621ns	0.00928	656 B
master	`StartFinishScope`	netcoreapp3.1	695ns	0.29ns	1.12ns	0.00898	656 B
master	`StartFinishScope`	net472	853ns	0.424ns	1.64ns	0.0981	618 B
#4374	`StartFinishSpan`	net6.0	467ns	0.0884ns	0.331ns	0.0074	536 B
#4374	`StartFinishSpan`	netcoreapp3.1	545ns	0.138ns	0.477ns	0.00743	536 B
#4374	`StartFinishSpan`	net472	632ns	0.198ns	0.767ns	0.0852	538 B
#4374	`StartFinishScope`	net6.0	508ns	0.147ns	0.57ns	0.00917	656 B
#4374	`StartFinishScope`	netcoreapp3.1	747ns	0.311ns	1.2ns	0.00865	656 B
#4374	`StartFinishScope`	net472	786ns	0.358ns	1.39ns	0.0979	618 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	634ns	0.14ns	0.524ns	0.00925	656 B
master	`RunOnMethodBegin`	netcoreapp3.1	843ns	0.378ns	1.36ns	0.0093	656 B
master	`RunOnMethodBegin`	net472	953ns	0.245ns	0.949ns	0.0978	618 B
#4374	`RunOnMethodBegin`	net6.0	602ns	0.195ns	0.729ns	0.00923	656 B
#4374	`RunOnMethodBegin`	netcoreapp3.1	774ns	0.164ns	0.613ns	0.009	656 B
#4374	`RunOnMethodBegin`	net472	980ns	0.163ns	0.611ns	0.0981	618 B

* Add initial files * Fix errors in files * Update gitlab dockerfile * Update the Gitlab build to sign the MSIs/dlls * Sign the waf too! * Remove Jarsign reference

andrewlock added 5 commits July 7, 2023 11:10

Add initial files

e1a9ddd

Fix errors in files

c5aade0

Update gitlab dockerfile

5becde8

Update the Gitlab build to sign the MSIs/dlls

698551c

Sign the waf too!

aec3844

andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Jul 7, 2023

andrewlock requested a review from derekwbrown July 7, 2023 12:25

andrewlock requested a review from a team as a code owner July 7, 2023 12:25

This comment has been minimized.

Sign in to view

pierotibou approved these changes Jul 10, 2023

View reviewed changes

derekwbrown approved these changes Jul 10, 2023

View reviewed changes

Remove Jarsign reference

ccde701

andrewlock merged commit f1ac683 into master Jul 11, 2023

andrewlock deleted the andrew/update-gitlab-codesigning branch July 11, 2023 16:44

github-actions bot added this to the vNext milestone Jul 11, 2023

bouwkast pushed a commit that referenced this pull request Jul 31, 2023

Update GitLab code-sign step (#4374)

0217332

* Add initial files * Fix errors in files * Update gitlab dockerfile * Update the Gitlab build to sign the MSIs/dlls * Sign the waf too! * Remove Jarsign reference

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update GitLab code-sign step #4374

Update GitLab code-sign step #4374

andrewlock commented Jul 7, 2023

datadog-ddstaging bot commented Jul 7, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

pierotibou left a comment

derekwbrown Jul 10, 2023

andrewlock Jul 11, 2023

andrewlock commented Jul 11, 2023

andrewlock commented Jul 11, 2023

andrewlock commented Jul 11, 2023

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #4374

Raw results

Raw results

Raw results

Slower ⚠️ in #4374

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #4374

Raw results

Raw results

		@@ -0,0 +1,19 @@
		# python development requirements for the Datadog Agent

Update GitLab code-sign step #4374

Update GitLab code-sign step #4374

Conversation

andrewlock commented Jul 7, 2023

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Jul 7, 2023 • edited Loading

Datadog Report

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

pierotibou left a comment

Choose a reason for hiding this comment

derekwbrown Jul 10, 2023

Choose a reason for hiding this comment

andrewlock Jul 11, 2023

Choose a reason for hiding this comment

andrewlock commented Jul 11, 2023

Execution-Time Benchmarks Report ⏱️

andrewlock commented Jul 11, 2023

Throughput/Crank Report:zap:

andrewlock commented Jul 11, 2023

Benchmarks Report 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #4374

Raw results

Raw results

Raw results

Slower ⚠️ in #4374

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #4374

Raw results

Raw results

datadog-ddstaging bot commented Jul 7, 2023 •

edited

Loading