Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiler] Bump libdatadog to 3.0.0 #4356

Merged
merged 1 commit into from
Jul 6, 2023
Merged

[Profiler] Bump libdatadog to 3.0.0 #4356

merged 1 commit into from
Jul 6, 2023

Conversation

gleocadie
Copy link
Collaborator

Summary of changes

Bump libdatadog to 3.0.0

@gleocadie gleocadie requested review from a team as code owners July 5, 2023 08:11
@github-actions github-actions bot added the area:profiler Issues related to the continous-profiler label Jul 5, 2023
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jul 5, 2023 •
edited
Loading

Datadog Report

Branch report: gleocadie/bump-libdatadog-to-3.0.0
Commit report: 3013687

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 290913 Passed, 1026 Skipped, 26m 31.57s Wall Time

chrisnas
chrisnas approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@chrisnas chrisnas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@gleocadie gleocadie force-pushed the gleocadie/bump-libdatadog-to-3.0.0 branch from 3c072b2 to 3013687 Compare July 6, 2023 07:21
@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4356) - mean (3,026ms)  : 2949, 3104
     .   : milestone, 3026,
    master - mean (3,013ms)  : 2892, 3135
     .   : milestone, 3013,

    section CallTarget+Inlining+NGEN
    This PR (4356) - mean (3,838ms)  : 3741, 3935
     .   : milestone, 3838,
    master - mean (3,857ms)  : 3759, 3955
     .   : milestone, 3857,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4356) - mean (3,153ms)  : 3037, 3269
     .   : milestone, 3153,
    master - mean (3,139ms)  : 3013, 3266
     .   : milestone, 3139,

    section CallTarget+Inlining+NGEN
    This PR (4356) - mean (3,635ms)  : 3570, 3699
     .   : milestone, 3635,
    master - mean (3,644ms)  : 3543, 3745
     .   : milestone, 3644,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4356) - mean (3,124ms)  : 3016, 3233
     .   : milestone, 3124,
    master - mean (3,106ms)  : 2974, 3238
     .   : milestone, 3106,

    section CallTarget+Inlining+NGEN
    This PR (4356) - mean (3,610ms)  : 3509, 3711
     .   : milestone, 3610,
    master - mean (3,612ms)  : 3558, 3666
     .   : milestone, 3612,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4356) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (192ms)  : 189, 195
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (4356) - mean (1,116ms)  : 1078, 1155
     .   : milestone, 1116,
    master - mean (1,118ms)  : 1087, 1148
     .   : milestone, 1118,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4356) - mean (372ms)  : 368, 377
     .   : milestone, 372,
    master - mean (374ms)  : 366, 381
     .   : milestone, 374,

    section CallTarget+Inlining+NGEN
    This PR (4356) - mean (1,167ms)  : 1138, 1195
     .   : milestone, 1167,
    master - mean (1,174ms)  : 1153, 1196
     .   : milestone, 1174,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4356) - mean (362ms)  : 357, 366
     .   : milestone, 362,
    master - mean (363ms)  : 358, 368
     .   : milestone, 363,

    section CallTarget+Inlining+NGEN
    This PR (4356) - mean (1,121ms)  : 1089, 1154
     .   : milestone, 1121,
    master - mean (1,131ms)  : 1100, 1162
     .   : milestone, 1131,
Loading

@andrewlock
Copy link
Member

Benchmarks Report 🐌

Benchmarks for #4356 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.147
  • 1 benchmarks are slower, with geometric mean 1.169
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 485μs 440ns 1.71μs 0 0 0 2.62 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 646μs 347ns 1.3μs 0 0 0 2.63 KB
master WriteAndFlushEnrichedTraces net472 802μs 256ns 991ns 0.398 0 0 3.22 KB
#4356 WriteAndFlushEnrichedTraces net6.0 502μs 129ns 500ns 0 0 0 2.62 KB
#4356 WriteAndFlushEnrichedTraces netcoreapp3.1 634μs 259ns 1μs 0 0 0 2.63 KB
#4356 WriteAndFlushEnrichedTraces net472 810μs 476ns 1.85μs 0.403 0 0 3.22 KB
Benchmarks.Trace.AppSecBodyBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4356

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody‑net6.0 1.147 3,396.08 2,961.97

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 38.6μs 7.63ns 27.5ns 0.0198 0 0 1.65 KB
master AllCycleSimpleBody netcoreapp3.1 41.5μs 45.1ns 169ns 0.0205 0 0 1.63 KB
master AllCycleSimpleBody net472 42.5μs 20.5ns 79.6ns 0.254 0 0 1.69 KB
master AllCycleMoreComplexBody net6.0 220μs 82.4ns 319ns 0.109 0 0 9.22 KB
master AllCycleMoreComplexBody netcoreapp3.1 231μs 336ns 1.3μs 0.115 0 0 9.12 KB
master AllCycleMoreComplexBody net472 237μs 65.7ns 246ns 1.42 0 0 9.28 KB
master ObjectExtractorSimpleBody net6.0 117ns 0.0391ns 0.146ns 0.00395 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 175ns 0.211ns 0.816ns 0.0037 0 0 272 B
master ObjectExtractorSimpleBody net472 149ns 0.0622ns 0.233ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3.42μs 13.9ns 66.7ns 0.0543 0 0 3.88 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.02μs 1.02ns 3.8ns 0.0503 0 0 3.78 KB
master ObjectExtractorMoreComplexBody net472 4.13μs 1.38ns 4.96ns 0.618 0.0062 0 3.89 KB
#4356 AllCycleSimpleBody net6.0 39.2μs 28.4ns 98.3ns 0.0194 0 0 1.65 KB
#4356 AllCycleSimpleBody netcoreapp3.1 40.7μs 120ns 465ns 0.0199 0 0 1.63 KB
#4356 AllCycleSimpleBody net472 41.4μs 142ns 549ns 0.266 0 0 1.69 KB
#4356 AllCycleMoreComplexBody net6.0 221μs 392ns 1.52μs 0.11 0 0 9.22 KB
#4356 AllCycleMoreComplexBody netcoreapp3.1 231μs 297ns 1.15μs 0.116 0 0 9.12 KB
#4356 AllCycleMoreComplexBody net472 239μs 86ns 333ns 1.43 0 0 9.28 KB
#4356 ObjectExtractorSimpleBody net6.0 122ns 0.0631ns 0.245ns 0.00391 0 0 280 B
#4356 ObjectExtractorSimpleBody netcoreapp3.1 174ns 0.0746ns 0.269ns 0.00371 0 0 272 B
#4356 ObjectExtractorSimpleBody net472 145ns 0.133ns 0.498ns 0.0446 0 0 281 B
#4356 ObjectExtractorMoreComplexBody net6.0 2.96μs 0.93ns 3.6ns 0.0547 0 0 3.88 KB
#4356 ObjectExtractorMoreComplexBody netcoreapp3.1 4.09μs 2.74ns 10.6ns 0.0511 0 0 3.78 KB
#4356 ObjectExtractorMoreComplexBody net472 4.14μs 4.29ns 16.6ns 0.617 0.00615 0 3.89 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 168μs 86.9ns 337ns 0.168 0 0 18.03 KB
master SendRequest netcoreapp3.1 187μs 344ns 1.33μs 0.187 0 0 20.09 KB
master SendRequest net472 0.001ns 0.000354ns 0.00137ns 0 0 0 0 b
#4356 SendRequest net6.0 170μs 123ns 444ns 0.252 0 0 18.03 KB
#4356 SendRequest netcoreapp3.1 186μs 175ns 654ns 0.187 0 0 20.09 KB
#4356 SendRequest net472 0.000423ns 0.000178ns 0.000689ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #4356

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.84 KB 41.61 KB -238 B -0.57%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 527μs 329ns 1.27μs 0.519 0 0 41.75 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 642μs 925ns 3.46μs 0.322 0 0 41.84 KB
master WriteAndFlushEnrichedTraces net472 823μs 3.72μs 13.9μs 8.06 2.42 0.403 53.23 KB
#4356 WriteAndFlushEnrichedTraces net6.0 517μs 334ns 1.29μs 0.502 0 0 41.66 KB
#4356 WriteAndFlushEnrichedTraces netcoreapp3.1 626μs 678ns 2.63μs 0.314 0 0 41.61 KB
#4356 WriteAndFlushEnrichedTraces net472 788μs 3.37μs 13.1μs 8.2 2.34 0.391 53.22 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 883ns 0.226ns 0.845ns 0.0101 0 0 720 B
master ExecuteNonQuery netcoreapp3.1 1.18μs 0.494ns 1.91ns 0.00924 0 0 720 B
master ExecuteNonQuery net472 1.41μs 0.867ns 3.36ns 0.108 0.000708 0 682 B
#4356 ExecuteNonQuery net6.0 930ns 0.511ns 1.98ns 0.0102 0 0 720 B
#4356 ExecuteNonQuery netcoreapp3.1 1.14μs 0.517ns 2ns 0.00987 0 0 720 B
#4356 ExecuteNonQuery net472 1.45μs 0.439ns 1.7ns 0.108 0 0 682 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 958ns 0.4ns 1.55ns 0.0133 0 0 944 B
master CallElasticsearch netcoreapp3.1 1.19μs 0.855ns 3.72ns 0.0125 0 0 944 B
master CallElasticsearch net472 2.04μs 0.587ns 2.27ns 0.151 0.00102 0 955 B
master CallElasticsearchAsync net6.0 1.12μs 0.401ns 1.45ns 0.0126 0 0 920 B
master CallElasticsearchAsync netcoreapp3.1 1.33μs 0.325ns 1.22ns 0.0134 0 0 992 B
master CallElasticsearchAsync net472 2.19μs 0.773ns 2.99ns 0.16 0.0011 0 1.01 KB
#4356 CallElasticsearch net6.0 1.04μs 0.322ns 1.25ns 0.013 0 0 944 B
#4356 CallElasticsearch netcoreapp3.1 1.24μs 0.639ns 2.39ns 0.0126 0 0 944 B
#4356 CallElasticsearch net472 2.05μs 0.682ns 2.46ns 0.151 0.00101 0 955 B
#4356 CallElasticsearchAsync net6.0 1.11μs 0.514ns 1.99ns 0.0128 0 0 920 B
#4356 CallElasticsearchAsync netcoreapp3.1 1.33μs 0.871ns 3.26ns 0.0132 0 0 992 B
#4356 CallElasticsearchAsync net472 2.14μs 0.432ns 1.61ns 0.16 0 0 1.01 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.18μs 0.28ns 1.05ns 0.013 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.44μs 0.22ns 0.76ns 0.0126 0 0 912 B
master ExecuteAsync net472 1.54μs 0.562ns 2.1ns 0.139 0.000772 0 875 B
#4356 ExecuteAsync net6.0 1.13μs 0.624ns 2.34ns 0.0127 0 0 912 B
#4356 ExecuteAsync netcoreapp3.1 1.41μs 0.433ns 1.56ns 0.012 0 0 912 B
#4356 ExecuteAsync net472 1.54μs 0.489ns 1.89ns 0.138 0 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 3.75μs 1.08ns 4.17ns 0.0262 0 0 1.9 KB
master SendAsync netcoreapp3.1 4.4μs 1.38ns 5.15ns 0.0331 0 0 2.43 KB
master SendAsync net472 6.91μs 3.28ns 12.7ns 0.476 0 0 3 KB
#4356 SendAsync net6.0 3.5μs 0.775ns 2.9ns 0.0263 0 0 1.9 KB
#4356 SendAsync netcoreapp3.1 4.3μs 1.47ns 5.49ns 0.0325 0 0 2.43 KB
#4356 SendAsync net472 6.94μs 2.65ns 10.2ns 0.475 0 0 3 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.28μs 0.53ns 2.05ns 0.023 0 0 1.62 KB
master EnrichedLog netcoreapp3.1 1.83μs 0.997ns 3.86ns 0.0219 0 0 1.62 KB
master EnrichedLog net472 2.31μs 1.98ns 7.41ns 0.244 0 0 1.54 KB
#4356 EnrichedLog net6.0 1.36μs 4.16ns 16.1ns 0.0225 0 0 1.62 KB
#4356 EnrichedLog netcoreapp3.1 1.91μs 0.683ns 2.65ns 0.0219 0 0 1.62 KB
#4356 EnrichedLog net472 2.46μs 2.76ns 10.3ns 0.244 0 0 1.54 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 110μs 108ns 403ns 0.0549 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 118μs 167ns 647ns 0 0 0 4.21 KB
master EnrichedLog net472 149μs 224ns 868ns 0.664 0.221 0 4.38 KB
#4356 EnrichedLog net6.0 112μs 140ns 543ns 0.0561 0 0 4.21 KB
#4356 EnrichedLog netcoreapp3.1 120μs 243ns 941ns 0 0 0 4.21 KB
#4356 EnrichedLog net472 148μs 99.2ns 384ns 0.666 0.222 0 4.38 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.17μs 1.29ns 4.98ns 0.0518 0 0 3.71 KB
master EnrichedLog netcoreapp3.1 3.68μs 2.86ns 11.1ns 0.05 0 0 3.69 KB
master EnrichedLog net472 4.78μs 1.07ns 4.16ns 0.525 0.00239 0 3.31 KB
#4356 EnrichedLog net6.0 3.07μs 1.01ns 3.76ns 0.052 0 0 3.71 KB
#4356 EnrichedLog netcoreapp3.1 3.85μs 2.1ns 8.14ns 0.05 0 0 3.69 KB
#4356 EnrichedLog net472 4.65μs 1.67ns 6.26ns 0.526 0.00234 0 3.31 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.18μs 0.621ns 2.41ns 0.0155 0 0 1.11 KB
master SendReceive netcoreapp3.1 1.51μs 0.516ns 1.93ns 0.0156 0 0 1.11 KB
master SendReceive net472 1.86μs 0.786ns 2.94ns 0.176 0 0 1.12 KB
#4356 SendReceive net6.0 1.11μs 0.644ns 2.5ns 0.0157 0 0 1.11 KB
#4356 SendReceive netcoreapp3.1 1.48μs 0.607ns 2.35ns 0.0148 0 0 1.11 KB
#4356 SendReceive net472 1.82μs 1.91ns 7.4ns 0.177 0 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.62μs 0.954ns 3.69ns 0.021 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.61μs 1.14ns 4.41ns 0.0216 0 0 1.58 KB
master EnrichedLog net472 4.1μs 2.25ns 8.71ns 0.311 0 0 1.96 KB
#4356 EnrichedLog net6.0 2.53μs 0.652ns 2.52ns 0.0214 0 0 1.53 KB
#4356 EnrichedLog netcoreapp3.1 3.68μs 5.66ns 20.4ns 0.0199 0 0 1.58 KB
#4356 EnrichedLog net472 4.19μs 5.82ns 21.8ns 0.31 0 0 1.96 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4356

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.169 452.21 528.67

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 431ns 0.107ns 0.4ns 0.00755 0 0 536 B
master StartFinishSpan netcoreapp3.1 528ns 1.58ns 6.11ns 0.00732 0 0 536 B
master StartFinishSpan net472 645ns 0.139ns 0.538ns 0.0852 0 0 538 B
master StartFinishScope net6.0 452ns 0.13ns 0.485ns 0.00915 0 0 656 B
master StartFinishScope netcoreapp3.1 710ns 0.524ns 1.96ns 0.00913 0 0 656 B
master StartFinishScope net472 797ns 0.215ns 0.803ns 0.0979 0 0 618 B
#4356 StartFinishSpan net6.0 392ns 0.138ns 0.535ns 0.00746 0 0 536 B
#4356 StartFinishSpan netcoreapp3.1 522ns 2.92ns 18.9ns 0.00724 0 0 536 B
#4356 StartFinishSpan net472 669ns 0.376ns 1.41ns 0.0852 0 0 538 B
#4356 StartFinishScope net6.0 529ns 0.144ns 0.557ns 0.00925 0 0 656 B
#4356 StartFinishScope netcoreapp3.1 658ns 0.576ns 2.15ns 0.00888 0 0 656 B
#4356 StartFinishScope net472 802ns 0.304ns 1.09ns 0.0978 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 546ns 0.412ns 1.54ns 0.00916 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 868ns 0.226ns 0.845ns 0.00915 0 0 656 B
master RunOnMethodBegin net472 980ns 0.317ns 1.23ns 0.0982 0 0 618 B
#4356 RunOnMethodBegin net6.0 586ns 0.134ns 0.503ns 0.0091 0 0 656 B
#4356 RunOnMethodBegin netcoreapp3.1 825ns 2.51ns 9.37ns 0.0087 0 0 656 B
#4356 RunOnMethodBegin net472 934ns 0.224ns 0.868ns 0.0977 0 0 618 B

@andrewlock
Copy link
Member

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4356) (11.316M)   : 0, 11315759
    master (11.482M)   : 0, 11482087
    benchmarks/2.33.0 (11.213M)   : 0, 11212993
    benchmarks/2.9.0 (11.118M)   : 0, 11117516

    section Automatic
    This PR (4356) (7.929M)   : 0, 7928578
    master (7.927M)   : 0, 7926886
    benchmarks/2.33.0 (7.578M)   : 0, 7577833
    benchmarks/2.9.0 (8.218M)   : 0, 8217621

    section Trace stats
    master (7.818M)   : 0, 7817824
    benchmarks/2.33.0 (7.586M)   : 0, 7586413

    section Manual
    This PR (4356) (10.204M)   : 0, 10204136
    master (10.006M)   : 0, 10005697
    benchmarks/2.33.0 (10.050M)   : 0, 10049682

    section Manual + Automatic
    This PR (4356) (7.754M)   : 0, 7754405
    master (7.447M)   : 0, 7447374
    benchmarks/2.33.0 (7.461M)   : 0, 7461071

    section Version Conflict
    master (6.854M)   : 0, 6854178
    benchmarks/2.33.0 (6.706M)   : 0, 6705768
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4356) (9.755M)   : 0, 9755283
    master (9.841M)   : 0, 9841395
    benchmarks/2.33.0 (9.854M)   : 0, 9854380
    benchmarks/2.9.0 (9.560M)   : 0, 9560344

    section Automatic
    This PR (4356) (6.815M)   : 0, 6815209
    master (6.798M)   : 0, 6797977
    benchmarks/2.33.0 (6.781M)   : 0, 6781408

    section Trace stats
    master (6.747M)   : 0, 6747111
    benchmarks/2.33.0 (6.876M)   : 0, 6875549

    section Manual
    This PR (4356) (8.555M)   : 0, 8554954
    master (8.621M)   : 0, 8621123
    benchmarks/2.33.0 (8.659M)   : 0, 8658618

    section Manual + Automatic
    This PR (4356) (6.450M)   : 0, 6449726
    master (6.560M)   : 0, 6559806
    benchmarks/2.33.0 (6.364M)   : 0, 6364163

    section Version Conflict
    master (5.876M)   : 0, 5875540
    benchmarks/2.33.0 (5.865M)   : 0, 5865173
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4356) (10.535M)   : 0, 10535460
    master (10.289M)   : 0, 10289320
    benchmarks/2.33.0 (10.579M)   : 0, 10578933
    benchmarks/2.9.0 (10.207M)   : 0, 10206911

    section Automatic
    This PR (4356) (7.564M)   : 0, 7563902
    master (7.424M)   : 0, 7424499
    benchmarks/2.33.0 (7.457M)   : 0, 7457212
    benchmarks/2.9.0 (7.491M)   : 0, 7491408

    section Trace stats
    master (7.479M)   : 0, 7478835
    benchmarks/2.33.0 (7.471M)   : 0, 7470661

    section Manual
    This PR (4356) (9.443M)   : 0, 9442857
    master (9.211M)   : 0, 9210798
    benchmarks/2.33.0 (9.168M)   : 0, 9167980

    section Manual + Automatic
    This PR (4356) (7.627M)   : 0, 7627160
    master (7.339M)   : 0, 7338523
    benchmarks/2.33.0 (7.048M)   : 0, 7048019

    section Version Conflict
    master (6.765M)   : 0, 6764532
    benchmarks/2.33.0 (6.484M)   : 0, 6483597
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4356) (7.539M)   : 0, 7538991
    master (7.665M)   : 0, 7664952
    benchmarks/2.33.0 (7.894M)   : 0, 7894351
    benchmarks/2.9.0 (8.085M)   : 0, 8085159

    section No attack
    This PR (4356) (2.050M)   : 0, 2049965
    master (2.036M)   : 0, 2035663
    benchmarks/2.33.0 (2.233M)   : 0, 2232790
    benchmarks/2.9.0 (3.354M)   : 0, 3353571

    section Attack
    This PR (4356) (1.761M)   : 0, 1761101
    master (1.798M)   : 0, 1798486
    benchmarks/2.33.0 (1.937M)   : 0, 1937400
    benchmarks/2.9.0 (2.567M)   : 0, 2566556

    section Blocking
    This PR (4356) (3.779M)   : 0, 3779319
    master (3.846M)   : 0, 3845850
    benchmarks/2.33.0 (3.859M)   : 0, 3859464
Loading

@gleocadie gleocadie merged commit acde945 into master Jul 6, 2023
@gleocadie gleocadie deleted the gleocadie/bump-libdatadog-to-3.0.0 branch July 6, 2023 11:00
@github-actions github-actions bot added this to the vNext milestone Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisnas chrisnas chrisnas approved these changes

Assignees
No one assigned
Labels
area:profiler Issues related to the continous-profiler
Projects
None yet
Milestone
2.34.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gleocadie @andrewlock @chrisnas