Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add INTEGRATIONS system tests to Dotnet Tracer CI #4345

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Add INTEGRATIONS system tests to Dotnet Tracer CI #4345

merged 1 commit into from
Jul 6, 2023

Conversation

hokitam
Copy link
Contributor

@hokitam hokitam commented Jul 3, 2023

Summary of changes

Add the INTEGRATIONS scenario from System Tests to the Dotnet Tracer's CI.

Reason for change

Enabling INTEGRATIONS scenario allow us to catch potential breakages to integrations early for future PRs.

Implementation details

Test coverage

Other details

@hokitam hokitam requested a review from a team as a code owner July 3, 2023 17:44
@github-actions github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Jul 3, 2023
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jul 3, 2023 •
edited
Loading

Datadog Report

Branch report: hokitam/enable_dsm_system_tests
Commit report: 6c767bf

❄️ dd-trace-dotnet: 0 Failed, 1 New Flaky, 290624 Passed, 1026 Skipped, 39m 33.79s Wall Time

New Flaky Tests (1)

  • HttpClient_SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.HttpMessageHandlerTests

@andrewlock
Copy link
Member

Benchmarks Report 🐌

Benchmarks for #4345 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.247
  • 1 benchmarks are slower, with geometric mean 1.128
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 480μs 222ns 831ns 0 0 0 2.62 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 646μs 229ns 855ns 0 0 0 2.63 KB
master WriteAndFlushEnrichedTraces net472 798μs 191ns 689ns 0.396 0 0 3.22 KB
#4345 WriteAndFlushEnrichedTraces net6.0 476μs 85.7ns 332ns 0 0 0 2.62 KB
#4345 WriteAndFlushEnrichedTraces netcoreapp3.1 624μs 211ns 760ns 0 0 0 2.63 KB
#4345 WriteAndFlushEnrichedTraces net472 797μs 777ns 3.01μs 0.398 0 0 3.22 KB
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 38.6μs 13.2ns 49.3ns 0.0197 0 0 1.65 KB
master AllCycleSimpleBody netcoreapp3.1 41μs 47.3ns 177ns 0.0206 0 0 1.63 KB
master AllCycleSimpleBody net472 41.3μs 184ns 712ns 0.263 0 0 1.69 KB
master AllCycleMoreComplexBody net6.0 223μs 180ns 674ns 0.11 0 0 9.22 KB
master AllCycleMoreComplexBody netcoreapp3.1 229μs 308ns 1.19μs 0.116 0 0 9.12 KB
master AllCycleMoreComplexBody net472 238μs 74.5ns 279ns 1.43 0 0 9.28 KB
master ObjectExtractorSimpleBody net6.0 123ns 0.104ns 0.404ns 0.00394 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 175ns 0.0458ns 0.165ns 0.00379 0 0 272 B
master ObjectExtractorSimpleBody net472 149ns 0.117ns 0.451ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.94μs 7.75ns 29ns 0.054 0 0 3.88 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.97μs 2.35ns 8.78ns 0.0516 0 0 3.78 KB
master ObjectExtractorMoreComplexBody net472 4.12μs 2.58ns 9.98ns 0.618 0.00616 0 3.89 KB
#4345 AllCycleSimpleBody net6.0 39.2μs 11.8ns 45.7ns 0.0195 0 0 1.65 KB
#4345 AllCycleSimpleBody netcoreapp3.1 41.2μs 113ns 424ns 0.0202 0 0 1.63 KB
#4345 AllCycleSimpleBody net472 41.9μs 8.58ns 30.9ns 0.253 0 0 1.69 KB
#4345 AllCycleMoreComplexBody net6.0 222μs 53.1ns 206ns 0.11 0 0 9.22 KB
#4345 AllCycleMoreComplexBody netcoreapp3.1 230μs 83.1ns 545ns 0.115 0 0 9.12 KB
#4345 AllCycleMoreComplexBody net472 237μs 139ns 538ns 1.42 0 0 9.28 KB
#4345 ObjectExtractorSimpleBody net6.0 121ns 0.0371ns 0.139ns 0.00393 0 0 280 B
#4345 ObjectExtractorSimpleBody netcoreapp3.1 175ns 0.0708ns 0.265ns 0.00371 0 0 272 B
#4345 ObjectExtractorSimpleBody net472 150ns 0.144ns 0.56ns 0.0446 0 0 281 B
#4345 ObjectExtractorMoreComplexBody net6.0 2.99μs 0.995ns 3.85ns 0.0541 0 0 3.88 KB
#4345 ObjectExtractorMoreComplexBody netcoreapp3.1 4.12μs 1.28ns 4.8ns 0.0515 0 0 3.78 KB
#4345 ObjectExtractorMoreComplexBody net472 4.17μs 1.79ns 6.68ns 0.617 0.00628 0 3.89 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 166μs 46.7ns 181ns 0.249 0 0 18.03 KB
master SendRequest netcoreapp3.1 187μs 238ns 889ns 0.189 0 0 20.09 KB
master SendRequest net472 0.00192ns 0.000692ns 0.00268ns 0 0 0 0 b
#4345 SendRequest net6.0 168μs 154ns 596ns 0.168 0 0 18.03 KB
#4345 SendRequest netcoreapp3.1 190μs 256ns 992ns 0.189 0 0 20.09 KB
#4345 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 552μs 665ns 2.58μs 0.553 0 0 41.57 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 629μs 1.24μs 4.81μs 0.312 0 0 41.62 KB
master WriteAndFlushEnrichedTraces net472 781μs 3.63μs 14.5μs 8.15 2.33 0.388 53.21 KB
#4345 WriteAndFlushEnrichedTraces net6.0 498μs 666ns 2.31μs 0.51 0 0 41.5 KB
#4345 WriteAndFlushEnrichedTraces netcoreapp3.1 637μs 1.46μs 5.64μs 0.321 0 0 41.74 KB
#4345 WriteAndFlushEnrichedTraces net472 777μs 1.5μs 5.62μs 8.2 2.34 0.391 53.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 914ns 0.409ns 1.53ns 0.00998 0 0 720 B
master ExecuteNonQuery netcoreapp3.1 1.09μs 0.625ns 2.42ns 0.00952 0 0 720 B
master ExecuteNonQuery net472 1.32μs 1.01ns 3.9ns 0.108 0.00066 0 682 B
#4345 ExecuteNonQuery net6.0 841ns 0.223ns 0.865ns 0.0102 0 0 720 B
#4345 ExecuteNonQuery netcoreapp3.1 1.11μs 0.518ns 1.87ns 0.00946 0 0 720 B
#4345 ExecuteNonQuery net472 1.38μs 0.437ns 1.64ns 0.108 0 0 682 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.02μs 0.385ns 1.44ns 0.0134 0 0 944 B
master CallElasticsearch netcoreapp3.1 1.21μs 0.758ns 2.84ns 0.0129 0 0 944 B
master CallElasticsearch net472 1.99μs 0.73ns 2.83ns 0.151 0.000996 0 955 B
master CallElasticsearchAsync net6.0 1.2μs 0.28ns 1.08ns 0.0127 0 0 920 B
master CallElasticsearchAsync netcoreapp3.1 1.37μs 0.261ns 1.01ns 0.0136 0 0 992 B
master CallElasticsearchAsync net472 2.08μs 0.3ns 1.08ns 0.16 0.00104 0 1.01 KB
#4345 CallElasticsearch net6.0 1.03μs 0.372ns 1.44ns 0.0134 0 0 944 B
#4345 CallElasticsearch netcoreapp3.1 1.26μs 0.551ns 2.06ns 0.0128 0 0 944 B
#4345 CallElasticsearch net472 1.96μs 0.673ns 2.52ns 0.152 0.000985 0 955 B
#4345 CallElasticsearchAsync net6.0 1.21μs 0.479ns 1.73ns 0.0128 0 0 920 B
#4345 CallElasticsearchAsync netcoreapp3.1 1.34μs 1.58ns 6.12ns 0.0136 0 0 992 B
#4345 CallElasticsearchAsync net472 2.08μs 0.498ns 1.79ns 0.16 0 0 1.01 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.18μs 0.453ns 1.75ns 0.013 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.35μs 0.561ns 2.17ns 0.0124 0 0 912 B
master ExecuteAsync net472 1.47μs 0.506ns 1.96ns 0.138 0.000732 0 875 B
#4345 ExecuteAsync net6.0 1.24μs 0.41ns 1.48ns 0.0124 0 0 912 B
#4345 ExecuteAsync netcoreapp3.1 1.32μs 0.487ns 1.76ns 0.012 0 0 912 B
#4345 ExecuteAsync net472 1.56μs 0.667ns 2.58ns 0.139 0.000787 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 3.65μs 1.16ns 4.48ns 0.0256 0 0 1.9 KB
master SendAsync netcoreapp3.1 4.41μs 4.86ns 18.8ns 0.0326 0 0 2.43 KB
master SendAsync net472 6.86μs 0.974ns 3.64ns 0.475 0 0 3 KB
#4345 SendAsync net6.0 3.43μs 1.37ns 5.29ns 0.0257 0 0 1.9 KB
#4345 SendAsync netcoreapp3.1 4.27μs 0.869ns 3.25ns 0.032 0 0 2.43 KB
#4345 SendAsync net472 6.72μs 2.61ns 10.1ns 0.477 0 0 3 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.34μs 0.643ns 2.41ns 0.0224 0 0 1.62 KB
master EnrichedLog netcoreapp3.1 1.88μs 0.492ns 1.84ns 0.0216 0 0 1.62 KB
master EnrichedLog net472 2.4μs 3.13ns 12.1ns 0.245 0 0 1.54 KB
#4345 EnrichedLog net6.0 1.4μs 0.561ns 2.1ns 0.0224 0 0 1.62 KB
#4345 EnrichedLog netcoreapp3.1 1.88μs 0.863ns 3.11ns 0.0224 0 0 1.62 KB
#4345 EnrichedLog net472 2.33μs 2.65ns 10.3ns 0.245 0 0 1.54 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 111μs 179ns 695ns 0.0548 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 118μs 222ns 860ns 0 0 0 4.21 KB
master EnrichedLog net472 150μs 192ns 718ns 0.675 0.225 0 4.38 KB
#4345 EnrichedLog net6.0 112μs 184ns 714ns 0.0559 0 0 4.21 KB
#4345 EnrichedLog netcoreapp3.1 118μs 119ns 446ns 0 0 0 4.21 KB
#4345 EnrichedLog net472 150μs 235ns 911ns 0.672 0.224 0 4.38 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.13μs 1.17ns 4.38ns 0.0515 0 0 3.71 KB
master EnrichedLog netcoreapp3.1 3.81μs 1.21ns 4.35ns 0.0494 0 0 3.69 KB
master EnrichedLog net472 4.83μs 1.43ns 5.52ns 0.525 0.00241 0 3.31 KB
#4345 EnrichedLog net6.0 3.12μs 1.42ns 4.93ns 0.0515 0 0 3.71 KB
#4345 EnrichedLog netcoreapp3.1 3.86μs 1.78ns 6.66ns 0.0509 0 0 3.69 KB
#4345 EnrichedLog net472 4.79μs 1.12ns 4.35ns 0.524 0.00239 0 3.31 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.11μs 0.386ns 1.44ns 0.0155 0 0 1.11 KB
master SendReceive netcoreapp3.1 1.41μs 0.816ns 2.83ns 0.0148 0 0 1.11 KB
master SendReceive net472 1.87μs 2.4ns 9.3ns 0.177 0.000926 0 1.12 KB
#4345 SendReceive net6.0 1.08μs 0.237ns 0.822ns 0.0156 0 0 1.11 KB
#4345 SendReceive netcoreapp3.1 1.46μs 0.832ns 3.11ns 0.0153 0 0 1.11 KB
#4345 SendReceive net472 1.69μs 3.1ns 12ns 0.177 0 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.42μs 0.795ns 2.97ns 0.0216 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.58μs 0.643ns 2.4ns 0.0215 0 0 1.58 KB
master EnrichedLog net472 4.21μs 1.4ns 5.42ns 0.311 0 0 1.96 KB
#4345 EnrichedLog net6.0 2.49μs 0.708ns 2.74ns 0.0211 0 0 1.53 KB
#4345 EnrichedLog netcoreapp3.1 3.62μs 5.95ns 23.1ns 0.0199 0 0 1.58 KB
#4345 EnrichedLog net472 4.06μs 1.2ns 4.32ns 0.31 0 0 1.96 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4345

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.128 483.85 545.62

Faster 🎉 in #4345

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.247 473.13 379.31

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 473ns 0.1ns 0.389ns 0.00745 0 0 536 B
master StartFinishSpan netcoreapp3.1 630ns 0.336ns 1.3ns 0.00726 0 0 536 B
master StartFinishSpan net472 592ns 0.0956ns 0.345ns 0.0852 0 0 538 B
master StartFinishScope net6.0 484ns 0.158ns 0.589ns 0.00933 0 0 656 B
master StartFinishScope netcoreapp3.1 710ns 0.219ns 0.847ns 0.00878 0 0 656 B
master StartFinishScope net472 833ns 0.248ns 0.961ns 0.0981 0 0 618 B
#4345 StartFinishSpan net6.0 379ns 0.126ns 0.473ns 0.00756 0 0 536 B
#4345 StartFinishSpan netcoreapp3.1 612ns 0.221ns 0.828ns 0.00713 0 0 536 B
#4345 StartFinishSpan net472 584ns 0.204ns 0.762ns 0.0853 0 0 538 B
#4345 StartFinishScope net6.0 546ns 0.433ns 1.68ns 0.00924 0 0 656 B
#4345 StartFinishScope netcoreapp3.1 664ns 1.72ns 6.67ns 0.00912 0 0 656 B
#4345 StartFinishScope net472 794ns 0.26ns 0.936ns 0.0978 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 507ns 0.172ns 0.665ns 0.00911 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 820ns 0.389ns 1.45ns 0.00872 0 0 656 B
master RunOnMethodBegin net472 959ns 0.348ns 1.35ns 0.0979 0 0 618 B
#4345 RunOnMethodBegin net6.0 518ns 0.189ns 0.706ns 0.00926 0 0 656 B
#4345 RunOnMethodBegin netcoreapp3.1 777ns 0.286ns 0.991ns 0.00902 0 0 656 B
#4345 RunOnMethodBegin net472 971ns 0.156ns 0.605ns 0.0981 0 0 618 B

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4345) - mean (2,997ms)  : 2897, 3097
     .   : milestone, 2997,
    master - mean (3,046ms)  : 2920, 3172
     .   : milestone, 3046,

    section CallTarget+Inlining+NGEN
    This PR (4345) - mean (3,813ms)  : 3730, 3897
     .   : milestone, 3813,
    master - mean (3,833ms)  : 3728, 3937
     .   : milestone, 3833,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4345) - mean (3,129ms)  : 3031, 3226
     .   : milestone, 3129,
    master - mean (3,127ms)  : 3010, 3244
     .   : milestone, 3127,

    section CallTarget+Inlining+NGEN
    This PR (4345) - mean (3,643ms)  : 3574, 3712
     .   : milestone, 3643,
    master - mean (3,632ms)  : 3544, 3720
     .   : milestone, 3632,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4345) - mean (3,101ms)  : 3008, 3193
     .   : milestone, 3101,
    master - mean (3,104ms)  : 2964, 3245
     .   : milestone, 3104,

    section CallTarget+Inlining+NGEN
    This PR (4345) - mean (3,595ms)  : 3545, 3646
     .   : milestone, 3595,
    master - mean (3,603ms)  : 3520, 3685
     .   : milestone, 3603,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4345) - mean (191ms)  : 187, 194
     .   : milestone, 191,
    master - mean (191ms)  : 186, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (4345) - mean (1,096ms)  : 1051, 1141
     .   : milestone, 1096,
    master - mean (1,085ms)  : 1049, 1121
     .   : milestone, 1085,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4345) - mean (371ms)  : 366, 376
     .   : milestone, 371,
    master - mean (370ms)  : 366, 374
     .   : milestone, 370,

    section CallTarget+Inlining+NGEN
    This PR (4345) - mean (1,160ms)  : 1137, 1184
     .   : milestone, 1160,
    master - mean (1,163ms)  : 1126, 1199
     .   : milestone, 1163,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4345) - mean (358ms)  : 354, 362
     .   : milestone, 358,
    master - mean (359ms)  : 354, 365
     .   : milestone, 359,

    section CallTarget+Inlining+NGEN
    This PR (4345) - mean (1,122ms)  : 1085, 1159
     .   : milestone, 1122,
    master - mean (1,119ms)  : 1095, 1143
     .   : milestone, 1119,
Loading

@andrewlock
Copy link
Member

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4345) (11.202M)   : 0, 11202277
    master (11.090M)   : 0, 11090030
    benchmarks/2.32.0 (11.375M)   : 0, 11374525
    benchmarks/2.9.0 (10.962M)   : 0, 10962162

    section Automatic
    This PR (4345) (7.745M)   : 0, 7744850
    master (7.769M)   : 0, 7769343
    benchmarks/2.32.0 (8.070M)   : 0, 8070318
    benchmarks/2.9.0 (7.961M)   : 0, 7961307

    section Trace stats
    master (7.770M)   : 0, 7769944
    benchmarks/2.32.0 (8.090M)   : 0, 8090308

    section Manual
    This PR (4345) (9.855M)   : 0, 9854634
    master (10.029M)   : 0, 10028784
    benchmarks/2.32.0 (10.358M)   : 0, 10357559

    section Manual + Automatic
    This PR (4345) (7.395M)   : 0, 7395209
    master (7.362M)   : 0, 7362416
    benchmarks/2.32.0 (7.698M)   : 0, 7697947

    section Version Conflict
    master (6.692M)   : 0, 6691750
    benchmarks/2.32.0 (6.996M)   : 0, 6995640
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4345) (9.486M)   : 0, 9485775
    master (9.720M)   : 0, 9720071
    benchmarks/2.32.0 (9.619M)   : 0, 9619353
    benchmarks/2.9.0 (9.727M)   : 0, 9726575

    section Automatic
    This PR (4345) (6.694M)   : 0, 6693895
    master (6.740M)   : 0, 6740171
    benchmarks/2.32.0 (6.682M)   : 0, 6681889

    section Trace stats
    master (6.648M)   : 0, 6647613
    benchmarks/2.32.0 (6.899M)   : 0, 6899182

    section Manual
    This PR (4345) (8.671M)   : 0, 8670912
    master (8.566M)   : 0, 8565697
    benchmarks/2.32.0 (8.545M)   : 0, 8545110

    section Manual + Automatic
    This PR (4345) (6.513M)   : 0, 6513034
    master (6.424M)   : 0, 6424293
    benchmarks/2.32.0 (6.707M)   : 0, 6707147

    section Version Conflict
    master (5.900M)   : 0, 5899730
    benchmarks/2.32.0 (6.004M)   : 0, 6004290
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4345) (10.366M)   : 0, 10365614
    master (10.384M)   : 0, 10384309
    benchmarks/2.32.0 (10.272M)   : 0, 10272136
    benchmarks/2.9.0 (10.841M)   : 0, 10841230

    section Automatic
    This PR (4345) (7.540M)   : 0, 7540312
    master (7.421M)   : 0, 7421270
    benchmarks/2.32.0 (7.559M)   : 0, 7559361
    benchmarks/2.9.0 (7.862M)   : 0, 7862268

    section Trace stats
    master (7.549M)   : 0, 7548894
    benchmarks/2.32.0 (7.562M)   : 0, 7562409

    section Manual
    This PR (4345) (9.580M)   : 0, 9580157
    master (9.511M)   : 0, 9510968
    benchmarks/2.32.0 (9.530M)   : 0, 9530406

    section Manual + Automatic
    This PR (4345) (7.286M)   : 0, 7286318
    master (7.324M)   : 0, 7324257
    benchmarks/2.32.0 (7.279M)   : 0, 7279188

    section Version Conflict
    master (6.695M)   : 0, 6694521
    benchmarks/2.32.0 (6.827M)   : 0, 6827118
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4345) (7.611M)   : 0, 7610930
    master (7.539M)   : 0, 7538814
    benchmarks/2.32.0 (7.327M)   : 0, 7327005
    benchmarks/2.9.0 (7.934M)   : 0, 7933677

    section No attack
    This PR (4345) (2.190M)   : 0, 2189600
    master (2.195M)   : 0, 2195229
    benchmarks/2.32.0 (2.076M)   : 0, 2076414
    benchmarks/2.9.0 (3.287M)   : 0, 3286770

    section Attack
    This PR (4345) (1.857M)   : 0, 1856981
    master (1.882M)   : 0, 1882207
    benchmarks/2.32.0 (1.786M)   : 0, 1786036
    benchmarks/2.9.0 (2.600M)   : 0, 2600407

    section Blocking
    This PR (4345) (3.691M)   : 0, 3690536
    master (3.814M)   : 0, 3813723
    benchmarks/2.32.0 (3.490M)   : 0, 3490178
Loading

pierotibou
pierotibou approved these changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@pierotibou pierotibou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thank you.

@hokitam hokitam merged commit 7925051 into master Jul 6, 2023
@hokitam hokitam deleted the hokitam/enable_dsm_system_tests branch July 6, 2023 13:07
@github-actions github-actions bot added this to the vNext milestone Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierotibou pierotibou pierotibou approved these changes

@lucaspimentel lucaspimentel lucaspimentel approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
2.34.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hokitam @andrewlock @lucaspimentel @pierotibou