Enforced order in aspects generator #4342

daniel-romano-DD · 2023-07-03T16:30:37Z

Summary of changes

Enforced order in aspects generator

Reason for change

Sometimes, aspects generator received income in different order, generating differences in aspects definitions files

Implementation details

Added order constraints in code generator

tonyredondo

LGTM

datadog-ddstaging · 2023-07-03T16:52:52Z

Datadog Report

Branch report: dani/asm/fix-aspects-order
Commit report: a2e0ce2

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 290622 Passed, 1026 Skipped, 39m 32.61s Wall Time

andrewlock · 2023-07-05T09:22:40Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4342) - mean (3,037ms)  : 2963, 3110
     .   : milestone, 3037,
    master - mean (3,003ms)  : 2923, 3083
     .   : milestone, 3003,

    section CallTarget+Inlining+NGEN
    This PR (4342) - mean (3,834ms)  : 3744, 3925
     .   : milestone, 3834,
    master - mean (3,813ms)  : 3737, 3890
     .   : milestone, 3813,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4342) - mean (3,139ms)  : 3042, 3236
     .   : milestone, 3139,
    master - mean (3,144ms)  : 3019, 3269
     .   : milestone, 3144,

    section CallTarget+Inlining+NGEN
    This PR (4342) - mean (3,637ms)  : 3542, 3732
     .   : milestone, 3637,
    master - mean (3,623ms)  : 3582, 3663
     .   : milestone, 3623,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4342) - mean (3,114ms)  : 2966, 3263
     .   : milestone, 3114,
    master - mean (3,104ms)  : 2998, 3209
     .   : milestone, 3104,

    section CallTarget+Inlining+NGEN
    This PR (4342) - mean (3,612ms)  : 3529, 3694
     .   : milestone, 3612,
    master - mean (3,615ms)  : 3524, 3706
     .   : milestone, 3615,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4342) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (192ms)  : 188, 197
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (4342) - mean (1,106ms)  : 1070, 1142
     .   : milestone, 1106,
    master - mean (1,121ms)  : 1093, 1150
     .   : milestone, 1121,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4342) - mean (370ms)  : 363, 376
     .   : milestone, 370,
    master - mean (374ms)  : 366, 381
     .   : milestone, 374,

    section CallTarget+Inlining+NGEN
    This PR (4342) - mean (1,162ms)  : 1140, 1183
     .   : milestone, 1162,
    master - mean (1,168ms)  : 1145, 1191
     .   : milestone, 1168,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4342) - mean (358ms)  : 354, 361
     .   : milestone, 358,
    master - mean (363ms)  : 358, 369
     .   : milestone, 363,

    section CallTarget+Inlining+NGEN
    This PR (4342) - mean (1,117ms)  : 1091, 1144
     .   : milestone, 1117,
    master - mean (1,128ms)  : 1096, 1159
     .   : milestone, 1128,

andrewlock · 2023-07-05T09:31:53Z

Benchmarks Report 🐌

Benchmarks for #4342 compared to master:

2 benchmarks are faster, with geometric mean 1.129
3 benchmarks are slower, with geometric mean 1.192
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	497μs	324ns	1.21μs	0	2.62 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	637μs	229ns	827ns	0	2.63 KB
master	`WriteAndFlushEnrichedTraces`	net472	799μs	336ns	1.3μs	0.398	3.22 KB
#4342	`WriteAndFlushEnrichedTraces`	net6.0	453μs	63.5ns	229ns	0	2.62 KB
#4342	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	658μs	179ns	693ns	0	2.63 KB
#4342	`WriteAndFlushEnrichedTraces`	net472	789μs	265ns	1.03μs	0.396	3.22 KB

Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	net6.0	39.7μs	42.3ns	164ns	0.0199	0	1.65 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	41.5μs	53.2ns	199ns	0.0202	0	1.63 KB
master	`AllCycleSimpleBody`	net472	40.9μs	13.3ns	51.4ns	0.264	0	1.69 KB
master	`AllCycleMoreComplexBody`	net6.0	222μs	81.5ns	316ns	0.11	0	9.22 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	231μs	107ns	399ns	0.115	0	9.12 KB
master	`AllCycleMoreComplexBody`	net472	238μs	58.5ns	227ns	1.43	0	9.28 KB
master	`ObjectExtractorSimpleBody`	net6.0	122ns	0.0364ns	0.136ns	0.00396	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	175ns	0.0534ns	0.192ns	0.00369	0	272 B
master	`ObjectExtractorSimpleBody`	net472	149ns	0.125ns	0.467ns	0.0446	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	2.94μs	1.18ns	4.41ns	0.0544	0	3.88 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	4.1μs	2.11ns	7.88ns	0.0514	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	net472	4.22μs	2.39ns	8.63ns	0.617	0.00632	3.89 KB
#4342	`AllCycleSimpleBody`	net6.0	39.2μs	89.2ns	346ns	0.0194	0	1.65 KB
#4342	`AllCycleSimpleBody`	netcoreapp3.1	43.5μs	53ns	191ns	0.0213	0	1.63 KB
#4342	`AllCycleSimpleBody`	net472	42.2μs	173ns	668ns	0.252	0	1.69 KB
#4342	`AllCycleMoreComplexBody`	net6.0	221μs	49.1ns	190ns	0.11	0	9.22 KB
#4342	`AllCycleMoreComplexBody`	netcoreapp3.1	230μs	492ns	1.9μs	0.114	0	9.12 KB
#4342	`AllCycleMoreComplexBody`	net472	241μs	281ns	1.09μs	1.43	0	9.28 KB
#4342	`ObjectExtractorSimpleBody`	net6.0	129ns	0.0486ns	0.188ns	0.00393	0	280 B
#4342	`ObjectExtractorSimpleBody`	netcoreapp3.1	176ns	0.108ns	0.42ns	0.00371	0	272 B
#4342	`ObjectExtractorSimpleBody`	net472	152ns	0.152ns	0.588ns	0.0446	0	281 B
#4342	`ObjectExtractorMoreComplexBody`	net6.0	3.01μs	0.698ns	2.52ns	0.0542	0	3.88 KB
#4342	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	4.01μs	1.03ns	3.85ns	0.0521	0	3.78 KB
#4342	`ObjectExtractorMoreComplexBody`	net472	4.12μs	1.42ns	4.92ns	0.618	0.00618	3.89 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	170μs	147ns	568ns	0.17	18.03 KB
master	`SendRequest`	netcoreapp3.1	187μs	242ns	939ns	0.187	20.09 KB
master	`SendRequest`	net472	0.000936ns	0.000186ns	0.000697ns	0	0 b
#4342	`SendRequest`	net6.0	166μs	76.3ns	296ns	0.249	18.03 KB
#4342	`SendRequest`	netcoreapp3.1	188μs	258ns	1μs	0.185	20.09 KB
#4342	`SendRequest`	net472	0.000528ns	0.000251ns	0.000972ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	505μs	225ns	871ns	0.506	0	0	41.73 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	637μs	1.02μs	3.96μs	0.311	0	0	41.86 KB
master	`WriteAndFlushEnrichedTraces`	net472	780μs	3.25μs	12.6μs	8.33	2.65	0.379	53.25 KB
#4342	`WriteAndFlushEnrichedTraces`	net6.0	528μs	272ns	981ns	0.514	0	0	41.57 KB
#4342	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	636μs	662ns	2.56μs	0.317	0	0	41.7 KB
#4342	`WriteAndFlushEnrichedTraces`	net472	800μs	3.82μs	15.8μs	8.31	2.37	0.396	53.24 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	951ns	0.462ns	1.79ns	0.0103	720 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.15μs	0.298ns	1.12ns	0.00997	720 B
master	`ExecuteNonQuery`	net472	1.4μs	0.474ns	1.84ns	0.108	682 B
#4342	`ExecuteNonQuery`	net6.0	880ns	0.459ns	1.72ns	0.0101	720 B
#4342	`ExecuteNonQuery`	netcoreapp3.1	1.2μs	0.692ns	2.59ns	0.00983	720 B
#4342	`ExecuteNonQuery`	net472	1.43μs	0.431ns	1.61ns	0.108	682 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`CallElasticsearch`	net6.0	1.04μs	0.457ns	1.77ns	0.0131	0	944 B
master	`CallElasticsearch`	netcoreapp3.1	1.23μs	0.374ns	1.4ns	0.0122	0	944 B
master	`CallElasticsearch`	net472	2.04μs	0.418ns	1.56ns	0.152	0	955 B
master	`CallElasticsearchAsync`	net6.0	1.06μs	0.435ns	1.63ns	0.0127	0	920 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.25μs	0.436ns	1.63ns	0.0133	0	992 B
master	`CallElasticsearchAsync`	net472	2.17μs	1.07ns	4.16ns	0.16	0.00109	1.01 KB
#4342	`CallElasticsearch`	net6.0	1.01μs	0.543ns	2.1ns	0.0133	0	944 B
#4342	`CallElasticsearch`	netcoreapp3.1	1.21μs	0.503ns	1.95ns	0.0128	0	944 B
#4342	`CallElasticsearch`	net472	2.01μs	0.71ns	2.66ns	0.151	0.00101	955 B
#4342	`CallElasticsearchAsync`	net6.0	1.12μs	0.368ns	1.38ns	0.0127	0	920 B
#4342	`CallElasticsearchAsync`	netcoreapp3.1	1.34μs	0.975ns	3.65ns	0.0133	0	992 B
#4342	`CallElasticsearchAsync`	net472	2.11μs	0.555ns	2ns	0.16	0.00105	1.01 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteAsync`	net6.0	1.06μs	0.186ns	0.671ns	0.0128	0	912 B
master	`ExecuteAsync`	netcoreapp3.1	1.32μs	0.69ns	2.67ns	0.0125	0	912 B
master	`ExecuteAsync`	net472	1.53μs	0.601ns	2.33ns	0.139	0.000763	875 B
#4342	`ExecuteAsync`	net6.0	1.1μs	0.472ns	1.77ns	0.0126	0	912 B
#4342	`ExecuteAsync`	netcoreapp3.1	1.38μs	0.639ns	2.48ns	0.0123	0	912 B
#4342	`ExecuteAsync`	net472	1.59μs	0.43ns	1.67ns	0.139	0.000787	875 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	3.64μs	1.24ns	4.64ns	0.0254	1.9 KB
master	`SendAsync`	netcoreapp3.1	4.3μs	1.54ns	5.77ns	0.0321	2.43 KB
master	`SendAsync`	net472	6.88μs	2.28ns	8.82ns	0.477	3 KB
#4342	`SendAsync`	net6.0	3.66μs	1.15ns	4.46ns	0.0256	1.9 KB
#4342	`SendAsync`	netcoreapp3.1	4.24μs	1.37ns	5.13ns	0.0317	2.43 KB
#4342	`SendAsync`	net472	6.84μs	2.98ns	11.5ns	0.475	3 KB

Benchmarks.Trace.ILoggerBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4342

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0	1.174	1,284.66	1,507.59

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.28μs	0.883ns	3.42ns	0.0225	1.62 KB
master	`EnrichedLog`	netcoreapp3.1	1.97μs	6.68ns	25ns	0.022	1.62 KB
master	`EnrichedLog`	net472	2.28μs	3.11ns	12ns	0.244	1.54 KB
#4342	`EnrichedLog`	net6.0	1.51μs	0.648ns	2.51ns	0.0228	1.62 KB
#4342	`EnrichedLog`	netcoreapp3.1	1.92μs	1.16ns	4.35ns	0.022	1.62 KB
#4342	`EnrichedLog`	net472	2.38μs	3.4ns	13.1ns	0.244	1.54 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	111μs	150ns	581ns	0.0556	0	4.21 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	139ns	536ns	0	0	4.21 KB
master	`EnrichedLog`	net472	149μs	78.9ns	305ns	0.669	0.223	4.38 KB
#4342	`EnrichedLog`	net6.0	111μs	151ns	584ns	0.0553	0	4.21 KB
#4342	`EnrichedLog`	netcoreapp3.1	119μs	203ns	787ns	0	0	4.21 KB
#4342	`EnrichedLog`	net472	148μs	102ns	394ns	0.667	0.222	4.38 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	3.2μs	0.717ns	2.68ns	0.0516	0	3.71 KB
master	`EnrichedLog`	netcoreapp3.1	3.91μs	1.39ns	5.19ns	0.0506	0	3.69 KB
master	`EnrichedLog`	net472	4.81μs	1.57ns	6.06ns	0.526	0.0024	3.31 KB
#4342	`EnrichedLog`	net6.0	3.08μs	1.63ns	5.87ns	0.0524	0	3.71 KB
#4342	`EnrichedLog`	netcoreapp3.1	3.78μs	1.16ns	4.32ns	0.0494	0	3.69 KB
#4342	`EnrichedLog`	net472	4.88μs	1.64ns	6.14ns	0.525	0.00243	3.31 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.04μs	0.598ns	2.24ns	0.0157	0	1.11 KB
master	`SendReceive`	netcoreapp3.1	1.39μs	0.488ns	1.76ns	0.0146	0	1.11 KB
master	`SendReceive`	net472	1.81μs	0.686ns	2.66ns	0.177	0.0009	1.12 KB
#4342	`SendReceive`	net6.0	1.08μs	0.611ns	2.36ns	0.0157	0	1.11 KB
#4342	`SendReceive`	netcoreapp3.1	1.47μs	0.697ns	2.7ns	0.0152	0	1.11 KB
#4342	`SendReceive`	net472	1.75μs	0.977ns	3.52ns	0.177	0	1.12 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.51μs	0.724ns	2.71ns	0.0213	1.53 KB
master	`EnrichedLog`	netcoreapp3.1	3.44μs	1.03ns	3.85ns	0.0206	1.58 KB
master	`EnrichedLog`	net472	4.03μs	1.54ns	5.97ns	0.309	1.96 KB
#4342	`EnrichedLog`	net6.0	2.53μs	0.647ns	2.33ns	0.0216	1.53 KB
#4342	`EnrichedLog`	netcoreapp3.1	3.55μs	1.34ns	5.18ns	0.0212	1.58 KB
#4342	`EnrichedLog`	net472	4.08μs	2.46ns	9.2ns	0.309	1.96 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4342

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.233	483.30	595.95
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1	1.172	606.84	711.05

Faster 🎉 in #4342

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472	1.131	633.26	559.99

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	384ns	0.102ns	0.367ns	0.00754	536 B
master	`StartFinishSpan`	netcoreapp3.1	488ns	2.07ns	8.02ns	0.00745	536 B
master	`StartFinishSpan`	net472	633ns	0.299ns	1.16ns	0.0853	538 B
master	`StartFinishScope`	net6.0	504ns	0.156ns	0.561ns	0.00935	656 B
master	`StartFinishScope`	netcoreapp3.1	608ns	0.806ns	5.04ns	0.00902	656 B
master	`StartFinishScope`	net472	830ns	0.21ns	0.812ns	0.098	618 B
#4342	`StartFinishSpan`	net6.0	373ns	0.171ns	0.662ns	0.00754	536 B
#4342	`StartFinishSpan`	netcoreapp3.1	595ns	0.383ns	1.43ns	0.00728	536 B
#4342	`StartFinishSpan`	net472	560ns	0.155ns	0.599ns	0.0853	538 B
#4342	`StartFinishScope`	net6.0	467ns	0.197ns	0.738ns	0.00917	656 B
#4342	`StartFinishScope`	netcoreapp3.1	711ns	0.369ns	1.38ns	0.00898	656 B
#4342	`StartFinishScope`	net472	837ns	0.961ns	3.72ns	0.0982	618 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4342

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472	1.126	1,018.20	903.91

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	607ns	0.195ns	0.731ns	0.0091	656 B
master	`RunOnMethodBegin`	netcoreapp3.1	815ns	0.517ns	2ns	0.00893	656 B
master	`RunOnMethodBegin`	net472	1.02μs	0.288ns	1.11ns	0.098	618 B
#4342	`RunOnMethodBegin`	net6.0	561ns	0.104ns	0.388ns	0.00902	656 B
#4342	`RunOnMethodBegin`	netcoreapp3.1	767ns	0.3ns	1.16ns	0.00858	656 B
#4342	`RunOnMethodBegin`	net472	904ns	0.269ns	1.04ns	0.0982	618 B

andrewlock · 2023-07-05T11:18:25Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4342) (11.410M)   : 0, 11409901
    master (11.599M)   : 0, 11599378
    benchmarks/2.33.0 (11.479M)   : 0, 11478658
    benchmarks/2.9.0 (11.616M)   : 0, 11615939

    section Automatic
    This PR (4342) (7.846M)   : 0, 7846249
    master (8.055M)   : 0, 8054947
    benchmarks/2.33.0 (8.034M)   : 0, 8033885
    benchmarks/2.9.0 (8.299M)   : 0, 8298941

    section Trace stats
    master (8.149M)   : 0, 8149446
    benchmarks/2.33.0 (8.080M)   : 0, 8079606

    section Manual
    This PR (4342) (10.272M)   : 0, 10271632
    master (10.317M)   : 0, 10317381
    benchmarks/2.33.0 (10.232M)   : 0, 10231742

    section Manual + Automatic
    This PR (4342) (7.511M)   : 0, 7511001
    master (7.686M)   : 0, 7686159
    benchmarks/2.33.0 (7.752M)   : 0, 7752117

    section Version Conflict
    master (6.913M)   : 0, 6912986
    benchmarks/2.33.0 (7.012M)   : 0, 7012067

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4342) (9.685M)   : 0, 9685490
    master (9.476M)   : 0, 9475856
    benchmarks/2.33.0 (9.598M)   : 0, 9597539
    benchmarks/2.9.0 (9.733M)   : 0, 9733009

    section Automatic
    This PR (4342) (6.746M)   : 0, 6745833
    master (6.662M)   : 0, 6662022
    benchmarks/2.33.0 (6.751M)   : 0, 6750529

    section Trace stats
    master (6.701M)   : 0, 6700692
    benchmarks/2.33.0 (6.774M)   : 0, 6774413

    section Manual
    This PR (4342) (8.417M)   : 0, 8417213
    master (8.469M)   : 0, 8468774
    benchmarks/2.33.0 (8.501M)   : 0, 8501441

    section Manual + Automatic
    This PR (4342) (6.499M)   : 0, 6499285
    master (6.452M)   : 0, 6452265
    benchmarks/2.33.0 (6.462M)   : 0, 6462321

    section Version Conflict
    master (5.838M)   : 0, 5838213
    benchmarks/2.33.0 (5.893M)   : 0, 5893069

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4342) (10.489M)   : 0, 10488902
    master (10.442M)   : 0, 10442227
    benchmarks/2.33.0 (10.363M)   : 0, 10362821
    benchmarks/2.9.0 (10.346M)   : 0, 10346419

    section Automatic
    This PR (4342) (7.643M)   : 0, 7643401
    master (7.536M)   : 0, 7536033
    benchmarks/2.33.0 (7.493M)   : 0, 7492691
    benchmarks/2.9.0 (7.623M)   : 0, 7622680

    section Trace stats
    master (7.525M)   : 0, 7525113
    benchmarks/2.33.0 (7.623M)   : 0, 7623012

    section Manual
    This PR (4342) (9.430M)   : 0, 9429830
    master (9.437M)   : 0, 9437161
    benchmarks/2.33.0 (9.386M)   : 0, 9385628

    section Manual + Automatic
    This PR (4342) (7.157M)   : 0, 7157065
    master (7.210M)   : 0, 7210429
    benchmarks/2.33.0 (7.406M)   : 0, 7405511

    section Version Conflict
    master (6.716M)   : 0, 6715895
    benchmarks/2.33.0 (6.732M)   : 0, 6731683

gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4342) (7.693M)   : 0, 7692748
    master (7.667M)   : 0, 7666584
    benchmarks/2.33.0 (7.633M)   : 0, 7633081
    benchmarks/2.9.0 (7.992M)   : 0, 7991917

    section No attack
    This PR (4342) (2.025M)   : 0, 2025329
    master (2.008M)   : 0, 2008088
    benchmarks/2.33.0 (2.194M)   : 0, 2193954
    benchmarks/2.9.0 (3.329M)   : 0, 3328813

    section Attack
    This PR (4342) (1.775M)   : 0, 1774823
    master (1.710M)   : 0, 1710018
    benchmarks/2.33.0 (1.868M)   : 0, 1867607
    benchmarks/2.9.0 (2.603M)   : 0, 2602671

    section Blocking
    This PR (4342) (3.776M)   : 0, 3775652
    master (3.806M)   : 0, 3805880
    benchmarks/2.33.0 (3.745M)   : 0, 3745490

Enforced order in aspects generator

e5a88a1

daniel-romano-DD requested review from a team as code owners July 3, 2023 16:30

tonyredondo approved these changes Jul 3, 2023

View reviewed changes

pierotibou approved these changes Jul 3, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

Fixed string literals optimization sort related issues

a51b258

This comment has been minimized.

Sign in to view

Added skipped codegen file

a2e0ce2

anna-git approved these changes Jul 5, 2023

View reviewed changes

daniel-romano-DD merged commit 4be41cc into master Jul 5, 2023

daniel-romano-DD deleted the dani/asm/fix-aspects-order branch July 5, 2023 13:59

github-actions bot added this to the vNext milestone Jul 5, 2023

andrewlock mentioned this pull request Jul 10, 2023

Fix generated aspects order #4379

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enforced order in aspects generator #4342

Enforced order in aspects generator #4342

daniel-romano-DD commented Jul 3, 2023

tonyredondo left a comment

datadog-ddstaging bot commented Jul 3, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

andrewlock commented Jul 5, 2023

andrewlock commented Jul 5, 2023

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #4342

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #4342

Faster 🎉 in #4342

Raw results

Faster 🎉 in #4342

Raw results

andrewlock commented Jul 5, 2023

Enforced order in aspects generator #4342

Enforced order in aspects generator #4342

Conversation

daniel-romano-DD commented Jul 3, 2023

Summary of changes

Reason for change

Implementation details

tonyredondo left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented Jul 3, 2023 • edited Loading

Datadog Report

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

andrewlock commented Jul 5, 2023

Execution-Time Benchmarks Report ⏱️

andrewlock commented Jul 5, 2023

Benchmarks Report 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #4342

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #4342

Faster 🎉 in #4342

Raw results

Faster 🎉 in #4342

Raw results

andrewlock commented Jul 5, 2023

Throughput/Crank Report:zap:

datadog-ddstaging bot commented Jul 3, 2023 •

edited

Loading