Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump .NET SDK to 7.0.306 #4289

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Bump .NET SDK to 7.0.306 #4289

merged 5 commits into from
Jul 12, 2023

Conversation

andrewlock
Copy link
Member

@andrewlock andrewlock commented Jun 20, 2023 •
edited
Loading

Summary of changes

  • Bumps the .NET SDK version to 7.0.306 (7.0.9) in CI
  • Bumps the version of NuGet.CommandLine

Reason for change

There are security alerts for the current version of .NET SDK and NuGet we're using

Implementation details

  • Find and Replace 7.0.101 with 7.0.306
  • Copy the download link + SHA 512 for the SDK in the gitlab dockerfile
  • Manually bump the NuGet version

Test coverage

This PR is the test

Other details

  • This shouldn't break Windows images, and doesn't require any work there
  • We should update the linux (and ideally, the arm64 images) to rebuild the dockerfiles with the latest sdk so they're cached on the machine, but not critical
  • We must update the gitlab docker image after merging

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Jun 20, 2023
@andrewlock andrewlock requested review from a team as code owners June 20, 2023 12:06
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jun 20, 2023 •
edited
Loading

Datadog Report

Branch report: andrew/bump-sdk
Commit report: 5991708

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 294119 Passed, 949 Skipped, 28m 29.73s Wall Time

@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jul 10, 2023 •
edited
Loading

Datadog Report

Branch report: andrew/bump-sdk
Commit report: 66444a5

❄️ dd-trace-dotnet: 0 Failed, 1 New Flaky, 291161 Passed, 1091 Skipped, 27m 42.05s Wall Time

New Flaky Tests (1)

  • TelemetryControllerAddsAllAssembliesToCollector - Datadog.Trace.Tests.Telemetry.TelemetryControllerV2Tests - Last Failure

    Expand for error 
     Collection was modified; enumeration operation may not execute.

@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock
Copy link
Member Author

Of course, they just pushed 3.0.306 🙄 Updating this PR to target the new SDK

@andrewlock andrewlock changed the title Bump .NET SDK to 7.0.304 Bump .NET SDK to 7.0.306 Jul 11, 2023
@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4289) - mean (3,010ms)  : 2903, 3117
     .   : milestone, 3010,
    master - mean (3,005ms)  : 2899, 3111
     .   : milestone, 3005,

    section CallTarget+Inlining+NGEN
    This PR (4289) - mean (3,853ms)  : 3754, 3951
     .   : milestone, 3853,
    master - mean (3,836ms)  : 3726, 3946
     .   : milestone, 3836,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4289) - mean (3,090ms)  : 3004, 3177
     .   : milestone, 3090,
    master - mean (3,155ms)  : 3048, 3262
     .   : milestone, 3155,

    section CallTarget+Inlining+NGEN
    This PR (4289) - mean (3,617ms)  : 3570, 3665
     .   : milestone, 3617,
    master - mean (3,636ms)  : 3538, 3734
     .   : milestone, 3636,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4289) - mean (3,141ms)  : 3001, 3280
     .   : milestone, 3141,
    master - mean (3,104ms)  : 3005, 3203
     .   : milestone, 3104,

    section CallTarget+Inlining+NGEN
    This PR (4289) - mean (3,593ms)  : 3537, 3648
     .   : milestone, 3593,
    master - mean (3,612ms)  : 3540, 3685
     .   : milestone, 3612,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4289) - mean (189ms)  : 184, 194
     .   : milestone, 189,
    master - mean (189ms)  : 185, 194
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (4289) - mean (1,112ms)  : 1083, 1142
     .   : milestone, 1112,
    master - mean (1,100ms)  : 1061, 1138
     .   : milestone, 1100,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4289) - mean (373ms)  : 369, 377
     .   : milestone, 373,
    master - mean (368ms)  : 363, 373
     .   : milestone, 368,

    section CallTarget+Inlining+NGEN
    This PR (4289) - mean (1,169ms)  : 1139, 1200
     .   : milestone, 1169,
    master - mean (1,164ms)  : 1136, 1191
     .   : milestone, 1164,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4289) - mean (362ms)  : 356, 367
     .   : milestone, 362,
    master - mean (357ms)  : 351, 364
     .   : milestone, 357,

    section CallTarget+Inlining+NGEN
    This PR (4289) - mean (1,127ms)  : 1102, 1152
     .   : milestone, 1127,
    master - mean (1,111ms)  : 1082, 1141
     .   : milestone, 1111,
Loading

@andrewlock
Copy link
Member Author

Benchmarks Report 🐌

Benchmarks for #4289 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.202
  • 6 benchmarks are slower, with geometric mean 1.160
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 487μs 169ns 632ns 0 0 0 2.62 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 639μs 955ns 3.57μs 0 0 0 2.62 KB
master WriteAndFlushEnrichedTraces net472 797μs 424ns 1.58μs 0.398 0 0 3.22 KB
#4289 WriteAndFlushEnrichedTraces net6.0 462μs 230ns 892ns 0 0 0 2.62 KB
#4289 WriteAndFlushEnrichedTraces netcoreapp3.1 633μs 187ns 699ns 0 0 0 2.62 KB
#4289 WriteAndFlushEnrichedTraces net472 817μs 340ns 1.27μs 0.408 0 0 3.22 KB
Benchmarks.Trace.AppSecBodyBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4289

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net6.0 1.187 219,779.24 260,878.08
Benchmarks.Trace.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑netcoreapp3.1 1.176 174.33 205.09

Faster 🎉 in #4289

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑net6.0 1.241 162.39 130.87

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 38.9μs 22ns 85.2ns 0.0194 0 0 1.65 KB
master AllCycleSimpleBody netcoreapp3.1 41.2μs 23.3ns 87.1ns 0.0205 0 0 1.63 KB
master AllCycleSimpleBody net472 42.3μs 73ns 283ns 0.249 0 0 1.69 KB
master AllCycleMoreComplexBody net6.0 220μs 235ns 910ns 0.111 0 0 9.22 KB
master AllCycleMoreComplexBody netcoreapp3.1 228μs 142ns 549ns 0.114 0 0 9.12 KB
master AllCycleMoreComplexBody net472 237μs 185ns 717ns 1.42 0 0 9.28 KB
master ObjectExtractorSimpleBody net6.0 162ns 0.077ns 0.298ns 0.00393 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 174ns 0.0553ns 0.207ns 0.00369 0 0 272 B
master ObjectExtractorSimpleBody net472 146ns 0.213ns 0.826ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3.01μs 1.17ns 4.21ns 0.0542 0 0 3.88 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.1μs 2.43ns 8.75ns 0.0511 0 0 3.78 KB
master ObjectExtractorMoreComplexBody net472 4.21μs 2.89ns 11.2ns 0.618 0.00629 0 3.89 KB
#4289 AllCycleSimpleBody net6.0 39.5μs 61.4ns 230ns 0.0197 0 0 1.65 KB
#4289 AllCycleSimpleBody netcoreapp3.1 41.9μs 36.9ns 133ns 0.0208 0 0 1.63 KB
#4289 AllCycleSimpleBody net472 42.4μs 129ns 500ns 0.251 0 0 1.69 KB
#4289 AllCycleMoreComplexBody net6.0 260μs 358ns 1.39μs 0.111 0 0 9.22 KB
#4289 AllCycleMoreComplexBody netcoreapp3.1 236μs 286ns 1.11μs 0.117 0 0 9.12 KB
#4289 AllCycleMoreComplexBody net472 236μs 69.1ns 268ns 1.42 0 0 9.28 KB
#4289 ObjectExtractorSimpleBody net6.0 131ns 0.167ns 0.648ns 0.00393 0 0 280 B
#4289 ObjectExtractorSimpleBody netcoreapp3.1 205ns 0.45ns 1.74ns 0.0037 0 0 272 B
#4289 ObjectExtractorSimpleBody net472 148ns 0.138ns 0.535ns 0.0446 0 0 281 B
#4289 ObjectExtractorMoreComplexBody net6.0 3.08μs 1.72ns 6.45ns 0.0549 0 0 3.88 KB
#4289 ObjectExtractorMoreComplexBody netcoreapp3.1 4.22μs 1.39ns 5.2ns 0.0506 0 0 3.78 KB
#4289 ObjectExtractorMoreComplexBody net472 4.02μs 2.88ns 11.2ns 0.618 0.00606 0 3.89 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 169μs 110ns 425ns 0.254 0 0 18.03 KB
master SendRequest netcoreapp3.1 188μs 116ns 434ns 0.188 0 0 20.09 KB
master SendRequest net472 0.000173ns 0.000118ns 0.000426ns 0 0 0 0 b
#4289 SendRequest net6.0 170μs 98.5ns 381ns 0.17 0 0 18.03 KB
#4289 SendRequest netcoreapp3.1 187μs 241ns 902ns 0.188 0 0 20.09 KB
#4289 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 514μs 1.09μs 4.21μs 0.532 0 0 41.75 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 638μs 988ns 3.83μs 0.316 0 0 41.71 KB
master WriteAndFlushEnrichedTraces net472 812μs 2.28μs 8.82μs 8.12 2.44 0.406 53.24 KB
#4289 WriteAndFlushEnrichedTraces net6.0 524μs 640ns 2.48μs 0.519 0 0 41.92 KB
#4289 WriteAndFlushEnrichedTraces netcoreapp3.1 624μs 1.65μs 6.39μs 0.316 0 0 41.66 KB
#4289 WriteAndFlushEnrichedTraces net472 778μs 2.64μs 9.87μs 8.28 2.64 0.377 53.26 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 836ns 0.164ns 0.59ns 0.0101 0 0 720 B
master ExecuteNonQuery netcoreapp3.1 1.2μs 0.731ns 2.74ns 0.00956 0 0 720 B
master ExecuteNonQuery net472 1.35μs 0.437ns 1.69ns 0.108 0.000676 0 682 B
#4289 ExecuteNonQuery net6.0 919ns 0.729ns 2.82ns 0.0102 0 0 720 B
#4289 ExecuteNonQuery netcoreapp3.1 1.12μs 0.48ns 1.86ns 0.00978 0 0 720 B
#4289 ExecuteNonQuery net472 1.43μs 0.452ns 1.75ns 0.108 0 0 682 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4289

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.198 944.67 1,131.35
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net472 1.141 1,937.58 2,210.87

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 945ns 0.415ns 1.55ns 0.0132 0 0 944 B
master CallElasticsearch netcoreapp3.1 1.19μs 0.64ns 2.48ns 0.013 0 0 944 B
master CallElasticsearch net472 1.94μs 0.588ns 2.28ns 0.151 0 0 955 B
master CallElasticsearchAsync net6.0 1.04μs 0.295ns 1.1ns 0.0125 0 0 920 B
master CallElasticsearchAsync netcoreapp3.1 1.39μs 0.653ns 2.35ns 0.0132 0 0 992 B
master CallElasticsearchAsync net472 2.22μs 0.719ns 2.78ns 0.16 0.00111 0 1.01 KB
#4289 CallElasticsearch net6.0 1.13μs 0.283ns 1.06ns 0.0132 0 0 944 B
#4289 CallElasticsearch netcoreapp3.1 1.28μs 0.718ns 2.59ns 0.0129 0 0 944 B
#4289 CallElasticsearch net472 2.21μs 0.224ns 0.775ns 0.151 0.00107 0 955 B
#4289 CallElasticsearchAsync net6.0 1.08μs 0.446ns 1.73ns 0.0129 0 0 920 B
#4289 CallElasticsearchAsync netcoreapp3.1 1.33μs 0.314ns 1.09ns 0.0133 0 0 992 B
#4289 CallElasticsearchAsync net472 2.14μs 0.222ns 0.862ns 0.16 0.00106 0 1.01 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.12μs 0.368ns 1.38ns 0.0128 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.28μs 0.68ns 2.63ns 0.0123 0 0 912 B
master ExecuteAsync net472 1.55μs 0.285ns 1.07ns 0.139 0.000775 0 875 B
#4289 ExecuteAsync net6.0 1.15μs 0.331ns 1.28ns 0.0125 0 0 912 B
#4289 ExecuteAsync netcoreapp3.1 1.28μs 0.425ns 1.47ns 0.0121 0 0 912 B
#4289 ExecuteAsync net472 1.52μs 0.487ns 1.69ns 0.139 0.000762 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 3.64μs 1.09ns 4.09ns 0.0255 0 0 1.9 KB
master SendAsync netcoreapp3.1 4.38μs 5.96ns 23.1ns 0.0308 0 0 2.43 KB
master SendAsync net472 6.87μs 1.98ns 7.67ns 0.474 0 0 3 KB
#4289 SendAsync net6.0 3.64μs 1.23ns 4.58ns 0.0257 0 0 1.9 KB
#4289 SendAsync netcoreapp3.1 4.35μs 0.969ns 3.63ns 0.0326 0 0 2.43 KB
#4289 SendAsync net472 6.88μs 2.09ns 8.11ns 0.476 0 0 3 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.37μs 0.718ns 2.78ns 0.0228 0 0 1.62 KB
master EnrichedLog netcoreapp3.1 1.92μs 0.808ns 3.03ns 0.0221 0 0 1.62 KB
master EnrichedLog net472 2.28μs 2.14ns 8.29ns 0.244 0 0 1.54 KB
#4289 EnrichedLog net6.0 1.27μs 0.683ns 2.65ns 0.0229 0 0 1.62 KB
#4289 EnrichedLog netcoreapp3.1 1.96μs 0.853ns 3.19ns 0.0225 0 0 1.62 KB
#4289 EnrichedLog net472 2.35μs 2.49ns 9.32ns 0.244 0 0 1.54 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 135ns 505ns 0.056 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 117μs 202ns 754ns 0 0 0 4.21 KB
master EnrichedLog net472 148μs 65.2ns 244ns 0.67 0.223 0 4.38 KB
#4289 EnrichedLog net6.0 111μs 104ns 401ns 0.0549 0 0 4.21 KB
#4289 EnrichedLog netcoreapp3.1 117μs 159ns 615ns 0 0 0 4.21 KB
#4289 EnrichedLog net472 149μs 129ns 498ns 0.67 0.223 0 4.38 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.81μs 0.863ns 3.23ns 0.031 0 0 2.18 KB
master EnrichedLog netcoreapp3.1 3.71μs 1.92ns 7.17ns 0.0297 0 0 2.18 KB
master EnrichedLog net472 4.62μs 1.94ns 7.26ns 0.316 0 0 1.99 KB
#4289 EnrichedLog net6.0 2.81μs 0.925ns 3.46ns 0.0305 0 0 2.18 KB
#4289 EnrichedLog netcoreapp3.1 3.83μs 3.93ns 15.2ns 0.0284 0 0 2.18 KB
#4289 EnrichedLog net472 4.49μs 1.09ns 4.24ns 0.314 0 0 1.99 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.04μs 0.603ns 2.34ns 0.0156 0 0 1.11 KB
master SendReceive netcoreapp3.1 1.45μs 0.521ns 1.95ns 0.0152 0 0 1.11 KB
master SendReceive net472 1.77μs 2.09ns 8.1ns 0.177 0 0 1.12 KB
#4289 SendReceive net6.0 1.13μs 0.507ns 1.9ns 0.0152 0 0 1.11 KB
#4289 SendReceive netcoreapp3.1 1.44μs 0.553ns 2.07ns 0.0151 0 0 1.11 KB
#4289 SendReceive net472 1.81μs 1.71ns 6.16ns 0.176 0 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.54μs 0.596ns 2.31ns 0.0216 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.57μs 1.12ns 4.34ns 0.0197 0 0 1.58 KB
master EnrichedLog net472 4.12μs 1.8ns 6.72ns 0.31 0 0 1.96 KB
#4289 EnrichedLog net6.0 2.61μs 0.889ns 3.33ns 0.0214 0 0 1.53 KB
#4289 EnrichedLog netcoreapp3.1 3.53μs 1.26ns 4.88ns 0.0212 0 0 1.58 KB
#4289 EnrichedLog net472 4.15μs 1.31ns 4.91ns 0.309 0 0 1.96 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4289

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.134 374.07 424.27

Faster 🎉 in #4289

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.165 606.86 520.96

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 374ns 0.168ns 0.629ns 0.00746 0 0 536 B
master StartFinishSpan netcoreapp3.1 607ns 0.186ns 0.669ns 0.007 0 0 536 B
master StartFinishSpan net472 633ns 0.0745ns 0.269ns 0.0854 0 0 538 B
master StartFinishScope net6.0 592ns 0.178ns 0.69ns 0.00929 0 0 656 B
master StartFinishScope netcoreapp3.1 773ns 0.315ns 1.18ns 0.00851 0 0 656 B
master StartFinishScope net472 761ns 0.146ns 0.548ns 0.098 0 0 618 B
#4289 StartFinishSpan net6.0 424ns 0.229ns 0.889ns 0.00745 0 0 536 B
#4289 StartFinishSpan netcoreapp3.1 521ns 0.154ns 0.577ns 0.00729 0 0 536 B
#4289 StartFinishSpan net472 691ns 0.467ns 1.68ns 0.0853 0 0 538 B
#4289 StartFinishScope net6.0 541ns 0.182ns 0.682ns 0.00917 0 0 656 B
#4289 StartFinishScope netcoreapp3.1 765ns 0.329ns 1.23ns 0.00878 0 0 656 B
#4289 StartFinishScope net472 749ns 0.428ns 1.66ns 0.0979 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4289

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 1.128 901.24 1,016.92

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 629ns 0.198ns 0.741ns 0.00907 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 709ns 0.428ns 1.66ns 0.00871 0 0 656 B
master RunOnMethodBegin net472 901ns 0.258ns 1ns 0.098 0 0 618 B
#4289 RunOnMethodBegin net6.0 654ns 0.235ns 0.879ns 0.00916 0 0 656 B
#4289 RunOnMethodBegin netcoreapp3.1 719ns 0.803ns 2.9ns 0.00886 0 0 656 B
#4289 RunOnMethodBegin net472 1.02μs 0.27ns 1.05ns 0.0981 0 0 618 B

@andrewlock
Copy link
Member Author

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4289) (11.086M)   : 0, 11085871
    master (10.913M)   : 0, 10912787
    benchmarks/2.33.0 (10.950M)   : 0, 10950076
    benchmarks/2.9.0 (10.924M)   : 0, 10924440

    section Automatic
    This PR (4289) (7.662M)   : 0, 7661660
    master (7.664M)   : 0, 7663716
    benchmarks/2.33.0 (7.644M)   : 0, 7643676
    benchmarks/2.9.0 (7.859M)   : 0, 7859484

    section Trace stats
    master (7.624M)   : 0, 7623947
    benchmarks/2.33.0 (7.672M)   : 0, 7672295

    section Manual
    This PR (4289) (9.788M)   : 0, 9787808
    master (9.836M)   : 0, 9836187
    benchmarks/2.33.0 (9.850M)   : 0, 9849660

    section Manual + Automatic
    This PR (4289) (7.236M)   : 0, 7235575
    master (7.230M)   : 0, 7229846
    benchmarks/2.33.0 (7.322M)   : 0, 7322232

    section Version Conflict
    master (6.527M)   : 0, 6526980
    benchmarks/2.33.0 (6.640M)   : 0, 6640338
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4289) (9.779M)   : 0, 9778552
    master (9.559M)   : 0, 9559064
    benchmarks/2.33.0 (9.710M)   : 0, 9710226
    benchmarks/2.9.0 (9.537M)   : 0, 9537090

    section Automatic
    This PR (4289) (6.810M)   : 0, 6809893
    master (6.689M)   : 0, 6689083
    benchmarks/2.33.0 (6.622M)   : 0, 6621713

    section Trace stats
    master (6.511M)   : 0, 6510568
    benchmarks/2.33.0 (6.688M)   : 0, 6688294

    section Manual
    This PR (4289) (8.663M)   : 0, 8662586
    master (8.229M)   : 0, 8228525
    benchmarks/2.33.0 (8.494M)   : 0, 8493703

    section Manual + Automatic
    This PR (4289) (6.558M)   : 0, 6557821
    master (6.497M)   : 0, 6497362
    benchmarks/2.33.0 (6.469M)   : 0, 6469076

    section Version Conflict
    master (5.838M)   : 0, 5838231
    benchmarks/2.33.0 (5.707M)   : 0, 5706556
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4289) (10.267M)   : 0, 10266937
    master (10.121M)   : 0, 10121446
    benchmarks/2.33.0 (10.328M)   : 0, 10327902
    benchmarks/2.9.0 (10.718M)   : 0, 10718317

    section Automatic
    This PR (4289) (7.558M)   : 0, 7558053
    master (7.363M)   : 0, 7363115
    benchmarks/2.33.0 (7.597M)   : 0, 7597442
    benchmarks/2.9.0 (7.506M)   : 0, 7506283

    section Trace stats
    master (7.527M)   : 0, 7527477
    benchmarks/2.33.0 (7.363M)   : 0, 7363191

    section Manual
    This PR (4289) (9.542M)   : 0, 9541775
    master (9.205M)   : 0, 9204776
    benchmarks/2.33.0 (9.091M)   : 0, 9091133

    section Manual + Automatic
    This PR (4289) (7.167M)   : 0, 7167323
    master (7.294M)   : 0, 7293919
    benchmarks/2.33.0 (7.098M)   : 0, 7097641

    section Version Conflict
    master (6.490M)   : 0, 6489562
    benchmarks/2.33.0 (6.518M)   : 0, 6518470
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4289) (7.624M)   : 0, 7623800
    master (7.831M)   : 0, 7830898
    benchmarks/2.33.0 (7.693M)   : 0, 7692552
    benchmarks/2.9.0 (8.043M)   : 0, 8043419

    section No attack
    This PR (4289) (2.234M)   : 0, 2233953
    master (2.229M)   : 0, 2228953
    benchmarks/2.33.0 (2.230M)   : 0, 2229957
    benchmarks/2.9.0 (3.342M)   : 0, 3342435

    section Attack
    This PR (4289) (1.920M)   : 0, 1920019
    master (1.891M)   : 0, 1890997
    benchmarks/2.33.0 (1.882M)   : 0, 1882387
    benchmarks/2.9.0 (2.652M)   : 0, 2651797

    section Blocking
    This PR (4289) (3.850M)   : 0, 3849815
    master (3.829M)   : 0, 3829114
    benchmarks/2.33.0 (3.837M)   : 0, 3836643
Loading

@andrewlock andrewlock merged commit c4a6a43 into master Jul 12, 2023
@andrewlock andrewlock deleted the andrew/bump-sdk branch July 12, 2023 06:16
@github-actions github-actions bot added this to the vNext milestone Jul 12, 2023
bouwkast pushed a commit that referenced this pull request Jul 31, 2023
@andrewlock @bouwkast
Bump .NET SDK to 7.0.306 (#4289)
531962f 
* Bump SDK to 7.0.304

* Update download path for gitlab build

* Fix dead link

* Bump SDK to 7.0.306

* Update download path for gitlab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierotibou pierotibou pierotibou approved these changes

@lucaspimentel lucaspimentel lucaspimentel approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
2.34.0
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewlock @lucaspimentel @pierotibou