Skip to content

Commit

Permalink
Address PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
kevingosse committed Oct 23, 2023
1 parent f19406d commit c7a1b7c
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 174 deletions.
2 changes: 1 addition & 1 deletion tracer/src/Datadog.Trace.Tools.Runner/CheckCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ private void Execute(InvocationContext context)

var startInfo = new ProcessStartInfo(ddDotnet, commandLine) { UseShellExecute = false };

startInfo.EnvironmentVariables["DD_OVERRIDE_COMMAND"] = "dd-trace";
startInfo.EnvironmentVariables["DD_INTERNAL_OVERRIDE_COMMAND"] = "dd-trace";

var process = Process.Start(startInfo);
process.WaitForExit();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
<CheckEolTargetFramework>false</CheckEolTargetFramework>
</PropertyGroup>

<ItemGroup>
<Compile Include="..\Datadog.Trace\Util\System.Diagnostics.CodeAnalysis.Attributes.cs" Link="System.Diagnostics.CodeAnalysis.Attributes.cs" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Win32.Registry" Version="5.0.0" />
</ItemGroup>
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public CommandWithExamples(string name, string? description = null)
}

public static string Command =>
Environment.GetEnvironmentVariable("DD_OVERRIDE_COMMAND")
Environment.GetEnvironmentVariable("DD_INTERNAL_OVERRIDE_COMMAND")
?? Path.GetFileNameWithoutExtension(Environment.GetCommandLineArgs()[0]);

public IReadOnlyList<string> Examples => _examples;
Expand Down

0 comments on commit c7a1b7c

Please sign in to comment.