Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-1956 Document all regions in setup instruction #749

Merged
merged 4 commits into from
Feb 9, 2022

Conversation

maxep
Copy link
Member

@maxep maxep commented Feb 8, 2022

What and why?

All current regions (US1, US3, US5, US1_FED, EU1) are documented in the setup instructions.

This PR also fix tracing indentation and RUM setup for eu1.

Review checklist

  • Make sure each commit and the PR mention the Issue number or JIRA reference

@maxep maxep requested review from a team as code owners February 8, 2022 13:44
@maxep maxep self-assigned this Feb 8, 2022
@alai97
Copy link
Contributor

alai97 commented Feb 8, 2022

Created test preview branch in #13052! Check out https://docs-staging.datadoghq.com/alai97/rum-configuration-region-setup-preview/.

Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small copy nits!

docs/trace_collection.md Outdated Show resolved Hide resolved
docs/trace_collection.md Outdated Show resolved Hide resolved
docs/trace_collection.md Outdated Show resolved Hide resolved
docs/trace_collection.md Outdated Show resolved Hide resolved
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
@maxep
Copy link
Member Author

maxep commented Feb 9, 2022

Thanks for the branch @alai97! It looks like it's working great!

Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@maxep maxep merged commit 6d3dbef into master Feb 9, 2022
@maxep maxep deleted the maxep/RUMM-1956/doc-all-regions branch February 9, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants