-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-1744 Update release tool to conditionally validate Kronos.xcframework
#704
Conversation
to simplify assertion of GH asset content
ce488b6
to
0d517e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure if this is the simplest solution but as long as it works it's fine for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@buranmert do you see anything in particular that we could simplify? My goal was to have separate validation for each |
it's just seeing
|
It would need another |
What and why?
📦 This PR updates our release automation so it can conditionally include/exclude certain
XCFrameworks
from GitHub release asset validation (.*zip
). This is required as starting from1.9.0
SDK will no longer depend onKronos.xcframework
(#701), but when (re)building historical tags, we want it to be included.How?
I extracted the code for validating each
XCFramework
and used OCP to make it configurable for a certain range ofVersion
.Review checklist