Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dogfood recent changes #687

Merged
merged 65 commits into from
Dec 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
c497d02
RUMM-1386 Fix `BinaryImage.imageName` name for iOS Simulator and Xcod…
ncreated Nov 18, 2021
7b3aab7
RUMM-1758 Add RUM Session debug utility
ncreated Nov 12, 2021
8be3ed2
Merge pull request #668 from DataDog/ncreated/RUMM-1386-fix-binary-im…
ncreated Nov 19, 2021
310998e
RUMM-1780 PR comments addressed
buranmert Nov 22, 2021
7a9603f
RUMM-1615 Allow launch time earlier than `UIApplicationDidBecomeActiv…
maxep Oct 15, 2021
7fea66d
RUMM-1615 Update `LaunchTimeProviderType ` documentation
maxep Oct 18, 2021
9f146b6
RUMM-1615 Create `RUMCommandPublisher` to publish RUM command to a su…
maxep Oct 22, 2021
55811d2
RUMM-1615 Refacto `RUMAutoInstrumentation` to `RUMInstrumentation`
maxep Oct 29, 2021
ee146ab
RUMM-1615 SwiftUI View Instrumentation
maxep Oct 22, 2021
cbaf621
RUMM-1615 Fix integration test flakiness
maxep Oct 27, 2021
c9d7572
RUMM-1615 Workaround FB8907671 in 14.2 <= iOS < 14.5
maxep Oct 28, 2021
2c84bbe
RUMM-1615 Add `RUMViewModifier` unit tests
maxep Nov 3, 2021
4d2e97c
RUMM-1615 Use native view modifier
maxep Nov 3, 2021
58eaa1f
RUMM-1615 Remove `RUMInstrumentation` compliance to `SwiftUIViewHandler`
maxep Nov 3, 2021
5791552
Revert "RUMM-1615 Add `RUMViewModifier` unit tests"
maxep Nov 3, 2021
bdd6713
RUMM-1615 Update identity property name and documentation
maxep Nov 4, 2021
1c75e6b
RUMM-1745 Use single handler for UIKit and SwiftUI views instrumentation
maxep Nov 2, 2021
0f83834
RUMM-1745 prefix publisher methods with `notify_`
maxep Nov 12, 2021
6ebc2a5
RUMM-1745 Rename RUM instrumentations properties
maxep Nov 12, 2021
724ff1e
RUMM-1745 Keep weak ref to view controller
maxep Nov 12, 2021
a0c6699
RUMM-1745 Fix typo
maxep Nov 16, 2021
e149db5
RUMM-1745 Remove unnecessary stack check
maxep Nov 16, 2021
d127697
RUMM-1745 Test nil identity
maxep Nov 16, 2021
a86632a
RUMM-1745 Keep predicate private to view handler
maxep Nov 17, 2021
006bf44
RUMM-1615 Workaround FB8907671 in 14.2 <= iOS < 15
maxep Nov 17, 2021
3dd94c2
RUMM-1745 Fix SwiftUI scenario navigation bar title
maxep Nov 17, 2021
09299ce
Merge pull request #669 from DataDog/ncreated/RUMM-1758-add-RUM-sessi…
ncreated Nov 22, 2021
aff7a68
Merge pull request #670 from DataDog/buranmert/RUMM-1780-filemanager-…
buranmert Nov 22, 2021
4d80182
Bumped version to 1.8.0
ncreated Nov 23, 2021
c4ddfb8
Update `CHANGELOG.md`
ncreated Nov 23, 2021
3b88005
Merge pull request #671 from DataDog/release/1.8.0
ncreated Nov 23, 2021
bc80661
RUMM-1758 Fix Xcode 12.x compilation issue in 'Example' target
ncreated Nov 24, 2021
785d09b
RUMM-1758 Resolve Xcode 13.1 upgrade warnings
ncreated Nov 24, 2021
b01284d
Merge pull request #657 from DataDog/maxep/RUMM-1745/swiftui-uikit-na…
maxep Nov 24, 2021
b89f1c1
RUMM-1658 Manual instrumentation of SwiftUI actions
maxep Nov 12, 2021
b0ffbea
RUMM-1658 Remove `RUMSwipeActionModifier`
maxep Nov 22, 2021
283237c
RUMM-1658 Fix doc typo
maxep Nov 24, 2021
c5983a4
Merge pull request #672 from DataDog/ncreated/RUMM-1758-fix-Example-a…
ncreated Nov 24, 2021
ccb9354
RUMM-1758 Link SwiftUI (weakly) to the 'Example' target
ncreated Nov 25, 2021
f7c7a3a
Merge pull request #673 from DataDog/ncreated/RUMM-1758-fix-runtime-i…
ncreated Nov 25, 2021
d71e560
Merge pull request #661 from DataDog/maxep/RUMM-1658/swiftui-actions
maxep Nov 29, 2021
ecc3bbb
Update to version 1.0.2 of testing framework
Nov 30, 2021
b280161
Merge pull request #675 from DataDog/nachoBonafonte/update-to-testing…
Dec 1, 2021
6e3da95
🚩RUM-1755 Add config overrides for debug launch arguments
fuzzybinary Dec 2, 2021
eb9c464
Allow passing in a type for errors sent with a message
AvdLee Dec 3, 2021
cf17b18
🧹Cleanup MobileDevice initialization
fuzzybinary Dec 3, 2021
59bb278
Move deinit of MobileDevice to possibly fix tests.
fuzzybinary Dec 3, 2021
8e7c19e
Merge pull request #676 from DataDog/feature/swiftui
maxep Dec 6, 2021
55afb58
Add `nil` default to error with message method for backwards compatib…
AvdLee Dec 6, 2021
2c437f4
Move ProcessInfo out of MobileDevice and into AppContext
fuzzybinary Dec 6, 2021
1b56d0b
Merge pull request #679 from DataDog/jward/RUM-1755-debug-launch-argu…
fuzzybinary Dec 6, 2021
80bdcae
Add custom type support for resource loading
AvdLee Dec 7, 2021
19348a1
Add tests for setting a custom type
AvdLee Dec 7, 2021
2e1ca19
Add missing comma
AvdLee Dec 7, 2021
c3a02ce
Add tests for custom error types
ncreated Dec 8, 2021
65aa429
RUMM-1821 Fix flaky conditions in `RUMResourcesScenarioTests`
ncreated Dec 8, 2021
639c7ec
RUMM-1821 Improve `UITests` observability in CI App by logging `RUMSe…
ncreated Dec 9, 2021
92fd3dc
Update to version 1.0.3-beta.1 of testing framework
Dec 9, 2021
102445f
RUMM-1821 Fix UI tests plan selection on CI
ncreated Dec 9, 2021
8eef37c
RUMM-1821 Exclude mobile vitals and SwiftUI tests from CR test plan
ncreated Dec 9, 2021
2704a4b
RUMM-1821 CR fix - cleanup
ncreated Dec 9, 2021
c62be2d
Merge pull request #682 from DataDog/ncreated/RUMM-1821-fix-flakiness…
ncreated Dec 9, 2021
68711e4
Merge pull request #680 from AvdLee/master
ncreated Dec 9, 2021
fc969b2
Merge pull request #684 from DataDog/ncreated/RUMM-1821-fix-selecting…
ncreated Dec 9, 2021
ad16182
Merge pull request #686 from DataDog/nachoBonafonte/update-to-testing…
Dec 10, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,4 @@ instrumented-tests/LICENSE
venv
*.pyc
__pycache__
*.swp
46 changes: 44 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,35 @@
# 1.8.0 / 11-23-2021

### Changes

* [BUGFIX] Fix rare crash in `CarrierInfoProvider`. See [#627][] [#623][], [#619][] (Thanks [@safa-ads][], [@matcartmill][])
* [BUGFIX] Crash Reporting: Fix issue with some truncated stack traces not being displayed. See [#641][]
* [BUGFIX] Fix reading SDK attributes in Objective-C. See [#654][]
* [FEATURE] RUM: Track slow UI renders with RUM Long Tasks. See [#567][]
* [FEATURE] RUM: Add API to notify RUM session start: `.onRUMSessionStart(_: (String, Bool) -> Void)`. See [#590][]
* [FEATURE] Logs: Add logs scrubbing API: `.setLogEventMapper(_: (LogEvent) -> LogEvent)`. See [#640][]
* [FEATURE] Add `Datadog.isInitialized` API. See [#566][]
* [FEATURE] Add API for clearing out all SDK data: `Datadog.clearAllData()`. See [#644][]
* [FEATURE] Add support for `us5` site. See [#576][]
* [FEATURE] Support `URLSession` proxy configuration with `.connectionProxyDictionary`. See [#582][]
* [IMPROVEMENT] Compress HTTP body in SDK uploads. See [#626][]
* [IMPROVEMENT] Change type of `.xhr` RUM Resources to `.native`. See [#605][]
* [IMPROVEMENT] Link logs and traces to RUM Actions. See [#615][]
* [IMPROVEMENT] Crash Reporting: Fix symbolication issue for iOS Simulator crashes. See [#563][]
* [IMPROVEMENT] Fix various typos in docs. See [#569][] (Thanks [@michalsrutek][])
* [IMPROVEMENT] Use Intake API V2 for SDK data uploads. See [#562][]

# 1.7.2 / 11-8-2021

### Changes

* [BUGFIX] Fix iOS 15 crash related to `ProcessInfo.isLowPowerModeEnabled`. See [#609][] #655 (Thanks [@pingd][])
* [BUGFIX] Fix iOS 15 crash related to `ProcessInfo.isLowPowerModeEnabled`. See [#609][] [#655][] (Thanks [@pingd][])

# 1.7.1 / 10-4-2021

### Changes

* [BUGFIX] Fix iOS 15 crash in `MobileDevice.swift`. See [#609][] #613 (Thanks [@arnauddorgans][], [@earltedly][])
* [BUGFIX] Fix iOS 15 crash in `MobileDevice.swift`. See [#609][] [#613][] (Thanks [@arnauddorgans][], [@earltedly][])
* [BUGFIX] RUM: Fix bug with "Refresh Rate" Mobile Vital reporting very low values. [#608][]

# 1.7.0 / 09-27-2021
Expand Down Expand Up @@ -245,11 +266,29 @@
[#539]: https://github.com/DataDog/dd-sdk-ios/issues/539
[#545]: https://github.com/DataDog/dd-sdk-ios/issues/545
[#547]: https://github.com/DataDog/dd-sdk-ios/issues/547
[#562]: https://github.com/DataDog/dd-sdk-ios/issues/562
[#563]: https://github.com/DataDog/dd-sdk-ios/issues/563
[#566]: https://github.com/DataDog/dd-sdk-ios/issues/566
[#567]: https://github.com/DataDog/dd-sdk-ios/issues/567
[#569]: https://github.com/DataDog/dd-sdk-ios/issues/569
[#575]: https://github.com/DataDog/dd-sdk-ios/issues/575
[#576]: https://github.com/DataDog/dd-sdk-ios/issues/576
[#582]: https://github.com/DataDog/dd-sdk-ios/issues/582
[#583]: https://github.com/DataDog/dd-sdk-ios/issues/583
[#590]: https://github.com/DataDog/dd-sdk-ios/issues/590
[#605]: https://github.com/DataDog/dd-sdk-ios/issues/605
[#608]: https://github.com/DataDog/dd-sdk-ios/issues/608
[#609]: https://github.com/DataDog/dd-sdk-ios/issues/609
[#613]: https://github.com/DataDog/dd-sdk-ios/issues/613
[#615]: https://github.com/DataDog/dd-sdk-ios/issues/615
[#619]: https://github.com/DataDog/dd-sdk-ios/issues/619
[#623]: https://github.com/DataDog/dd-sdk-ios/issues/623
[#626]: https://github.com/DataDog/dd-sdk-ios/issues/626
[#627]: https://github.com/DataDog/dd-sdk-ios/issues/627
[#640]: https://github.com/DataDog/dd-sdk-ios/issues/640
[#641]: https://github.com/DataDog/dd-sdk-ios/issues/641
[#644]: https://github.com/DataDog/dd-sdk-ios/issues/644
[#654]: https://github.com/DataDog/dd-sdk-ios/issues/654
[#655]: https://github.com/DataDog/dd-sdk-ios/issues/655
[@00FA9A]: https://github.com/00FA9A
[@Britton-Earnin]: https://github.com/Britton-Earnin
Expand All @@ -268,7 +307,10 @@
[@lgaches]: https://github.com/lgaches
[@lmramirez]: https://github.com/lmramirez
[@marcusway]: https://github.com/marcusway
[@matcartmill]: https://github.com/matcartmill
[@michalsrutek]: https://github.com/michalsrutek
[@philtre]: https://github.com/philtre
[@pingd]: https://github.com/pingd
[@provTheodoreNewell]: https://github.com/provTheodoreNewell
[@safa-ads]: https://github.com/safa-ads
[@sdejesusF]: https://github.com/sdejesusF
210 changes: 153 additions & 57 deletions Datadog/Datadog.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1250"
LastUpgradeVersion = "1310"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1250"
LastUpgradeVersion = "1310"
version = "1.7">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1250"
LastUpgradeVersion = "1310"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1250"
LastUpgradeVersion = "1310"
version = "1.7">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1250"
LastUpgradeVersion = "1310"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1250"
LastUpgradeVersion = "1310"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1250"
LastUpgradeVersion = "1310"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1250"
LastUpgradeVersion = "1310"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1250"
LastUpgradeVersion = "1310"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down Expand Up @@ -50,12 +50,27 @@
ReferencedContainer = "container:Datadog.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
<CommandLineArguments>
<CommandLineArgument
argument = "DD_DEBUG"
isEnabled = "NO">
</CommandLineArgument>
<CommandLineArgument
argument = "DD_DEBUG_RUM"
isEnabled = "NO">
</CommandLineArgument>
</CommandLineArguments>
<EnvironmentVariables>
<EnvironmentVariable
key = "DD_TEST_SCENARIO_CLASS_NAME"
value = "LoggingManualInstrumentationScenario"
isEnabled = "NO">
</EnvironmentVariable>
<EnvironmentVariable
key = "DD_TEST_SCENARIO_CLASS_NAME"
value = "RUMSwiftUIInstrumentationScenario"
isEnabled = "NO">
</EnvironmentVariable>
<EnvironmentVariable
key = "DD_TEST_SCENARIO_CLASS_NAME"
value = "RUMMobileVitalsScenario"
Expand Down
54 changes: 51 additions & 3 deletions Datadog/Example/Base.lproj/Main.storyboard
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
<color key="backgroundColor" systemColor="systemBackgroundColor"/>
<view key="tableFooterView" contentMode="scaleToFill" id="wle-IX-rUl">
<rect key="frame" x="0.0" y="284.5" width="414" height="0.0"/>
<rect key="frame" x="0.0" y="328" width="414" height="0.0"/>
<autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
<color key="backgroundColor" systemColor="systemBackgroundColor"/>
</view>
Expand Down Expand Up @@ -85,9 +85,29 @@
<segue destination="CBf-fg-exz" kind="show" id="5Im-MK-mpd"/>
</connections>
</tableViewCell>
<tableViewCell clipsSubviews="YES" contentMode="scaleToFill" preservesSuperviewLayoutMargins="YES" selectionStyle="default" indentationWidth="10" textLabel="rh1-Lx-HwO" style="IBUITableViewCellStyleDefault" id="cuG-eI-g1N">
<tableViewCell clipsSubviews="YES" contentMode="scaleToFill" preservesSuperviewLayoutMargins="YES" selectionStyle="default" indentationWidth="10" textLabel="x5x-Et-kvY" style="IBUITableViewCellStyleDefault" id="FqS-dJ-mor">
<rect key="frame" x="0.0" y="175" width="414" height="43.5"/>
<autoresizingMask key="autoresizingMask"/>
<tableViewCellContentView key="contentView" opaque="NO" clipsSubviews="YES" multipleTouchEnabled="YES" contentMode="center" preservesSuperviewLayoutMargins="YES" insetsLayoutMarginsFromSafeArea="NO" tableViewCell="FqS-dJ-mor" id="GvD-oe-TaI">
<rect key="frame" x="0.0" y="0.0" width="414" height="43.5"/>
<autoresizingMask key="autoresizingMask"/>
<subviews>
<label opaque="NO" multipleTouchEnabled="YES" contentMode="left" insetsLayoutMarginsFromSafeArea="NO" text="RUM Session" textAlignment="natural" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" adjustsFontSizeToFit="NO" id="x5x-Et-kvY">
<rect key="frame" x="20" y="0.0" width="374" height="43.5"/>
<autoresizingMask key="autoresizingMask"/>
<fontDescription key="fontDescription" style="UICTFontTextStyleSubhead"/>
<nil key="textColor"/>
<nil key="highlightedColor"/>
</label>
</subviews>
</tableViewCellContentView>
<connections>
<segue destination="PmE-vw-JRi" kind="show" id="hDE-Gx-X61"/>
</connections>
</tableViewCell>
<tableViewCell clipsSubviews="YES" contentMode="scaleToFill" preservesSuperviewLayoutMargins="YES" selectionStyle="default" indentationWidth="10" textLabel="rh1-Lx-HwO" style="IBUITableViewCellStyleDefault" id="cuG-eI-g1N">
<rect key="frame" x="0.0" y="218.5" width="414" height="43.5"/>
<autoresizingMask key="autoresizingMask"/>
<tableViewCellContentView key="contentView" opaque="NO" clipsSubviews="YES" multipleTouchEnabled="YES" contentMode="center" preservesSuperviewLayoutMargins="YES" insetsLayoutMarginsFromSafeArea="NO" tableViewCell="cuG-eI-g1N" id="GVN-Oe-gtW">
<rect key="frame" x="0.0" y="0.0" width="414" height="43.5"/>
<autoresizingMask key="autoresizingMask"/>
Expand All @@ -106,7 +126,7 @@
</connections>
</tableViewCell>
<tableViewCell clipsSubviews="YES" contentMode="scaleToFill" preservesSuperviewLayoutMargins="YES" selectionStyle="default" indentationWidth="10" textLabel="gdR-qL-Lyw" style="IBUITableViewCellStyleDefault" id="w16-YT-5Xj">
<rect key="frame" x="0.0" y="218.5" width="414" height="43.5"/>
<rect key="frame" x="0.0" y="262" width="414" height="43.5"/>
<autoresizingMask key="autoresizingMask"/>
<tableViewCellContentView key="contentView" opaque="NO" clipsSubviews="YES" multipleTouchEnabled="YES" contentMode="center" preservesSuperviewLayoutMargins="YES" insetsLayoutMarginsFromSafeArea="NO" tableViewCell="w16-YT-5Xj" id="NKU-A4-XkK">
<rect key="frame" x="0.0" y="0.0" width="414" height="43.5"/>
Expand Down Expand Up @@ -1374,6 +1394,34 @@
</objects>
<point key="canvasLocation" x="-239" y="1175"/>
</scene>
<!--DebugRUM Session View Controller-->
<scene sceneID="Jsp-EZ-IMP">
<objects>
<viewController id="PmE-vw-JRi" customClass="DebugRUMSessionViewController" customModule="Example" customModuleProvider="target" sceneMemberID="viewController">
<view key="view" contentMode="scaleToFill" id="e1b-CD-UPJ">
<rect key="frame" x="0.0" y="0.0" width="414" height="896"/>
<autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
<subviews>
<label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="This screen requires iO13+" textAlignment="natural" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="msA-Jf-jga">
<rect key="frame" x="105.5" y="437.5" width="203" height="21"/>
<fontDescription key="fontDescription" type="system" pointSize="17"/>
<nil key="textColor"/>
<nil key="highlightedColor"/>
</label>
</subviews>
<viewLayoutGuide key="safeArea" id="eD4-Fl-X14"/>
<color key="backgroundColor" systemColor="systemBackgroundColor"/>
<constraints>
<constraint firstItem="msA-Jf-jga" firstAttribute="centerY" secondItem="e1b-CD-UPJ" secondAttribute="centerY" id="W1y-uX-xiR"/>
<constraint firstItem="msA-Jf-jga" firstAttribute="centerX" secondItem="e1b-CD-UPJ" secondAttribute="centerX" id="vqm-ID-sMc"/>
</constraints>
</view>
<navigationItem key="navigationItem" id="GRY-pt-311"/>
</viewController>
<placeholder placeholderIdentifier="IBFirstResponder" id="56a-IG-m2B" userLabel="First Responder" customClass="UIResponder" sceneMemberID="firstResponder"/>
</objects>
<point key="canvasLocation" x="678" y="1175"/>
</scene>
<!--Debug Webview View Controller-->
<scene sceneID="na3-2j-vu9">
<objects>
Expand Down
Loading