RUMM-1770 test_repetition_mode is added for Xcode 13 stack #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buranmert
force-pushed
the
buranmert/RUMM-1770-update-bitrise-stack
branch
from
3746b9f to
3c129dd
Compare
ncreated
reviewed
Nov 16, 2021
| @@ -91,6 +91,11 @@ def __rendered_template(self): | |||
|
|
|||
| template = template.replace('## <MACOS VERSION> ##', self.host_os_version) | |||
|
|
|||
| if self.host_os_version.startswith('11'): # macOS 11.X Big Sur | |||
| template = template.replace('## <RETRY_ON_FAIL> ##', "test_repetition_mode: 'retry_on_failure'") | |||
There was a problem hiding this comment.
Don't we need to specify maximum_test_repetitions as well? Or does it have a default value?
There was a problem hiding this comment.
yes, default value is 3, reasonable i guess.?
i didn't want to replace multiple lines in yaml in order not to deal with indentation issues.
There was a problem hiding this comment.
Totally 👍 for keeping it simple like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Bitrise's
xcode-teststep deprecatesshould_retry_test_on_failinput in favor oftest_repetition_mode: 'retry_on_failureHow?
Our main
bitrise.ymluses the new input parameter.nightly-unit-teststool sets the input parameter accordingly.TODO
Review checklist