RUMM-1615 Refacto RUMAutoInstrumentation to RUMInstrumentation
#652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxep
commented
Oct 29, 2021
Comment on lines
+21
to
+22
| private weak var notificationCenter: NotificationCenter? | ||
|
|
There was a problem hiding this comment.
Addition: Keep a notification center weak ref to remove observers on deinit. Even if we only have a single handler and a single sdk instance, it's an assumption we can't make at this level.
maxep
commented
Oct 29, 2021
| @@ -6,17 +6,17 @@ | |||
|
|
|||
| import UIKit | |||
|
|
|||
| internal protocol UIKitRUMUserActionsHandlerType: RUMCommandPublisher { | |||
| internal protocol UIEventHandler: RUMCommandPublisher { | |||
There was a problem hiding this comment.
Just for clarity on what we handle here.
Same with UIKitRUMViewsHandlerType -> UIViewControllerHandler
maxep
commented
Oct 29, 2021
Comment on lines
+408
to
+411
|
|
||
| XCTAssertNotNil(longTaskConfigured.rum!.instrumentation!.longTaskThreshold) | ||
| XCTAssertNil(longTaskConfigured.rum!.instrumentation!.uiKitRUMViewsPredicate) | ||
| XCTAssertNil(longTaskConfigured.rum!.instrumentation!.uiKitRUMUserActionsPredicate) |
There was a problem hiding this comment.
Adding test for the long task auto-instrumentation and remove XCTAssertNil on the config instance itself.
ncreated
approved these changes
Nov 2, 2021
maxep
force-pushed
the
maxep/RUMM-1615/intrumentation-refacto
branch
from
b3e1017 to
7b103d6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Refacto
RUMAutoInstrumentationtoRUMInstrumentationto prepare support for manual-instrumentation of SwiftUI alongside auto-instrumentation of UIKit.The
SwiftUIinstrumentation will introduce a new view handler for tracking SwiftUI views navigation. this new handler will be instantiated and managed by theRUMInstrumentationthat centralised all handlers.How?
The
RUMInstrumentationwill now be instantiated when RUM is enabled regardless of the auto-instrumentation setup (with UIKit predicates or long task threshold). Its underlying auto-instrumentations can be activated independently to work alongside SwiftUI.Review checklist