Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REPLAY-1460 Enhance UIStepper element masking #1218

Merged
merged 1 commit into from
Mar 23, 2023
Merged

REPLAY-1460 Enhance UIStepper element masking #1218

merged 1 commit into from
Mar 23, 2023

Conversation

ncreated
Copy link
Member

What and why?

📦 This PR enhances masking behaviour for UIStepper elements when .maskAll policy is set. Now, the MIN and MAX values cannot be inferred as we no longer grey-out their buttons:

How?

Easy 😎.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@ncreated
REPLAY-1460 Enhance UIStepper element masking
dfbcee6 
so that min and max values cannot be seen if `.maskAll` strategy is set.
@ncreated ncreated requested a review from a team as a code owner March 21, 2023 16:48
@ncreated ncreated self-assigned this Mar 21, 2023
fuzzybinary
fuzzybinary approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@fuzzybinary fuzzybinary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it when a plan comes together.

@0xnm
Copy link
Member

0xnm commented Mar 22, 2023

I love it when a plan comes together.

The A-Team reference detected!

maciejburda
maciejburda approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@maciejburda maciejburda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️

Thanks for tackling this! I really love how you decided to solve it.
I was initially thinking to show a grey square, but it makes a lot of sense to do it like this.

@ncreated ncreated merged commit a06a4ab into develop Mar 23, 2023
@ncreated ncreated deleted the ncreated/REPLAY-1460-improve-stepper-masking branch March 23, 2023 11:32
@ncreated ncreated mentioned this pull request Mar 31, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejburda maciejburda maciejburda approved these changes

@maxep maxep maxep approved these changes

@fuzzybinary fuzzybinary fuzzybinary approved these changes

Assignees

@ncreated ncreated

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ncreated @0xnm @fuzzybinary @maxep @maciejburda