-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REPLAY-1448 Add support for UIStepper #1194
Conversation
40eb7fc
to
8bdba29
Compare
One thing to note. Pixel perfection is not there - due to center calculation it's sometimes slightly offset. I tried mitigating with using text shape, but the results weren't as nice for font related reasons. The other solution is to use + and - images that are embedded within the control, but this means sending all the image data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🚀 - I left 2 feedbacks to consider.
One thing to note. Pixel perfection is not there - due to center calculation it's sometimes slightly offset. I tried mitigating with using text shape, but the results weren't as nice for font related reasons. The other solution is to use + and - images that are embedded within the control, but this means sending all the image data.
We seek for an "approximated" look that will fulfil product requirements and what we did here is more than enough 👍. Only difference between what we do now vs we had considered is 5 vs 3-4 wireframes. This is IMO negligible (even when scrolling, sending updates to 5 wireframes is not much worse than updating 3 of them). Well done 💪.
...ces/Recorder/ViewTreeSnapshotProducer/ViewTreeSnapshot/NodeRecorders/UIStepperRecorder.swift
Outdated
Show resolved
Hide resolved
...ces/Recorder/ViewTreeSnapshotProducer/ViewTreeSnapshot/NodeRecorders/UIStepperRecorder.swift
Outdated
Show resolved
Hide resolved
PR fixes
What and why?
📦 This PR enhances the recording of
UIStepper
elements in session replay. Its preliminary support was introduced earlier, but here we solve remaining glitches and send frames instead of images for button + and - button icons.How?
By adding new recorder for
UIStepper
element that checks it's frame and creates matching wireframes.Review checklist
Custom CI job configuration (optional)