Add ability to adjust configuration telemetry sampling rate. #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created an internal configuration attribute to allow the cross platform framework SDKs to adjust the configuration telemetry sample rate for testing purposes.
This more closely matches what Flutter sends in for other sampling rates.
maciejburda
approved these changes
Mar 2, 2023
ncreated
approved these changes
Mar 2, 2023
maxep
approved these changes
Mar 2, 2023
Datadog ReportBranch report: ✅ |
|
@fuzzybinary I hope you don't mind me merging this. I'd like to unblock the release CI :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
We need to be able to test that our modifications telemetry work as expected in integration tests, so we need a way to ensure we'll send the configuration telemetry event.
How?
Instead of opening up a property, I've added an internal configuration attribute to allow the cross platform framework SDKs to adjust the configuration telemetry sample rate. The cross platform SDKs will set this so we can be assured we'll get the configuration telemetry event.
Review checklist
Custom CI job configuration (optional)