Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align swift-tools-version across all packages #1134

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

ncreated
Copy link
Member

What and why?

📦 Fixing the problem revealed in recent nightly tests failure:

xcodebuild: error: Could not resolve package dependencies:
  package 'testutilities' is using Swift tools version 5.7.0 but the installed version is 5.6.0

How?

Following this post from Apple:

Starting April 25, 2022, iOS, iPadOS, and watchOS apps submitted to the App Store must be built with Xcode 13 (...)

it makes sense to align all our packages with:

// swift-tools-version: 5.5

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

- to reflect the lowest supported Xcode version (13.0)
@ncreated ncreated requested a review from a team as a code owner January 18, 2023 08:34
@ncreated ncreated self-assigned this Jan 18, 2023
Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 18, 2023

Datadog Report

Branch report: ncreated/fix-nightly-builds
Commit report: adfe2fb

dd-sdk-ios: 0 Failed, 0 New Flaky, 116 Passed, 0 Skipped, 4m 30.78s Wall Time

@ncreated ncreated merged commit 371ab9b into develop Jan 18, 2023
@ncreated ncreated deleted the ncreated/fix-nightly-builds branch January 18, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants