Downgrade to version 2.1.3 of testing framework #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we revert other changes? |
Datadog ReportBranch report: ✅ |
maxep
changed the title
maxep
changed the title
maciejburda
approved these changes
Dec 14, 2022
ncreated
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Nice 👍
Could we also re-enable tvOS instrumentation in this PR? Turned out that disabling it just for tvOS was a miss:
-// Temporarily disabled - causes "Touching Example\ tvOS.app" exit code: 65 on CI
-// OTHER_LDFLAGS[sdk=appletvsimulator*]=$$(inherited) -framework DatadogSDKTesting\n
+OTHER_LDFLAGS[sdk=appletvsimulator*]=$$(inherited) -framework DatadogSDKTesting\n
nachoBonafonte
approved these changes
Dec 14, 2022
This reverts commit ead0f4b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
DatadogSDKTesting2.2.0-rc.4 makes the unit tests pipeline to hang when launching the app runner.CI passes when using 2.1.3, so lets downgrade on
developand investigate further the issue.Review checklist
Custom CI job configuration (optional)