-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-409 Update tracing with service
, env
and version
#107
Conversation
…-env-and-version RUMM-409 Unify `service`, `env` and `version` across all SDKs
# Conflicts: # Datadog/Datadog.xcodeproj/project.pbxproj # Shopist/Shopist/AppDelegate.swift # Sources/Datadog/Core/Upload/HTTPHeaders.swift # Sources/Datadog/Datadog.swift # Sources/Datadog/DatadogConfiguration.swift # Sources/Datadog/Logs/LoggingFeature.swift # Tests/DatadogIntegrationTests/Benchmark/BenchmarkTests.swift # Tests/DatadogIntegrationTests/LoggingIntegrationTests.swift # Tests/DatadogTests/Datadog/Core/Upload/DataUploaderTests.swift # Tests/DatadogTests/Datadog/Core/Upload/HTTPHeadersTests.swift # Tests/DatadogTests/Datadog/DatadogTests.swift # Tests/DatadogTests/Datadog/Mocks/DatadogMocks.swift # Tests/DatadogTests/Datadog/Mocks/DatadogObjcMocks.swift # Tests/DatadogTests/Datadog/Mocks/LoggingFeatureMocks.swift
service
, env
and version
from #102service
, env
and version
Is this order correct? Is that how we could get rid of |
Yes 👍.
No.
It only takes the configuration from the user: It doesn't retain
|
What and why?
🚚 In #102,
service
,env
andversion
attributes were unified forLog
. In this PR, I mergemaster
totracing
by also applying the same things toSpan
.How?
There are three groups of commits in this PR:
3cc0bda
-ca3cc71
- they updatetracing
withmaster
, no CR required.service
,env
andversion
rules.As discussed in #100, the default values resolution was moved from
DDTracer.ResolvedConfiguration
(deleted) toDDTracer
itself. This was possible, as now we can make assertions onSpanBuilder
:Review checklist