Skip to content

Commit

Permalink
RUMM-1492 isSystemImage is fixed
Browse files Browse the repository at this point in the history
Detecting /Bundle/Application/ is still enough for iOS device.
In simulator, user images can be found in DerivedData folder as well.
DerivedData folder is customizable, so we can't hardcode its value in detection logic.
  • Loading branch information
buranmert committed Aug 12, 2021
1 parent fde22a8 commit 6aa4a2f
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,8 @@ extension BinaryImageInfo {
self.uuid = imageUUID
self.imageName = URL(string: imagePath)?.lastPathComponent
// NOTE: RUMM-1492 refer to JIRA ticket or `CrashReportTests.swift` to see imagePath examples
self.isSystemImage = !imagePath.contains("/Bundle/Application/") || imagePath.contains("/Contents/Developer/Platforms/")
let isUserImage = imagePath.contains("/Bundle/Application/") || imagePath.contains("/Products/")
self.isSystemImage = !isUserImage

if let codeType = imageInfo.codeType {
self.codeType = CodeType(from: codeType)
Expand Down

0 comments on commit 6aa4a2f

Please sign in to comment.