Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gradle lazy API more #996

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Jul 22, 2022

What does this PR do?

Inspired by the similar PR in the mobile app repository, which in turn was inspired by http://melix.github.io/blog/2022/05/gradle-laziness.html.

Replaces some tasks creation APIs with the lazy variant.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner July 22, 2022 08:28
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2022

Codecov Report

Merging #996 (5084d1e) into feature/sdkv2 (17cb5c7) will increase coverage by 0.05%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           feature/sdkv2     #996      +/-   ##
=================================================
+ Coverage          82.90%   82.95%   +0.05%     
=================================================
  Files                296      296              
  Lines               9841     9841              
  Branches            1603     1603              
=================================================
+ Hits                8158     8163       +5     
+ Misses              1195     1193       -2     
+ Partials             488      485       -3     
Impacted Files Coverage Δ
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 86.70% <0.00%> (-0.53%) ⬇️
...rc/main/java/com/datadog/opentracing/DDTracer.java 55.65% <0.00%> (-0.42%) ⬇️
...android/v2/core/internal/DatadogContextProvider.kt 81.03% <0.00%> (ø)
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 91.18% <0.00%> (+5.88%) ⬆️
...android/log/internal/logger/TelemetryLogHandler.kt 100.00% <0.00%> (+25.00%) ⬆️

@0xnm 0xnm merged commit acb4a35 into feature/sdkv2 Jul 25, 2022
@0xnm 0xnm deleted the nogorodnikov/use-more-gradle-lazy-api branch July 25, 2022 07:04
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants