-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-2322: Report back interaction as back type, prevent reporting empty target name #980
RUMM-2322: Report back interaction as back type, prevent reporting empty target name #980
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #980 +/- ##
===========================================
- Coverage 83.08% 83.06% -0.02%
===========================================
Files 268 268
Lines 9213 9216 +3
Branches 1484 1485 +1
===========================================
+ Hits 7654 7655 +1
- Misses 1151 1153 +2
Partials 408 408
|
@@ -130,7 +130,7 @@ internal class WindowCallbackWrapper( | |||
} else { | |||
customTargetName | |||
} | |||
GlobalRum.get().addUserAction(RumActionType.CUSTOM, targetName, emptyMap()) | |||
GlobalRum.get().addUserAction(RumActionType.TAP, targetName, emptyMap()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This interaction is handleBackEvent
, and there's a BACK type for actions, maybe we should use that instead as it more precise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! I didn't know back
type exists in the RUM schema. I've updated my PR.
350f96f
to
1bf0723
Compare
What does this PR do?
This change does the following:
back
interaction are reported asBACK
now insteadCUSTOM
.onUp
is not called, because screen is closed while finger is still touching the screen. To avoid that we will reporttargetId
andtargetName
for thestartUserAction
as well, so that once it completes due to timeout, it has the necessary data.Fixes #964.
Review checklist (to be filled by reviewers)