Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-2322: Report back interaction as back type, prevent reporting empty target name #980

Merged

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Jul 12, 2022

What does this PR do?

This change does the following:

  • back interaction are reported as BACK now instead CUSTOM.
  • Prevents sending empty target name. It seems it happens because we may start scroll/swipe action with empty target name and without attributes, but onUp is not called, because screen is closed while finger is still touching the screen. To avoid that we will report targetId and targetName for the startUserAction as well, so that once it completes due to timeout, it has the necessary data.

Fixes #964.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner July 12, 2022 09:57
@xgouchet xgouchet added the size-small This PR is small sized label Jul 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #980 (350f96f) into develop (5fb1fdf) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #980      +/-   ##
===========================================
- Coverage    83.08%   83.06%   -0.02%     
===========================================
  Files          268      268              
  Lines         9213     9216       +3     
  Branches      1484     1485       +1     
===========================================
+ Hits          7654     7655       +1     
- Misses        1151     1153       +2     
  Partials       408      408              
Impacted Files Coverage Δ
...ernal/instrumentation/gestures/GesturesListener.kt 93.08% <100.00%> (+0.16%) ⬆️
.../instrumentation/gestures/WindowCallbackWrapper.kt 92.31% <100.00%> (ø)
...ndroid/core/internal/persistence/file/EventMeta.kt 80.00% <0.00%> (-10.00%) ⬇️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 87.50% <0.00%> (-0.54%) ⬇️
...rc/main/java/com/datadog/opentracing/DDTracer.java 55.65% <0.00%> (-0.42%) ⬇️
...droid/rum/tracking/FragmentViewTrackingStrategy.kt 86.96% <0.00%> (+4.35%) ⬆️

@@ -130,7 +130,7 @@ internal class WindowCallbackWrapper(
} else {
customTargetName
}
GlobalRum.get().addUserAction(RumActionType.CUSTOM, targetName, emptyMap())
GlobalRum.get().addUserAction(RumActionType.TAP, targetName, emptyMap())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This interaction is handleBackEvent, and there's a BACK type for actions, maybe we should use that instead as it more precise

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I didn't know back type exists in the RUM schema. I've updated my PR.

@0xnm 0xnm force-pushed the nogorodnikov/rumm-2322/improve-interaction-tracking-reporting branch from 350f96f to 1bf0723 Compare July 13, 2022 07:21
@0xnm 0xnm requested a review from xgouchet July 13, 2022 07:22
@0xnm 0xnm changed the title RUMM-2322: Report back interaction as tap, prevent reporting empty target name RUMM-2322: Report back interaction as back type, prevent reporting empty target name Jul 13, 2022
@0xnm 0xnm merged commit 009bd1a into develop Jul 15, 2022
@0xnm 0xnm deleted the nogorodnikov/rumm-2322/improve-interaction-tracking-reporting branch July 15, 2022 06:54
@xgouchet xgouchet added this to the 1.14.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-small This PR is small sized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seeing unexpected custom actions "back" and "" reported in the DataDog console
4 participants