Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-2329: Remove deprecated APIs #973

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Jul 5, 2022

What does this PR do?

This change removes public APIs which were deprecated in the previous SDK version and now can be safely removed.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner July 5, 2022 09:19
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2022

Codecov Report

Merging #973 (f1890e1) into develop (67dac2c) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #973      +/-   ##
===========================================
- Coverage    83.18%   83.02%   -0.16%     
===========================================
  Files          268      268              
  Lines         9264     9212      -52     
  Branches      1491     1485       -6     
===========================================
- Hits          7706     7648      -58     
- Misses        1148     1154       +6     
  Partials       410      410              
Impacted Files Coverage Δ
...main/kotlin/com/datadog/android/DatadogEndpoint.kt 0.00% <ø> (ø)
...atadog/android/core/configuration/Configuration.kt 98.68% <ø> (-0.19%) ⬇️
.../main/kotlin/com/datadog/android/rum/RumMonitor.kt 78.26% <ø> (+3.26%) ⬆️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 95.09% <ø> (-0.06%) ⬇️
...ndroid/core/internal/persistence/file/EventMeta.kt 70.00% <0.00%> (-20.00%) ⬇️
.../datadog/android/rum/webview/RumWebChromeClient.kt 78.26% <0.00%> (-3.22%) ⬇️
...com/datadog/android/compose/InteractionTracking.kt 73.55% <0.00%> (-2.31%) ⬇️
...tadog/android/tv/LeanbackViewAttributesProvider.kt 84.21% <0.00%> (-2.00%) ⬇️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 86.96% <0.00%> (-1.63%) ⬇️
.../android/rum/internal/tracking/ViewLoadingTimer.kt 93.33% <0.00%> (-0.22%) ⬇️
... and 11 more

@xgouchet xgouchet added the size-medium This PR is medium sized label Jul 5, 2022
@0xnm 0xnm merged commit ff8bf96 into develop Jul 5, 2022
@0xnm 0xnm deleted the nogorodnikov/rumm-2329/remove-deprecated-apis branch July 5, 2022 14:18
@xgouchet xgouchet added this to the 1.14.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-medium This PR is medium sized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants