Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-2095: Support new AGP publishing model #916

Merged

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Apr 28, 2022

What does this PR do?

This change brings support of the new publishing model by explicitly specifying components for publishing (release in our case).

This new model landed originally in AGP 7.1 and automatic components creation for publishing will be disabled in AGP 8.0.

Docs for the new approach can be found here.

Since new model can also attach sources and javadoc (by Dokka) artifacts to the published component, explicit tasks for the sources and docs are removed.

Change is verified by publishing to the local Maven, everything is fine and file set is complete (aar + sources + javadoc + pom + module) and has an expected content.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner April 28, 2022 09:20
@0xnm 0xnm force-pushed the nogorodnikov/rumm-2095/support-new-agp-publishing-model branch from 54fd7eb to d7ea8d1 Compare April 28, 2022 09:24
@0xnm 0xnm merged commit b86ff41 into develop Apr 29, 2022
@0xnm 0xnm deleted the nogorodnikov/rumm-2095/support-new-agp-publishing-model branch April 29, 2022 12:55
@xgouchet xgouchet added this to the 1.14.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants