Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-7337: Adjust Webview Replay storage configuration limits #2400

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

jonathanmos
Copy link
Member

What does this PR do?

WebviewReplayFeature was using the default storage configuration. As a result, events sent by the browser sdk that were larger than 512kb were being rejected rather than written to batch files. This pr adjusts the size limits to align with session replay - 10mb per item and 10mb per batch.

I also added unit tests for WebviewReplayFeature as there didn't seem to be any.

Motivation

Support ticket where the customer couldn't see their webviews.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@jonathanmos jonathanmos changed the title RUM-7337: Adjust Webview Replay configuration size limits RUM-7337: Adjust Webview Replay storage configuration limits Nov 19, 2024
@jonathanmos jonathanmos force-pushed the jmoskovich/rum-7337/adjust-limits-for-webviews branch from ef6b025 to aa5f51e Compare November 19, 2024 13:13
@jonathanmos jonathanmos force-pushed the jmoskovich/rum-7337/adjust-limits-for-webviews branch from aa5f51e to c5ef356 Compare November 19, 2024 13:31
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.83%. Comparing base (bd71625) to head (c5ef356).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2400      +/-   ##
===========================================
- Coverage    70.01%   69.83%   -0.17%     
===========================================
  Files          763      763              
  Lines        28374    28367       -7     
  Branches      4763     4763              
===========================================
- Hits         19864    19810      -54     
- Misses        7222     7243      +21     
- Partials      1288     1314      +26     
Files with missing lines Coverage Δ
...id/webview/internal/replay/WebViewReplayFeature.kt 100.00% <100.00%> (+18.75%) ⬆️

... and 29 files with indirect coverage changes

---- 🚨 Try these New Features:

@jonathanmos jonathanmos marked this pull request as ready for review November 19, 2024 15:07
@jonathanmos jonathanmos requested review from a team as code owners November 19, 2024 15:07

/**
* Storage configuration with the following parameters:
* max item size = 10 MB,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious what can generate item with 10 MB size

@jonathanmos jonathanmos merged commit bf7a862 into develop Nov 20, 2024
24 checks passed
@jonathanmos jonathanmos deleted the jmoskovich/rum-7337/adjust-limits-for-webviews branch November 20, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants