Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-6866 create the DeterministicSampler #2387

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

xgouchet
Copy link
Member

What does this PR do?

Creates a DeterministicSampler implementation consistent with our backend agent implementations (Unit tests cover the Go and Java implementation)

@xgouchet xgouchet force-pushed the xgouchet/RUM-6866/knuth_sampling branch from 0224918 to 566a896 Compare November 13, 2024 14:24
@xgouchet xgouchet marked this pull request as ready for review November 13, 2024 14:27
@xgouchet xgouchet requested review from a team as code owners November 13, 2024 14:28
@xgouchet xgouchet force-pushed the xgouchet/RUM-6866/knuth_sampling branch from 566a896 to 426dbca Compare November 13, 2024 14:30
Base automatically changed from xgouchet/RUM-6866/allow_typed_sampler to develop November 13, 2024 14:53
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.30%. Comparing base (808f3d7) to head (426dbca).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...adog/android/core/sampling/DeterministicSampler.kt 92.59% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2387      +/-   ##
===========================================
- Coverage    70.31%   70.30%   -0.01%     
===========================================
  Files          744      745       +1     
  Lines        27694    27716      +22     
  Branches      4621     4627       +6     
===========================================
+ Hits         19471    19483      +12     
+ Misses        6947     6938       -9     
- Partials      1276     1295      +19     
Files with missing lines Coverage Δ
...adog/android/core/sampling/DeterministicSampler.kt 92.59% <92.59%> (ø)

... and 36 files with indirect coverage changes

dd-sdk-android-core/api/apiSurface Show resolved Hide resolved
@xgouchet xgouchet merged commit 81d4b54 into develop Nov 13, 2024
23 checks passed
@xgouchet xgouchet deleted the xgouchet/RUM-6866/knuth_sampling branch November 13, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants