-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-3460: Fix padding and resizing issue for image view mapper #2372
Conversation
...com/datadog/android/sessionreplay/internal/recorder/resources/DefaultImageWireframeHelper.kt
Show resolved
Hide resolved
6333f4c
to
95ab882
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2372 +/- ##
===========================================
+ Coverage 70.30% 70.37% +0.07%
===========================================
Files 744 744
Lines 27721 27726 +5
Branches 4630 4630
===========================================
+ Hits 19488 19512 +24
+ Misses 6947 6936 -11
+ Partials 1286 1278 -8
|
95ab882
to
fe466c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
Shouldn't we have some unit tests around those functions ?
fe466c9
to
39c3e59
Compare
@xgouchet there are unit tests around these, I just updated with the padding case to cover it better, and instrumented test payloads are regenerated for them. |
What does this PR do?
In app development, clients usually use paddings to resize the content drawable in a given size image view, prior to this PR we didn't taken into account these paddings to resize our image wireframe, which leads some images/icons bigger than real.
So the updates in this PR:
resolveParentRectAbsPosition
functionGradientDrawable
didn't take into account the width&height after resizing.Motivation
RUM-3460
Demo
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)