Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-6194: Add Semantics Mapper for Button role #2296

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

ambushwork
Copy link
Member

What does this PR do?

Add Semantics Mapper for Button role

Motivation

RUM-6194

Demo

Sample App Session Replay
image image

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork force-pushed the yl/compose/semantics-button-role branch from 5847e03 to d675d8c Compare September 27, 2024 13:19
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 14 lines in your changes missing coverage. Please review.

Project coverage is 69.55%. Comparing base (c37edce) to head (afe85c6).
Report is 2 commits behind head on feature/sr_compose.

Files with missing lines Patch % Lines
...ionreplay/compose/internal/utils/SemanticsUtils.kt 0.00% 10 Missing ⚠️
...nal/mappers/semantics/ButtonSemanticsNodeMapper.kt 90.00% 0 Missing and 2 partials ⚠️
...y/compose/internal/reflection/ComposeReflection.kt 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/sr_compose    #2296      +/-   ##
======================================================
- Coverage               69.58%   69.55%   -0.04%     
======================================================
  Files                     750      751       +1     
  Lines                   27738    27809      +71     
  Branches                 4732     4745      +13     
======================================================
+ Hits                    19301    19340      +39     
- Misses                   7105     7131      +26     
- Partials                 1332     1338       +6     
Files with missing lines Coverage Δ
...l/mappers/semantics/AbstractSemanticsNodeMapper.kt 87.50% <ø> (+13.82%) ⬆️
...rnal/mappers/semantics/SemanticsWireframeMapper.kt 77.42% <100.00%> (+0.75%) ⬆️
...nal/mappers/semantics/ButtonSemanticsNodeMapper.kt 90.00% <90.00%> (ø)
...y/compose/internal/reflection/ComposeReflection.kt 16.00% <33.33%> (+0.54%) ⬆️
...ionreplay/compose/internal/utils/SemanticsUtils.kt 5.26% <0.00%> (-5.85%) ⬇️

... and 35 files with indirect coverage changes

@ambushwork ambushwork force-pushed the yl/compose/semantics-button-role branch from d675d8c to 6f18ec7 Compare September 27, 2024 15:04
@ambushwork ambushwork marked this pull request as ready for review September 27, 2024 16:27
@ambushwork ambushwork requested review from a team as code owners September 27, 2024 16:27
0xnm
0xnm previously approved these changes Sep 27, 2024
Copy link
Member

@0xnm 0xnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to see how Jetpack Compose is finally getting a shape in Session Replay.

mariusc83
mariusc83 previously approved these changes Sep 30, 2024
xgouchet
xgouchet previously approved these changes Sep 30, 2024
@ambushwork ambushwork force-pushed the yl/compose/semantics-button-role branch from 6f18ec7 to 8198b46 Compare September 30, 2024 11:13
@ambushwork ambushwork force-pushed the yl/compose/semantics-button-role branch from 8198b46 to afe85c6 Compare September 30, 2024 11:15
@ambushwork ambushwork merged commit 4f6ed19 into feature/sr_compose Oct 1, 2024
23 checks passed
@ambushwork ambushwork deleted the yl/compose/semantics-button-role branch October 1, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants