Improve test coverage of core unit tests #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgouchet
force-pushed
the
xgouchet/reliability/coverage
branch
from
07b8460 to
810e356
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2294 +/- ##
===========================================
+ Coverage 69.97% 70.26% +0.29%
===========================================
Files 733 730 -3
Lines 27236 27259 +23
Branches 4576 4583 +7
===========================================
+ Hits 19058 19152 +94
+ Misses 6894 6832 -62
+ Partials 1284 1275 -9
|
0xnm
approved these changes
Sep 27, 2024
| return false | ||
| false |
There was a problem hiding this comment.
such a tiny typo, but such a big functional change
gradle/libs.versions.toml
Outdated
| @@ -7,7 +7,7 @@ okHttp = "4.12.0" | |||
| kronosNTP = "0.0.1-alpha11" | |||
|
|
|||
| # Android | |||
| androidToolsPlugin = "8.6.1" | |||
| androidToolsPlugin = "8.5.2" | |||
There was a problem hiding this comment.
Oh this shouldn't have been part of the commit, it's because I use IJ instead of AS ans IJ doesn't support the latest AGP.
| @@ -23,7 +24,7 @@ import org.mockito.junit.jupiter.MockitoExtension | |||
| @ForgeConfiguration(Configurator::class) | |||
| internal class ThreadExtTest { | |||
|
|
|||
| @Test | |||
| @RepeatedTest(16) | |||
There was a problem hiding this comment.
is this change on purpose or some debugging leftover?
There was a problem hiding this comment.
This is on purpose to go over all the possible states
| // Given | ||
| val fakeDelay = TimeUnit.SECONDS.toNanos(forge.aLong(min = 0, max = 2)) | ||
| val mockedBlock: () -> Boolean = mock() | ||
| whenever(mockedBlock.invoke()).thenAnswer { throw exception }.thenReturn(true) |
There was a problem hiding this comment.
probably can be shorter a bit
Suggested change
| whenever(mockedBlock.invoke()).thenAnswer { throw exception }.thenReturn(true) | |
| whenever(mockedBlock.invoke()).thenThrow(exception).thenReturn(true) |
jonathanmos
approved these changes
Sep 29, 2024
xgouchet
force-pushed
the
xgouchet/reliability/coverage
branch
from
810e356 to
c1f2e34
Compare
0xnm
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add missing UT on some core module classes, and improve some UT for maintainability