-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-6189: Add Abstract and Text semantics mapper for compose SR #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/sr_compose #2292 +/- ##
======================================================
- Coverage 69.73% 69.52% -0.20%
======================================================
Files 746 750 +4
Lines 27642 27742 +100
Branches 4696 4733 +37
======================================================
+ Hits 19274 19287 +13
- Misses 7058 7120 +62
- Partials 1310 1335 +25
|
ambushwork
force-pushed
the
yl/compose/semenatics-mapper
branch
2 times, most recently
from
September 27, 2024 09:01
b7b556c
to
1ec890c
Compare
0xnm
reviewed
Sep 27, 2024
...datadog/android/sessionreplay/compose/internal/mappers/semantics/SemanticsWireframeMapper.kt
Outdated
Show resolved
Hide resolved
.../datadog/android/sessionreplay/compose/internal/mappers/semantics/TextSemanticsNodeMapper.kt
Outdated
Show resolved
Hide resolved
.../datadog/android/sessionreplay/compose/internal/mappers/semantics/TextSemanticsNodeMapper.kt
Outdated
Show resolved
Hide resolved
.../android/sessionreplay/compose/internal/mappers/semantics/AbstractSemanticsNodeMapperTest.kt
Outdated
Show resolved
Hide resolved
.../android/sessionreplay/compose/internal/mappers/semantics/AbstractSemanticsNodeMapperTest.kt
Outdated
Show resolved
Hide resolved
...dog/android/sessionreplay/compose/internal/mappers/semantics/SemanticsWireframeMapperTest.kt
Outdated
Show resolved
Hide resolved
ambushwork
force-pushed
the
yl/compose/semenatics-mapper
branch
2 times, most recently
from
September 27, 2024 11:24
6c7c385
to
69681f8
Compare
0xnm
previously approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
ambushwork
force-pushed
the
yl/compose/semenatics-mapper
branch
from
September 27, 2024 11:56
69681f8
to
fc14db6
Compare
0xnm
approved these changes
Sep 27, 2024
xgouchet
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is the commit to set up the framework to support Jetpack compose session replay with semantics solution.
In this commit the principals changes are:
AbstractSemanticsNodeMapper
as the basic mapper providing some common functions for semantics mappingTextSemanticsNodeMapper
for the composeText
composable.ComposeView
will be mapped fromComposeWireframeMapper
instead ofSemanticsWireframeMapper
.Demo
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)