-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-6218: Add privacy override for hidden views #2291
Merged
jonathanmos
merged 1 commit into
develop
from
jmoskovich/rum-6218/implement-hidden-privacy-override
Oct 14, 2024
Merged
RUM-6218: Add privacy override for hidden views #2291
jonathanmos
merged 1 commit into
develop
from
jmoskovich/rum-6218/implement-hidden-privacy-override
Oct 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanmos
force-pushed
the
jmoskovich/rum-6218/implement-hidden-privacy-override
branch
3 times, most recently
from
September 26, 2024 11:58
de3f7ed
to
f466427
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2291 +/- ##
===========================================
+ Coverage 70.31% 70.33% +0.02%
===========================================
Files 736 738 +2
Lines 27456 27493 +37
Branches 4606 4610 +4
===========================================
+ Hits 19305 19337 +32
- Misses 6862 6873 +11
+ Partials 1289 1283 -6
|
jonathanmos
force-pushed
the
jmoskovich/rum-6218/implement-hidden-privacy-override
branch
4 times, most recently
from
September 29, 2024 12:42
bb60c2e
to
601398b
Compare
xgouchet
requested changes
Sep 30, 2024
...-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/PrivacyOverrideManager.kt
Outdated
Show resolved
Hide resolved
...lay/src/main/kotlin/com/datadog/android/sessionreplay/internal/recorder/TreeViewTraversal.kt
Outdated
Show resolved
Hide resolved
ambushwork
reviewed
Sep 30, 2024
...ession-replay/src/main/kotlin/com/datadog/android/sessionreplay/PrivacyOverrideExtensions.kt
Outdated
Show resolved
Hide resolved
...ssion-replay/src/test/kotlin/com/datadog/android/sessionreplay/PrivacyOverrideManagerTest.kt
Outdated
Show resolved
Hide resolved
0xnm
reviewed
Oct 1, 2024
...session-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/PrivacyOverride.kt
Outdated
Show resolved
Hide resolved
...-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/PrivacyOverrideManager.kt
Outdated
Show resolved
Hide resolved
mariusc83
reviewed
Oct 1, 2024
...-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/PrivacyOverrideManager.kt
Outdated
Show resolved
Hide resolved
jonathanmos
changed the title
RUM-6218: Add privacy override for hidden views
(WIP) RUM-6218: Add privacy override for hidden views
Oct 2, 2024
jonathanmos
force-pushed
the
jmoskovich/rum-6218/implement-hidden-privacy-override
branch
6 times, most recently
from
October 7, 2024 08:32
9a71fee
to
97b9bc9
Compare
jonathanmos
commented
Oct 7, 2024
...ession-replay/src/main/kotlin/com/datadog/android/sessionreplay/PrivacyOverrideExtensions.kt
Show resolved
Hide resolved
jonathanmos
force-pushed
the
jmoskovich/rum-6218/implement-hidden-privacy-override
branch
from
October 7, 2024 08:34
97b9bc9
to
11ed3d1
Compare
jonathanmos
changed the title
(WIP) RUM-6218: Add privacy override for hidden views
RUM-6218: Add privacy override for hidden views
Oct 7, 2024
xgouchet
approved these changes
Oct 8, 2024
...ession-replay/src/main/kotlin/com/datadog/android/sessionreplay/PrivacyOverrideExtensions.kt
Show resolved
Hide resolved
jonathanmos
force-pushed
the
jmoskovich/rum-6218/implement-hidden-privacy-override
branch
from
October 9, 2024 17:50
fa68b66
to
b6fb5c1
Compare
0xnm
approved these changes
Oct 11, 2024
features/dd-sdk-android-session-replay/src/main/res/values/ids.xml
Outdated
Show resolved
Hide resolved
...st/kotlin/com/datadog/android/sessionreplay/internal/recorder/mapper/HiddenViewMapperTest.kt
Outdated
Show resolved
Hide resolved
jonathanmos
force-pushed
the
jmoskovich/rum-6218/implement-hidden-privacy-override
branch
from
October 14, 2024 07:57
715c7b1
to
f16a5d4
Compare
mariusc83
approved these changes
Oct 14, 2024
ambushwork
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, well done!
jonathanmos
deleted the
jmoskovich/rum-6218/implement-hidden-privacy-override
branch
October 14, 2024 08:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sets up the common mechanism for privacy overrides and implements overriding view privacy to
hidden
in the hierarchy.Views will be able to set hidden override privacy using the api:
[view].setSessionReplayHidden(hide = true/false)
where true will register the view to be replaced with a placeholder with the label "Hidden", and false will remove the hidden override from the view. The children of hidden views will not be traversed.
Motivation
This is part of the third stage of Fine Grained Masking. The first stage was the start/stop api, and the second was global fine grained masking levels for the app.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)