Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-6316: Remove Session Replay button mapper border #2280

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

ambushwork
Copy link
Member

What does this PR do?

Remove Session Replay button mapper border.

The logic before was adding a black border to every text view inside which doesn't have a shape or border, But text view mapper always return a wireframe without them, so the black border will always be applied, which doesn't correspond to the real UI.

Motivation

RUM-6316

Demo

App Screen Before After
Screenshot 2024-09-24 at 14 21 10 image image
Screenshot 2024-09-24 at 14 22 51 image image

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork requested review from a team as code owners September 24, 2024 12:25
@ambushwork ambushwork force-pushed the yl/sr/remove-button-border branch from 420154c to b5c485a Compare September 24, 2024 12:46
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.03%. Comparing base (26c28e2) to head (b5c485a).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2280      +/-   ##
===========================================
- Coverage    70.18%   70.03%   -0.16%     
===========================================
  Files          732      732              
  Lines        27227    27192      -35     
  Branches      4580     4573       -7     
===========================================
- Hits         19109    19042      -67     
- Misses        6861     6873      +12     
- Partials      1257     1277      +20     
Files with missing lines Coverage Δ
...ionreplay/internal/recorder/mapper/ButtonMapper.kt 100.00% <100.00%> (+27.27%) ⬆️

... and 25 files with indirect coverage changes

@ambushwork ambushwork merged commit 93c106f into develop Sep 24, 2024
23 checks passed
@ambushwork ambushwork deleted the yl/sr/remove-button-border branch September 24, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants