Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING doc changes #2275

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Sep 23, 2024

What does this PR do?

Minor changes: update of the templates links and Detekt/Ktlint versions used.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners September 23, 2024 09:45
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (ce17163) to head (0f35539).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2275      +/-   ##
===========================================
- Coverage    70.05%   70.04%   -0.01%     
===========================================
  Files          732      732              
  Lines        27209    27226      +17     
  Branches      4579     4580       +1     
===========================================
+ Hits         19060    19068       +8     
- Misses        6876     6878       +2     
- Partials      1273     1280       +7     

see 27 files with indirect coverage changes

@0xnm 0xnm force-pushed the nogorodnikov/contributing-doc-changes branch from 099f99a to 0f35539 Compare September 23, 2024 11:42
@0xnm 0xnm merged commit 3f21b91 into develop Sep 23, 2024
23 checks passed
@0xnm 0xnm deleted the nogorodnikov/contributing-doc-changes branch September 23, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants