Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DatadogInterceptor flaky test #2274

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

ambushwork
Copy link
Member

What does this PR do?

Fix DatadogInterceptor flaky test

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork marked this pull request as ready for review September 23, 2024 08:19
@ambushwork ambushwork requested review from a team as code owners September 23, 2024 08:19
Copy link
Member

@0xnm 0xnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! but the same should be applied to the test above as well.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.01%. Comparing base (ce17163) to head (36a3abc).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2274      +/-   ##
===========================================
- Coverage    70.05%   70.01%   -0.04%     
===========================================
  Files          732      732              
  Lines        27209    27198      -11     
  Branches      4579     4578       -1     
===========================================
- Hits         19060    19042      -18     
+ Misses        6876     6873       -3     
- Partials      1273     1283      +10     

see 29 files with indirect coverage changes

@ambushwork
Copy link
Member Author

nice catch! but the same should be applied to the test above as well.

@0xnm if I understand correctly, the test above specifically set the mimeType a stream content type, which will always be parsed as Native type, which will not have a flaky result.

@ambushwork ambushwork requested a review from 0xnm September 23, 2024 09:25
@ambushwork ambushwork merged commit 91a98e4 into develop Sep 23, 2024
23 checks passed
@ambushwork ambushwork deleted the yl/fix-interceptor-flaky-test branch September 23, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants