Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Image Privacy a public api #2204

Merged

Conversation

jonathanmos
Copy link
Member

@jonathanmos jonathanmos commented Aug 20, 2024

What does this PR do?

• Expose Image Privacy as a public api on the feature branch as part of fine grained masking (in develop it's still an internal api).
• Also change the default masking level to MASK_ALL as per the RFC.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.97%. Comparing base (d10126e) to head (2266b72).
Report is 2 commits behind head on feature/fine-grained-masking.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           feature/fine-grained-masking    #2204      +/-   ##
================================================================
- Coverage                         69.99%   69.97%   -0.02%     
================================================================
  Files                               726      726              
  Lines                             27050    27046       -4     
  Branches                           4543     4542       -1     
================================================================
- Hits                              18931    18924       -7     
  Misses                             6837     6837              
- Partials                           1282     1285       +3     
Files Coverage Δ
...ndroid/sessionreplay/SessionReplayConfiguration.kt 100.00% <100.00%> (ø)

... and 27 files with indirect coverage changes

@jonathanmos jonathanmos marked this pull request as ready for review August 20, 2024 11:37
@jonathanmos jonathanmos requested review from a team as code owners August 20, 2024 11:37
@jonathanmos jonathanmos merged commit 0b04b79 into feature/fine-grained-masking Aug 21, 2024
22 checks passed
@jonathanmos jonathanmos deleted the jmoskovich/prepare-image-privacy branch August 21, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants