Fix integration tests pipeline for API 21 #2197
Conversation
mariusc83
force-pushed
the
mconstantin/rum-5849/fix-instrumented-tests-on-api-21-emulators
branch
2 times, most recently
from
dbb8f8c to
c6765b9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2197 +/- ##
===========================================
+ Coverage 69.93% 69.96% +0.03%
===========================================
Files 726 726
Lines 26967 26970 +3
Branches 4526 4522 -4
===========================================
+ Hits 18858 18868 +10
+ Misses 6830 6829 -1
+ Partials 1279 1273 -6 |
.gitlab-ci.yml
Outdated
| run-instrumented-integration: | ||
| compile_instrumented_integration: | ||
| - $ANDROID_HOME/emulator/emulator -avd "$EMULATOR_NAME" -grpc-use-jwt -no-snapstorage -no-audio -no-window -no-boot-anim -verbose -qemu -machine virt & | ||
| - GRADLE_OPTS="-Xmx3072m" ./gradlew :instrumented:integration:assembleDebug :instrumented:integration:assembleDebugAndroidTest --stacktrace --no-daemon | ||
| compile_instrumented_integration_for_api_21: | ||
| - $ANDROID_HOME/emulator/emulator -avd "$EMULATOR_NAME" -grpc-use-jwt -no-snapstorage -no-audio -no-window -no-boot-anim -verbose -qemu -machine virt & | ||
| - GRADLE_OPTS="-Xmx3072m" ./gradlew :instrumented:integration:assembleDebug :instrumented:integration:assembleDebugAndroidTest -Puse-api21-java-backport -Puse-desugaring --stacktrace --no-daemon | ||
| run-instrumented-integration: |
There was a problem hiding this comment.
you can still keep run-instrumented-integration step without splitting and use the same technique to append -Puse-api21-java-backport -Puse-desugaring flags as I used in #2193
also do we need use-desugarding flag? seems we can simply use use-api21-java-backport
There was a problem hiding this comment.
ok will try that technique instead. But regarding desugaring flag...I would rather keep them separated (one is for desugaring, the other is for java backport)
| @@ -27,6 +28,7 @@ internal class SrCheckBoxAndRadioFieldsAllowTest : | |||
| ) | |||
|
|
|||
| @Test | |||
| @Ignore("These tests were not maintained anymore and they need to be fixed") | |||
There was a problem hiding this comment.
we need to add TODO reference everywhere we add this annotation
There was a problem hiding this comment.
do we need to add this if we add desugaring?
There was a problem hiding this comment.
do we need to add this if we add desugaring?
There was a problem hiding this comment.
yes because desugaring doesn't handle everything (this and the Path class are not handled :( )
mariusc83
force-pushed
the
mconstantin/rum-5849/fix-instrumented-tests-on-api-21-emulators
branch
2 times, most recently
from
f8a2ab1 to
a114bd5
Compare
mariusc83
force-pushed
the
mconstantin/rum-5849/fix-instrumented-tests-on-api-21-emulators
branch
from
a114bd5 to
15b65be
Compare
mariusc83
deleted the
mconstantin/rum-5849/fix-instrumented-tests-on-api-21-emulators
branch
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)