Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up IdGenerationStrategy test #2187

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Aug 13, 2024

What does this PR do?

M generate id with strategyName and tIdSize bits test was taking almost 1 minute to run on my machine (takes even more on CI), so speeding it up by lowering down the number of trace IDs being generated.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners August 13, 2024 08:44
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.99%. Comparing base (27f8ab9) to head (2a1cd13).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2187      +/-   ##
===========================================
+ Coverage    69.96%   69.99%   +0.03%     
===========================================
  Files          726      726              
  Lines        26978    26997      +19     
  Branches      4524     4523       -1     
===========================================
+ Hits         18875    18896      +21     
+ Misses        6831     6829       -2     
  Partials      1272     1272              

see 33 files with indirect coverage changes

@0xnm 0xnm merged commit 84541d2 into develop Aug 13, 2024
22 checks passed
@0xnm 0xnm deleted the nogorodnikov/speed-up-idgenerationstrategy-test branch August 13, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants