-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-5780:Use SurfaceCompoitionGroupMapper to support container components in SR #2182
RUM-5780:Use SurfaceCompoitionGroupMapper to support container components in SR #2182
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/sr_compose #2182 +/- ##
======================================================
+ Coverage 82.30% 82.35% +0.06%
======================================================
Files 514 514
Lines 18353 18348 -5
Branches 2821 2821
======================================================
+ Hits 15104 15110 +6
+ Misses 2488 2474 -14
- Partials 761 764 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor doc edit suggestion, otherwise lgtm.
/** | ||
* This class is responsible to map the Jetpack compose components which have "backgroundColor" & "contentColor" | ||
* in the parameter list, these components are mostly container components such as [BottomNavigation], [TopAppBar] | ||
* and [TabRow], etc.., they usually have a [Surface] implementation under the hood, and can take other composable | ||
* inside. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** | |
* This class is responsible to map the Jetpack compose components which have "backgroundColor" & "contentColor" | |
* in the parameter list, these components are mostly container components such as [BottomNavigation], [TopAppBar] | |
* and [TabRow], etc.., they usually have a [Surface] implementation under the hood, and can take other composable | |
* inside. | |
*/ | |
/** | |
* This class is responsible for the mapping of the Jetpack Compose components which have "backgroundColor" & "contentColor" | |
* in the parameter list. These components are mostly container components such as [BottomNavigation], [TopAppBar] | |
* and [TabRow], etc. They usually have a [Surface] implementation under the hood, and can take other composable | |
* inside. | |
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
What does this PR do?
TabRowCompositionGroupMapper
toSurfaceCompoitionGroupMapper
, because the way it maps the wireframe can be reused in a lot of Jetpack compose container components such as BottomNavigation, TopAppBar, TabRow.Motivation
RUM-5780
Review checklist (to be filled by reviewers)