Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract logic to pull publishing credentials into a dedicated snippet #2176

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Aug 12, 2024

What does this PR do?

Small improvement to the Gitlab CI file: common calls to pull credentials are extracted into a dedicated snippet.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners August 12, 2024 09:23
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.01%. Comparing base (82871ea) to head (0296277).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2176   +/-   ##
========================================
  Coverage    70.01%   70.01%           
========================================
  Files          726      726           
  Lines        26997    26987   -10     
  Branches      4525     4521    -4     
========================================
- Hits         18900    18893    -7     
  Misses        6829     6829           
+ Partials      1268     1265    -3     

see 31 files with indirect coverage changes

@0xnm 0xnm merged commit 174083a into develop Aug 12, 2024
22 checks passed
@0xnm 0xnm deleted the nogorodnikov/publishing-improvements-110724 branch August 12, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants