Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset developerMode status when Datadog stop #2174

Merged

Conversation

mariusc83
Copy link
Member

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 self-assigned this Aug 8, 2024
@mariusc83 mariusc83 requested review from a team as code owners August 8, 2024 08:41
@ambushwork
Copy link
Member

LGTM, it will be nice to add some description in the PR for understanding the context, especially about what was the bug prior to this commit.

I will approve it when the pipeline is fixed

@mariusc83 mariusc83 force-pushed the mconstantin/reset-developer-mode-when-datadog-stop branch from 08f3cb8 to 56fd3c4 Compare August 8, 2024 09:52
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.03%. Comparing base (5536f75) to head (56fd3c4).
Report is 34 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2174      +/-   ##
===========================================
+ Coverage    70.02%   70.03%   +0.01%     
===========================================
  Files          726      726              
  Lines        27001    26997       -4     
  Branches      4525     4525              
===========================================
+ Hits         18906    18907       +1     
- Misses        6819     6821       +2     
+ Partials      1276     1269       -7     
Files Coverage Δ
...n/com/datadog/android/core/internal/DatadogCore.kt 82.22% <100.00%> (+0.16%) ⬆️

... and 29 files with indirect coverage changes

@mariusc83 mariusc83 merged commit 82871ea into develop Aug 12, 2024
22 checks passed
@mariusc83 mariusc83 deleted the mconstantin/reset-developer-mode-when-datadog-stop branch August 12, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants