Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-4738: Add "Tab" and "TabRow" Composable groups mappers #2171

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

ambushwork
Copy link
Member

What does this PR do?

Add "Tab" and "TabRow" Composable groups mappers, so that "Tab" & "TabRow" can have:

  • correct position in SR
  • correct color in SR
  • correct size in SR

Motivation

RUM-4738

Demo

(The other components in the screen is a bit glitchy, but Tab and TabRow is working)

https://mobile-integration.datadoghq.com/rum/replay/sessions/0d175d4a-4087-4cc9-8abc-fe22ee7d3c0e?applicationId=38030dde-f9f9-4e52-9443-b9804a030080&seed=e05a16d0-ea37-4f5b-b4fd-2ff7f27fe3fb&ts=1723037890870

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork requested review from a team as code owners August 7, 2024 13:44
@ambushwork ambushwork force-pushed the yl/add-tab-compose-support branch from b87350d to 15eb3df Compare August 7, 2024 13:44
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.39%. Comparing base (56b3fe3) to head (c80b414).
Report is 1 commits behind head on feature/sr_compose.

Files Patch % Lines
...e/internal/mappers/TabRowCompositionGroupMapper.kt 89.47% 0 Missing and 2 partials ⚠️
...pose/internal/mappers/TabCompositionGroupMapper.kt 94.74% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/sr_compose    #2171      +/-   ##
======================================================
+ Coverage               82.13%   82.39%   +0.26%     
======================================================
  Files                     512      514       +2     
  Lines                   18295    18353      +58     
  Branches                 2814     2821       +7     
======================================================
+ Hits                    15026    15121      +95     
+ Misses                   2506     2470      -36     
+ Partials                  763      762       -1     
Files Coverage Δ
...internal/mappers/AbstractCompositionGroupMapper.kt 88.89% <ø> (+22.22%) ⬆️
...compose/internal/mappers/ComposeWireframeMapper.kt 14.10% <100.00%> (+2.26%) ⬆️
...pose/internal/mappers/TabCompositionGroupMapper.kt 94.74% <94.74%> (ø)
...e/internal/mappers/TabRowCompositionGroupMapper.kt 89.47% <89.47%> (ø)

... and 30 files with indirect coverage changes

@ambushwork ambushwork force-pushed the yl/add-tab-compose-support branch from 15eb3df to c80b414 Compare August 8, 2024 08:54
@ambushwork ambushwork requested a review from mariusc83 August 8, 2024 08:54
@ambushwork ambushwork merged commit 6f5d4cf into feature/sr_compose Aug 12, 2024
20 checks passed
@ambushwork ambushwork deleted the yl/add-tab-compose-support branch August 12, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants