RUM-483 use macos runner #2154
Merged
RUM-483 use macos runner #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2154 +/- ##
===========================================
- Coverage 69.99% 69.96% -0.03%
===========================================
Files 726 726
Lines 26984 26995 +11
Branches 4520 4524 +4
===========================================
Hits 18887 18887
- Misses 6827 6832 +5
- Partials 1270 1276 +6 |
fuzzybinary
approved these changes
Jul 30, 2024
.gitlab-ci.yml
Outdated
| @@ -26,6 +30,34 @@ stages: | |||
| - publish | |||
| - notify | |||
|
|
|||
| .snippets: | |||
| install-android-sdk: | |||
| - curl -sSL -o commandlinetools.zip https://dl.google.com/android/repository/commandlinetools-mac-11076708_latest.zip | |||
There was a problem hiding this comment.
Should we put the version in an easier to modify variable?
| - echo y | ~/android_sdk/cmdline-tools/latest/bin/sdkmanager --install "$ANDROID_BUILD_TOOLS" | ||
| - echo y | ~/android_sdk/cmdline-tools/latest/bin/sdkmanager --install "$ANDROID_EMULATOR_IMAGE" | ||
| - yes | ~/android_sdk/cmdline-tools/latest/bin/sdkmanager --licenses || true | ||
| - echo "no" | ~/android_sdk/cmdline-tools/latest/bin/avdmanager --verbose create avd --force --name "$EMULATOR_NAME" --package "$ANDROID_EMULATOR_IMAGE" |
There was a problem hiding this comment.
Does this work okay if the emulator already exists? I assume that's what the echo "no" is for?
There was a problem hiding this comment.
Yes, in theory the emulator can't exist before hand, the no is there to prevent creating a backup of the data between emulator runs
.gitlab-ci.yml
Outdated
| run-instrumented-integration: | ||
| - $ANDROID_HOME/emulator/emulator -avd "$EMULATOR_NAME" -grpc-use-jwt -no-snapstorage -no-audio -no-window -no-boot-anim -verbose -qemu -machine virt & | ||
| - GRADLE_OPTS="-Xmx3072m" ./gradlew :instrumented:integration:assembleDebug :instrumented:integration:assembleDebugAndroidTest --stacktrace --no-daemon | ||
| # - ./android-wait-for-emulator.sh |
There was a problem hiding this comment.
Purposefully commented out?
xgouchet
force-pushed
the
xgouchet/RUM-483/gitlab_macos
branch
from
24d3125 to
806342c
Compare
xgouchet
force-pushed
the
xgouchet/RUM-483/gitlab_macos
branch
from
806342c to
02d2aa7
Compare
jonathanmos
approved these changes
Jul 31, 2024
xgouchet
force-pushed
the
xgouchet/RUM-483/gitlab_macos
branch
from
02d2aa7 to
e673497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds instrumented test support to our Gitlab CI pipeline