Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM-4986] Decrease Batch Metrics sample rate to 10% of its original value #2146

Merged

Conversation

plousada
Copy link
Member

@plousada plousada commented Jul 26, 2024

What does this PR do?

Reduce the amount we send batch telemetry rate to 10% of its original value.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.98%. Comparing base (4a3bc9f) to head (93bf5c7).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2146      +/-   ##
===========================================
- Coverage    70.05%   69.98%   -0.06%     
===========================================
  Files          726      726              
  Lines        26995    26975      -20     
  Branches      4524     4520       -4     
===========================================
- Hits         18909    18878      -31     
- Misses        6818     6828      +10     
- Partials      1268     1269       +1     
Files Coverage Δ
...id/core/internal/metrics/BatchMetricsDispatcher.kt 98.65% <ø> (ø)

... and 34 files with indirect coverage changes

@plousada plousada marked this pull request as ready for review July 29, 2024 07:49
@plousada plousada requested review from a team as code owners July 29, 2024 07:49
@plousada plousada merged commit 6319509 into develop Jul 29, 2024
19 checks passed
@plousada plousada deleted the plousada/RUM-4986/decrease_batch_metrics_sample_rate branch July 29, 2024 07:49
@plousada plousada changed the title [RUM-4986] Decrease Batch Metrics sample rate by 10% [RUM-4986] Decrease Batch Metrics sample rate to 10% of its original value Jul 29, 2024
@xgouchet xgouchet added this to the 2.12.x milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants