RUM-5553: Create Benchmark module to collect performance metrics #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/metric-benchmark #2141 +/- ##
============================================================
- Coverage 70.10% 69.96% -0.14%
============================================================
Files 726 726
Lines 26977 26976 -1
Branches 4520 4520
============================================================
- Hits 18911 18873 -38
- Misses 6818 6829 +11
- Partials 1248 1274 +26 |
ambushwork
force-pushed
the
yl/add-tools-module
branch
2 times, most recently
from
211b392 to
f68bcd8
Compare
xgouchet
requested changes
Jul 24, 2024
ambushwork
force-pushed
the
yl/add-tools-module
branch
from
f68bcd8 to
9ce8f69
Compare
ambushwork
force-pushed
the
yl/add-tools-module
branch
from
9ce8f69 to
2f10387
Compare
mariusc83
approved these changes
Jul 25, 2024
xgouchet
approved these changes
Jul 25, 2024
0xnm
reviewed
Aug 12, 2024
Comment on lines
+34
to
+35
| api(libs.openTelemetrySdk) | ||
| api(libs.openTelemetryApi) |
There was a problem hiding this comment.
this probably should be implementation, unless we want to re-export definitions in some module which will consume this one
| api(libs.openTelemetrySdk) | ||
| api(libs.openTelemetryApi) | ||
| implementation(libs.gson) | ||
| compileOnly(libs.detektApi) |
|
|
||
| testImplementation(libs.bundles.jUnit5) | ||
| testImplementation(libs.bundles.testTools) | ||
| testImplementation(libs.detektTest) |
There was a problem hiding this comment.
and this is not needed as well, I guess.
| testImplementation(libs.bundles.jUnit5) | ||
| testImplementation(libs.bundles.testTools) | ||
| testImplementation(libs.detektTest) | ||
| testImplementation(libs.robolectric) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates a module in SDK for the metrics benchmarks
Motivation
RUM-5553
Review checklist (to be filled by reviewers)