Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-4710 Make sure network local spans have kind:client tag #2136

Conversation

mariusc83
Copy link
Member

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 self-assigned this Jul 23, 2024
@mariusc83 mariusc83 force-pushed the mconstantin/rum-4710/networks-spans-are-identified-as-client-spans branch from 6bd769b to 7420e6f Compare July 23, 2024 16:18
@mariusc83 mariusc83 marked this pull request as ready for review July 23, 2024 16:19
@mariusc83 mariusc83 requested review from a team as code owners July 23, 2024 16:19
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.97%. Comparing base (b36d867) to head (7420e6f).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2136      +/-   ##
===========================================
- Coverage    70.00%   69.97%   -0.04%     
===========================================
  Files          726      726              
  Lines        26972    26962      -10     
  Branches      4520     4519       -1     
===========================================
- Hits         18881    18864      -17     
+ Misses        6826     6823       -3     
- Partials      1265     1275      +10     
Files Coverage Δ
...datadog/android/okhttp/trace/TracingInterceptor.kt 76.88% <100.00%> (+0.07%) ⬆️

... and 28 files with indirect coverage changes

@mariusc83 mariusc83 merged commit e2baaf8 into develop Jul 24, 2024
19 checks passed
@mariusc83 mariusc83 deleted the mconstantin/rum-4710/networks-spans-are-identified-as-client-spans branch July 24, 2024 09:10
@xgouchet xgouchet added this to the 2.12.x milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants