RUM-5564 increase retry delay on DNS error #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusc83
reviewed
Jul 23, 2024
| internal class DNSErrorStatusForgeryFactory : ForgeryFactory<UploadStatus.DNSError> { | ||
|
|
||
| override fun getForgery(forge: Forge): UploadStatus.DNSError { | ||
| return UploadStatus.DNSError |
There was a problem hiding this comment.
why do we need a factory here which only returns one single type of enum ?
There was a problem hiding this comment.
It's not an enum but an object as part of a sealed class
There was a problem hiding this comment.
even so in this case this factory only returns one value of that UploadStatus sealed class. Wouldn't it be more simple to just add this value in your test data without using forge ?
jonathanmos
approved these changes
Jul 24, 2024
mariusc83
approved these changes
Jul 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2135 +/- ##
===========================================
+ Coverage 70.00% 70.01% +0.01%
===========================================
Files 726 726
Lines 26970 26996 +26
Branches 4521 4524 +3
===========================================
+ Hits 18879 18901 +22
- Misses 6817 6834 +17
+ Partials 1274 1261 -13
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a DNS issue prevents the SDK from reaching our intake hosts, we increase the delay to avoid an infinite loop.
Motivation
By default our retry loop can be quite frequent, but DNS issues often take some time to be fixed. Although an actual issue in our DNS registration is unlikely, there seems to also be some issues on some networks preventing the devices from resolving the intake host address.
Additional Notes
Relates to #2131