-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RUM-5566] Added setSyntheticsAttribute in RumInternalProxy #2133
[RUM-5566] Added setSyntheticsAttribute in RumInternalProxy #2133
Conversation
ef32fea
to
6ef3f99
Compare
features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/_RumInternalProxy.kt
Outdated
Show resolved
Hide resolved
features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/_RumInternalProxy.kt
Outdated
Show resolved
Hide resolved
features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/_RumInternalProxy.kt
Outdated
Show resolved
Hide resolved
...um/src/test/kotlin/com/datadog/android/rum/utils/config/GlobalRumMonitorTestConfiguration.kt
Show resolved
Hide resolved
6ef3f99
to
5de46e9
Compare
...um/src/test/kotlin/com/datadog/android/rum/utils/config/GlobalRumMonitorTestConfiguration.kt
Show resolved
Hide resolved
...um/src/test/kotlin/com/datadog/android/rum/utils/config/GlobalRumMonitorTestConfiguration.kt
Show resolved
Hide resolved
5de46e9
to
e33b3f2
Compare
I have added a check to verify that the lateinit variable if (::sdkCore.isInitialized) {
/// ...
} A test was failing because of this missing check, as the previous implementation would only use the @mariusc83 @xgouchet let me know if you prefer to modify the test instead, or if you think this approach is safer. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2133 +/- ##
===========================================
- Coverage 69.99% 69.97% -0.02%
===========================================
Files 726 726
Lines 26984 26995 +11
Branches 4520 4524 +4
===========================================
+ Hits 18887 18889 +2
- Misses 6827 6828 +1
- Partials 1270 1278 +8
|
...id-rum/src/main/kotlin/com/datadog/android/rum/tracking/ActivityLifecycleTrackingStrategy.kt
Show resolved
Hide resolved
7020aae
to
169ddb0
Compare
169ddb0
to
13008c3
Compare
What does this PR do?
Adds
setSyntheticsAttribute
in_RumInternalProxy
for internal usage in cross-platform frameworks.Review checklist (to be filled by reviewers)