Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-4731: Add MethodCall telemetry for compose mapper #2123

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

ambushwork
Copy link
Member

What does this PR do?

Adds MethodCall telemetry for compose mapper, so that we can know the duration of each compose mapper execution.

Motivation

RUM-4731

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork requested review from a team as code owners July 8, 2024 07:56
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 82.12%. Comparing base (3ddf612) to head (75186b7).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/sr_compose    #2123      +/-   ##
======================================================
+ Coverage               81.97%   82.12%   +0.15%     
======================================================
  Files                     512      512              
  Lines                   18278    18264      -14     
  Branches                 2814     2806       -8     
======================================================
+ Hits                    14982    14998      +16     
+ Misses                   2532     2505      -27     
+ Partials                  764      761       -3     
Files Coverage Δ
...compose/internal/mappers/ComposeWireframeMapper.kt 14.06% <0.00%> (-1.19%) ⬇️

... and 38 files with indirect coverage changes

@ambushwork ambushwork merged commit 56e91c0 into feature/sr_compose Jul 8, 2024
20 checks passed
@ambushwork ambushwork deleted the yl/add-telemetry-compose-snapshot branch July 8, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants