Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-4719 Improve ButtonMapper #2070

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

xgouchet
Copy link
Member

What does this PR do?

Improve the ButtonMapper by letting it extend TextViewMapper, and add more exhaustive and cleaner tests

@xgouchet xgouchet requested review from a team as code owners May 31, 2024 08:46
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.84%. Comparing base (8e9ada1) to head (fbfa373).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2070      +/-   ##
===========================================
- Coverage    83.22%   82.84%   -0.38%     
===========================================
  Files          494      494              
  Lines        17731    17726       -5     
  Branches      2682     2681       -1     
===========================================
- Hits         14755    14684      -71     
- Misses        2247     2310      +63     
- Partials       729      732       +3     
Files Coverage Δ
.../sessionreplay/internal/DefaultRecorderProvider.kt 92.59% <100.00%> (+0.28%) ⬆️
...ionreplay/internal/recorder/mapper/ButtonMapper.kt 72.73% <100.00%> (-14.77%) ⬇️

... and 31 files with indirect coverage changes

@xgouchet xgouchet merged commit dc6dc20 into develop May 31, 2024
20 checks passed
@xgouchet xgouchet deleted the xgouchet/RUM-4719/sr_button_mapper branch May 31, 2024 10:32
@xgouchet xgouchet added this to the 2.11.x milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants