RUM-4507 Add OpenTelemetry use case into the Wear sample app #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnm
approved these changes
May 30, 2024
|
|
||
| # These annotations are introduced by OpenTelemetry API and we need to make sure R8 will not complain about them | ||
| -dontwarn com.google.** |
There was a problem hiding this comment.
Suggested change
| -dontwarn com.google.** | |
| -dontwarn com.google.** |
| @@ -25,3 +25,5 @@ | |||
| -dontwarn org.slf4j.impl.StaticLoggerBinder | |||
| -dontwarn org.slf4j.impl.StaticMDCBinder | |||
| -dontwarn reactor.blockhound.integration.BlockHoundIntegration | |||
| # These annotations are introduced by OpenTelemetry API and we need to make sure R8 will not complain about them | |||
| -dontwarn com.google.** | |||
There was a problem hiding this comment.
Suggested change
| -dontwarn com.google.** | |
| -dontwarn com.google.** |
| @@ -32,6 +32,7 @@ android { | |||
| namespace = "com.datadog.android.wear.sample" | |||
|
|
|||
| compileOptions { | |||
| isCoreLibraryDesugaringEnabled = true | |||
There was a problem hiding this comment.
so the only channel now to check how this Otel module behaves without desugaring enabled on the pre-24 APIs is now oncall app?
There was a problem hiding this comment.
nope also in Shopist...we have the Shopist running on 3 different device models
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/otel-support #2068 +/- ##
========================================================
- Coverage 67.35% 67.29% -0.06%
========================================================
Files 733 733
Lines 27001 27026 +25
Branches 4573 4574 +1
========================================================
+ Hits 18186 18187 +1
- Misses 7587 7619 +32
+ Partials 1228 1220 -8 |
mariusc83
deleted the
mconstantin/rum-4507/add-otel-module-into-wear-sample-app
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)