Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-4514 add support for progress bars #2047

Merged
merged 1 commit into from
May 30, 2024

Conversation

xgouchet
Copy link
Member

What does this PR do?

Add progress bar mapper to track those

@xgouchet xgouchet requested review from a team as code owners May 22, 2024 12:27
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

Attention: Patch coverage is 91.42857% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 83.12%. Comparing base (8e9ada1) to head (1a3137c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2047      +/-   ##
===========================================
- Coverage    83.22%   83.12%   -0.09%     
===========================================
  Files          494      495       +1     
  Lines        17731    17770      +39     
  Branches      2682     2685       +3     
===========================================
+ Hits         14755    14771      +16     
- Misses        2247     2271      +24     
+ Partials       729      728       -1     
Files Coverage Δ
.../sessionreplay/internal/DefaultRecorderProvider.kt 92.79% <100.00%> (+0.49%) ⬆️
...internal/recorder/mapper/SeekBarWireframeMapper.kt 95.35% <94.44%> (+5.35%) ⬆️
...rnal/recorder/mapper/ProgressBarWireframeMapper.kt 90.00% <90.00%> (ø)

... and 23 files with indirect coverage changes

@xgouchet xgouchet requested a review from ambushwork May 22, 2024 14:53
@xgouchet xgouchet mentioned this pull request May 23, 2024
3 tasks
@xgouchet xgouchet force-pushed the xgouchet/RUM-4514/sr_progress_bar branch from eeccf26 to 1a3137c Compare May 30, 2024 07:45
@xgouchet xgouchet merged commit 7dd2fa0 into develop May 30, 2024
20 checks passed
@xgouchet xgouchet deleted the xgouchet/RUM-4514/sr_progress_bar branch May 30, 2024 09:31
@xgouchet xgouchet added this to the 2.11.x milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants