-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-4098: Add TLVFormat DataStore persistence #2038
Conversation
410e07f
to
4d6dc78
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2038 +/- ##
===========================================
+ Coverage 83.19% 83.23% +0.04%
===========================================
Files 495 508 +13
Lines 17773 18004 +231
Branches 2685 2699 +14
===========================================
+ Hits 14785 14985 +200
- Misses 2256 2274 +18
- Partials 732 745 +13
|
.../main/kotlin/com/datadog/android/core/internal/persistence/datastore/FileDataStoreHandler.kt
Outdated
Show resolved
Hide resolved
.../main/kotlin/com/datadog/android/core/internal/persistence/datastore/FileDataStoreHandler.kt
Outdated
Show resolved
Hide resolved
...rc/main/kotlin/com/datadog/android/core/internal/persistence/tlvformat/FileTLVBlockReader.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good start! I reviewed production files so far, didn't go through the tests yet. I left some questions/suggestions.
dd-sdk-android-core/src/main/kotlin/com/datadog/android/api/feature/FeatureScope.kt
Outdated
Show resolved
Hide resolved
dd-sdk-android-core/src/main/kotlin/com/datadog/android/api/feature/FeatureScope.kt
Outdated
Show resolved
Hide resolved
dd-sdk-android-core/src/main/kotlin/com/datadog/android/api/feature/FeatureScope.kt
Outdated
Show resolved
Hide resolved
dd-sdk-android-core/src/main/kotlin/com/datadog/android/api/feature/FeatureScope.kt
Outdated
Show resolved
Hide resolved
...rc/main/kotlin/com/datadog/android/core/internal/persistence/tlvformat/FileTLVBlockReader.kt
Outdated
Show resolved
Hide resolved
...rc/main/kotlin/com/datadog/android/core/internal/persistence/tlvformat/FileTLVBlockReader.kt
Outdated
Show resolved
Hide resolved
...rc/main/kotlin/com/datadog/android/core/internal/persistence/tlvformat/FileTLVBlockReader.kt
Outdated
Show resolved
Hide resolved
...rc/main/kotlin/com/datadog/android/core/internal/persistence/tlvformat/FileTLVBlockReader.kt
Outdated
Show resolved
Hide resolved
dd-sdk-android-core/src/main/kotlin/com/datadog/android/core/internal/SdkFeature.kt
Outdated
Show resolved
Hide resolved
6279225
to
564eb64
Compare
dd-sdk-android-core/src/main/kotlin/com/datadog/android/core/internal/SdkFeature.kt
Outdated
Show resolved
Hide resolved
dd-sdk-android-core/src/main/kotlin/com/datadog/android/core/internal/SdkFeature.kt
Outdated
Show resolved
Hide resolved
.../main/kotlin/com/datadog/android/core/internal/persistence/datastore/FileDataStoreHandler.kt
Outdated
Show resolved
Hide resolved
875464b
to
459dd96
Compare
dd-sdk-android-core/src/main/kotlin/com/datadog/android/api/feature/FeatureScope.kt
Outdated
Show resolved
Hide resolved
.../main/kotlin/com/datadog/android/core/internal/persistence/datastore/DataStoreFileHandler.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/com/datadog/android/core/internal/persistence/datastore/DataStoreFileHelper.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/com/datadog/android/core/internal/persistence/datastore/DatastoreFileReader.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/com/datadog/android/core/internal/persistence/datastore/DatastoreFileReader.kt
Outdated
Show resolved
Hide resolved
dd-sdk-android-core/src/test/kotlin/com/datadog/android/core/internal/SdkFeatureTest.kt
Outdated
Show resolved
Hide resolved
dd-sdk-android-core/src/test/kotlin/com/datadog/android/core/internal/SdkFeatureTest.kt
Outdated
Show resolved
Hide resolved
...oid-core/src/main/kotlin/com/datadog/android/core/internal/persistence/tlvformat/TLVBlock.kt
Show resolved
Hide resolved
...oid-core/src/main/kotlin/com/datadog/android/core/internal/persistence/tlvformat/TLVBlock.kt
Outdated
Show resolved
Hide resolved
05dcf33
to
1c3f646
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
dd-sdk-android-core/src/main/kotlin/com/datadog/android/api/feature/FeatureScope.kt
Outdated
Show resolved
Hide resolved
dd-sdk-android-core/src/main/kotlin/com/datadog/android/api/feature/FeatureScope.kt
Outdated
Show resolved
Hide resolved
...-android-core/src/main/kotlin/com/datadog/android/api/storage/datastore/DataStoreCallback.kt
Outdated
Show resolved
Hide resolved
...-android-core/src/main/kotlin/com/datadog/android/api/storage/datastore/DataStoreCallback.kt
Show resolved
Hide resolved
...-android-core/src/main/kotlin/com/datadog/android/api/storage/datastore/DataStoreCallback.kt
Outdated
Show resolved
Hide resolved
...est/kotlin/com/datadog/android/core/internal/persistence/tlvformat/TLVBlockFileReaderTest.kt
Outdated
Show resolved
Hide resolved
...est/kotlin/com/datadog/android/core/internal/persistence/tlvformat/TLVBlockFileReaderTest.kt
Outdated
Show resolved
Hide resolved
...core/src/test/kotlin/com/datadog/android/core/internal/persistence/tlvformat/TLVBlockTest.kt
Outdated
Show resolved
Hide resolved
.../src/test/kotlin/com/datadog/android/core/internal/persistence/tlvformat/TLVBlockTypeTest.kt
Outdated
Show resolved
Hide resolved
...tlin/com/datadog/android/core/internal/persistence/file/datastore/DataStoreFileReaderTest.kt
Outdated
Show resolved
Hide resolved
...est/kotlin/com/datadog/android/core/internal/persistence/tlvformat/TLVBlockFileReaderTest.kt
Outdated
Show resolved
Hide resolved
...est/kotlin/com/datadog/android/core/internal/persistence/tlvformat/TLVBlockFileReaderTest.kt
Outdated
Show resolved
Hide resolved
ba49a80
to
cc27469
Compare
What does this PR do?
Adds the capability to write/read files in TLVformat, and defines a DataStore type that features can use to persist data between sessions.
Motivation
Part of the effort to persist bitmap hashes between sessions. Integrating the datastore with SR will be in a second PR.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)